From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754053AbdKIJQX (ORCPT ); Thu, 9 Nov 2017 04:16:23 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:59724 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754041AbdKIJQP (ORCPT ); Thu, 9 Nov 2017 04:16:15 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20171109091613epoutp038646e07d287e41f14919619366d43c44~1YCe6Kdt91570815708epoutp03m X-AuditID: b6c32a36-325ff70000001039-c6-5a041cdd8820 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="utf-8" Message-id: <5A041CDF.1030504@samsung.com> Date: Thu, 09 Nov 2017 18:16:15 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: SF Markus Elfring , kernel-janitors@vger.kernel.org, Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , MyungJoo Ham Cc: LKML Subject: Re: [PATCH] extcon: max8997: Delete an unnecessary variable initialisation in max8997_muic_set_path() In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPKsWRmVeSWpSXmKPExsWy7bCmru5dGZYog2UnFS02zljPanG+czmz xdZb0hbnz29gt7i8aw6bxe3GFWwObB6bVnWyefRtWcXo0XSqndXj8ya5AJaoVJuM1MSU1CKF 1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoN1KCmWJOaVAoYDE4mIl fTubovzSklSFjPziElulaENDIz1DA3M9IyMjPRPjWCsjU6CShNSMv1sPMhes46hY0tjF0sD4 lK2LkZNDQsBEYvmzbYwgtpDADkaJji0uEPZ3RolFT3JhaqZNP83UxcgFFN/AKLFs/kcWkASv gKDEj8n3gGwODmYBeYkjl7JBwswCmhIvvkxigai/xygxq+sRM0S9lsSR84/YQWwWAVWJOTff gsXZgOL7X9wAO4hfQFHi6o/HYAeJCkRI7Jz/jR1kkIjAI0aJVYuvMUFsUJfYtu8KK4gtLFAg cWr7X7BBnAKeEvPv7QdrkBDYwSZxtvs1E8QLLhJr731jh7CFJV4d38IOcrWEgLTEpaO2EPXt jBKb59xjgXA6GCXur2xkhWgwljjV1Qi1mU/i3dceVohmXomONiGIEg+JnaseQIPUUeLx0V/Q IJ3DKLH1cNIERrlZSAE2CxFgs5ACbAEj8ypGsdSC4tz01GLDAiO94sTc4tK8dL3k/NxNjODE pmW2g3HROZ9DjAIcjEo8vC9WMUcJsSaWFVfmHmKU4GBWEuEVeQsU4k1JrKxKLcqPLyrNSS0+ xGgKDO+JzFKiyfnApJtXEm9oYmlgYmYETF2WhoZK4ryi669FCAmkJ5akZqemFqQWwfQxcXBK NTAuM/0y5xCvxIoZ4iv88kq28ARmNxm+e3rgzg4F5vqvNiZzX+6cfLU70unDt+efuaq87FpX z5l9QEySr05Xb+pjIe3EzGkcdzY/cfcub5rzRFhkUc+LmBBTvzkWF5N6Qhc5La5YcLy7ucAt UiLvqbqV85lfvqvLnVlLjq2+XqJvrbc/fVOcGrcSS3FGoqEWc1FxIgDTV71ZggMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsVy+t9jQd27MixRBk8vilpsnLGe1eJ853Jm i623pC3On9/AbnF51xw2i9uNK9gc2Dw2repk8+jbsorRo+lUO6vH501yASxRXDYpqTmZZalF +nYJXBl/tx5kLljHUbGksYulgfEpWxcjJ4eEgInEtOmnmboYuTiEBNYxSixYMIcdJMErICjx Y/I9li5GDg5mAXmJI5eyIUx1iSlTciHKHzBKTDr9gBmiXEviyPlHYK0sAqoSc26+BYuzAcX3 v7gBtotfQFHi6o/HjCBzRAUiJLpPVILMERF4xCixalIPI0gNyPxt+66wgtjCAgUSp7b/ZYZY No9RYs7l92ALOAU8Jebf288+gVFgFpJTZyGcOgvh1AWMzKsYJVMLinPTc4uNCgzzUsv1ihNz i0vz0vWS83M3MQJDetthrb4djPeXxB9iFOBgVOLhdVjLHCXEmlhWXJl7iFGCg1lJhFfkLVCI NyWxsiq1KD++qDQntfgQozQHi5I47+28Y5FCAumJJanZqakFqUUwWSYOTqkGRu9A1gseW8TM ZM6I/Pc3P3iHvfXykl8zvtUfO73/5jbpVKsy7UqzFNuT1tzFsqslTwkdMt2paxvTucWmik1U h3OPZmMnJ8vrTVY8DkosZsp7/9w8HCNv9spF/G7CjG+TI9P3MSq/s3kbqbSG96nRzjRn5rmi W/6pxS7gvNAZKbhNQe57lv8OJZbijERDLeai4kQA5IGti2UCAAA= X-CMS-MailID: 20171109091613epcas1p4203142a8ff48637ee2f5d29ef95fe977 X-Msg-Generator: CA CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171109090556epcas1p265558b4f87c887533655517a23e59e21 X-RootMTR: 20171109090556epcas1p265558b4f87c887533655517a23e59e21 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 11월 09일 18:05, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 9 Nov 2017 10:00:08 +0100 > > The variable "ret" will be set to an appropriate value a bit later. > Thus omit the explicit initialisation at the beginning. > > Signed-off-by: Markus Elfring > --- > drivers/extcon/extcon-max8997.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c > index 8152790d72e1..9f30f4929b72 100644 > --- a/drivers/extcon/extcon-max8997.c > +++ b/drivers/extcon/extcon-max8997.c > @@ -204,7 +204,7 @@ static int max8997_muic_set_debounce_time(struct max8997_muic_info *info, > static int max8997_muic_set_path(struct max8997_muic_info *info, > u8 val, bool attached) > { > - int ret = 0; > + int ret; > u8 ctrl1, ctrl2 = 0; > > if (attached) > Applied it. But, it will be merged to v4.16-rc1. -- Best Regards, Chanwoo Choi Samsung Electronics