From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Joe Perches <joe@perches.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input <linux-input@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Hanjun Guo <guohanjun@huawei.com>,
Libin <huawei.libin@huawei.com>,
"Kefeng Wang" <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH 1/1] Input: ims-pcu - fix typo in an error log
Date: Fri, 24 Nov 2017 15:49:58 +0800 [thread overview]
Message-ID: <5A17CF26.5030003@huawei.com> (raw)
In-Reply-To: <1511507823.8230.8.camel@perches.com>
On 2017/11/24 15:17, Joe Perches wrote:
> On Fri, 2017-11-24 at 14:59 +0800, Zhen Lei wrote:
>> Tiny typo fixed in an error log.
>>
>> I found this when I backported the CVE-2017-16645 patch:
>> ea04efee7635 ("Input: ims-psu - check if CDC union descriptor is sane")
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> drivers/input/misc/ims-pcu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c
> []
>> @@ -1651,7 +1651,7 @@ static void ims_pcu_buffers_free(struct ims_pcu *pcu)
>> return union_desc;
>>
>> dev_err(&intf->dev,
>> - "Union descriptor to short (%d vs %zd\n)",
>> + "Union descriptor too short (%d vs %zd\n)",
>
> And this format is incorrect too. It should be:
>
> + "Union descriptor too short (%d vs %zd)\n",
>
> with the close parenthesis before the newline, not after.
You are very observant. Do I need to post v2? It seems that we can simply modify it directly.
>
>
> .
>
--
Thanks!
BestRegards
prev parent reply other threads:[~2017-11-24 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 6:59 [PATCH 1/1] Input: ims-pcu - fix typo in an error log Zhen Lei
2017-11-24 7:17 ` Joe Perches
2017-11-24 7:49 ` Leizhen (ThunderTown) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A17CF26.5030003@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=dmitry.torokhov@gmail.com \
--cc=guohanjun@huawei.com \
--cc=huawei.libin@huawei.com \
--cc=joe@perches.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).