From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751976AbdK3I1x convert rfc822-to-8bit (ORCPT ); Thu, 30 Nov 2017 03:27:53 -0500 Received: from prv-mh.provo.novell.com ([137.65.248.74]:41959 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbdK3I1v (ORCPT ); Thu, 30 Nov 2017 03:27:51 -0500 Message-Id: <5A1FCF150200007800193632@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.2 Date: Thu, 30 Nov 2017 01:27:49 -0700 From: "Jan Beulich" To: "Govinda Tatti" Cc: , , , "Juergen Gross" , Subject: Re: [Xen-devel] [PATCH V2] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute References: <20171108230654.2981-1-Govinda.Tatti@Oracle.COM> <5A0424B7020000780018D6FA@prv-mh.provo.novell.com> <5A1EE54D020000780019335F@prv-mh.provo.novell.com> <2783ea8a-3ef3-c4dd-a592-52cf8e188ad4@oracle.com> In-Reply-To: <2783ea8a-3ef3-c4dd-a592-52cf8e188ad4@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 29.11.17 at 18:38, wrote: >>> In the case of bus or slot reset, our goal is to reset connected PCIe >>> fabric/card/endpoint. >>> The connected card/endpoint can be multi-function device. So, same >>> walk-through and checking >>> is needed irrespective of type of reset being used. >> I don't follow: The scope of other devices/functions possibly >> affected by a reset depends on the type of reset, doesn't it? > For PCIe platforms, both slot and bus reset endup resetting all connected > device/functions on thesecondary bus (behind the root-port or > downstream-port). According to my understanding this contradicts the comment ahead of pci_reset_slot(), which talks of multiple slots per bus. In such a setup, I can't see why resetting on slot would affect other slots on the same bus. At the same time the comment says that the slot reset may resolve to a bus one when there's just a single slot on the bus. Jan