From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753266AbeABAf6 (ORCPT + 1 other); Mon, 1 Jan 2018 19:35:58 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:36508 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752526AbeABAf4 (ORCPT ); Mon, 1 Jan 2018 19:35:56 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20180102003553epoutp022a929071258392a7fa488fd47a91c4ae~F1xli6yOf0886008860epoutp02w X-AuditID: b6c32a35-c69ff700000010dd-38-5a4ad3e8eb34 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <5A4AD3E8.8020608@samsung.com> Date: Tue, 02 Jan 2018 09:35:52 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham , Lee Jones Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] extcon: axp288: Remove unused platform data In-reply-to: <20171222123616.9562-2-hdegoede@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOKsWRmVeSWpSXmKPExsWy7bCmvu6Ly15RBk9X2Vi8OT6dyeL+16OM Fpd3zWGzuN24gs2BxePOtT1sHu/3XWXz6NuyitHj8ya5AJaoVJuM1MSU1CKF1Lzk/JTMvHRb Je/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoJVKCmWJOaVAoYDE4mIlfTubovzSklSF jPziElulaENDIz1DA3M9IyMjPRPjWCsjU6CShNSMfxs+shUcV6xouPeapYGxX7qLkZNDQsBE 4sSaV4xdjFwcQgI7GCV2rm1khnC+M0o8OPiMCabqSM9DNojEBkaJE1N+s4EkeAUEJX5MvsfS xcjBwSwgL3HkUjZImFlAU2Lr7vXsEPX3GCVOX18IVa8lcX/JPUYQm0VAVWLxpn5mEJsNKL7/ xQ2wGn4BRYmrPx6D1YgKREjsnP+NHcQWESiRmHt8NzvEAgWJX/c2sYLYwgIuEhfbLjCC3MAp YCHxb6MUyF4JgS1sEl3ztzBDPOAisXbiCihbWOLV8S3sIPUSAtISl47aQtS3M0q0753HDOFM YZQ4d/0e1PfGEs8WdjFBLOaTePe1hxWimVeio00IosRD4tb94ywQtqPEtxtd0MDaySjRffEi +wRGuVlI4TULEV6zkMJrASPzKkax1ILi3PTUYsMCQ73ixNzi0rx0veT83E2M4ESmZbqDcco5 n0OMAhyMSjy8G+K9ooRYE8uKK3MPMUpwMCuJ8NYqekYJ8aYkVlalFuXHF5XmpBYfYjQFBvdE ZinR5Hxgks0riTc0sTQwMTMCJi9LQ0Mlcd6AAJcoIYH0xJLU7NTUgtQimD4mDk6pBsYdxneP hTLdnO15nTdVt3rRqzc9K54K6zhpfN4SN6HxiuJTzqeX/3JU5UxYM+Fo+B5BuTNnohRv6T76 x3zdY4VJZ25n79kvISbqq1Uyn7D47t1fkLdbe0lv1tZM/4I5FxaZHT5p+8P+049l4v/ZTOR5 NNWFj7IypPFedOiMOZC43zfdYu6rWzZKLMUZiYZazEXFiQCBmcU0egMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t9jQd0Xl72iDA5tkbN4c3w6k8X9r0cZ LS7vmsNmcbtxBZsDi8eda3vYPN7vu8rm0bdlFaPH501yASxRXDYpqTmZZalF+nYJXBn/Nnxk KziuWNFw7zVLA2O/dBcjJ4eEgInEkZ6HbF2MXBxCAusYJeYfmcwMkuAVEJT4MfkeSxcjBwez gLzEkUvZIGFmAXWJSfMWMUPUP2CUuHp1OhNEvZbE/SX3GEFsFgFVicWb+sHmsAHF97+4wQZi 8wsoSlz98ZgRZKaoQIRE94lKkLCIQInEl6ZTLBDzFSR+3dvECmILC7hIXGy7wAixayejxLM5 X8Du4RSwkPi3UWoCo8AsJJfOQrh0FpJLFzAyr2KUTC0ozk3PLTYqMMxLLdcrTswtLs1L10vO z93ECAzgbYe1+nYw3l8Sf4hRgINRiYd3Q7xXlBBrYllxZe4hRgkOZiUR3lpFzygh3pTEyqrU ovz4otKc1OJDjNIcLErivLfzjkUKCaQnlqRmp6YWpBbBZJk4OKUaGIPjnIsOvfGSm+k3S4az omm+YjPb1q/n5UPb71//MXHTgf0fDGd4PbDzDjvk0X33+Ewvv6CCH3+4G3zvfOd4Z8dWyPUy c5qUXbhbUsOrtxklmsvn2nzrnm/4SJJ5ZvHfAxeb4rcznDKNEXNZuq057v7vP6zbjX78Dfz/ awnTUSeuWarzQxTCNyuxFGckGmoxFxUnAgBIr+ZzXAIAAA== X-CMS-MailID: 20180102003552epcas1p2be0ec4d31b35cd2da700415145cdee42 X-Msg-Generator: CA CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171222123630epcas4p3b4a4a3bcb646eda61302b759ca00d656 X-RootMTR: 20171222123630epcas4p3b4a4a3bcb646eda61302b759ca00d656 References: <20171222123616.9562-1-hdegoede@redhat.com> <20171222123616.9562-2-hdegoede@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: + MFD Maintainer (Lee Jones ) Hi Hans, You better to use the scripts/get_maintainer.pl for the mailing list. I added the MFD maintainer. This patch looks good to me. Reviewed-by: Chanwoo Choi Best Regards, Chanwoo Choi On 2017년 12월 22일 21:36, Hans de Goede wrote: > This is not used / set anywhere in the tree. > > Signed-off-by: Hans de Goede > --- > drivers/extcon/extcon-axp288.c | 35 +---------------------------------- > include/linux/mfd/axp20x.h | 5 ----- > 2 files changed, 1 insertion(+), 39 deletions(-) > > diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c > index ba185e9ebb82..386afb7d1160 100644 > --- a/drivers/extcon/extcon-axp288.c > +++ b/drivers/extcon/extcon-axp288.c > @@ -24,8 +24,6 @@ > #include > #include > #include > -#include > -#include > #include > > /* Power source status register */ > @@ -79,11 +77,6 @@ enum axp288_extcon_reg { > AXP288_BC_DET_STAT_REG = 0x2f, > }; > > -enum axp288_mux_select { > - EXTCON_GPIO_MUX_SEL_PMIC = 0, > - EXTCON_GPIO_MUX_SEL_SOC, > -}; > - > enum axp288_extcon_irq { > VBUS_FALLING_IRQ = 0, > VBUS_RISING_IRQ, > @@ -104,7 +97,6 @@ struct axp288_extcon_info { > struct device *dev; > struct regmap *regmap; > struct regmap_irq_chip_data *regmap_irqc; > - struct gpio_desc *gpio_mux_cntl; > int irq[EXTCON_IRQ_END]; > struct extcon_dev *edev; > unsigned int previous_cable; > @@ -196,15 +188,6 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info) > } > > no_vbus: > - /* > - * If VBUS is absent Connect D+/D- lines to PMIC for BC > - * detection. Else connect them to SOC for USB communication. > - */ > - if (info->gpio_mux_cntl) > - gpiod_set_value(info->gpio_mux_cntl, > - vbus_attach ? EXTCON_GPIO_MUX_SEL_SOC > - : EXTCON_GPIO_MUX_SEL_PMIC); > - > extcon_set_state_sync(info->edev, info->previous_cable, false); > if (info->previous_cable == EXTCON_CHG_USB_SDP) > extcon_set_state_sync(info->edev, EXTCON_USB, false); > @@ -252,8 +235,7 @@ static int axp288_extcon_probe(struct platform_device *pdev) > { > struct axp288_extcon_info *info; > struct axp20x_dev *axp20x = dev_get_drvdata(pdev->dev.parent); > - struct axp288_extcon_pdata *pdata = pdev->dev.platform_data; > - int ret, i, pirq, gpio; > + int ret, i, pirq; > > info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); > if (!info) > @@ -263,8 +245,6 @@ static int axp288_extcon_probe(struct platform_device *pdev) > info->regmap = axp20x->regmap; > info->regmap_irqc = axp20x->regmap_irqc; > info->previous_cable = EXTCON_NONE; > - if (pdata) > - info->gpio_mux_cntl = pdata->gpio_mux_cntl; > > platform_set_drvdata(pdev, info); > > @@ -285,19 +265,6 @@ static int axp288_extcon_probe(struct platform_device *pdev) > return ret; > } > > - /* Set up gpio control for USB Mux */ > - if (info->gpio_mux_cntl) { > - gpio = desc_to_gpio(info->gpio_mux_cntl); > - ret = devm_gpio_request(&pdev->dev, gpio, "USB_MUX"); > - if (ret < 0) { > - dev_err(&pdev->dev, > - "failed to request the gpio=%d\n", gpio); > - return ret; > - } > - gpiod_direction_output(info->gpio_mux_cntl, > - EXTCON_GPIO_MUX_SEL_PMIC); > - } > - > for (i = 0; i < EXTCON_IRQ_END; i++) { > pirq = platform_get_irq(pdev, i); > info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq); > diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h > index 78dc85365c4f..080798f17ece 100644 > --- a/include/linux/mfd/axp20x.h > +++ b/include/linux/mfd/axp20x.h > @@ -645,11 +645,6 @@ struct axp20x_dev { > const struct regmap_irq_chip *regmap_irq_chip; > }; > > -struct axp288_extcon_pdata { > - /* GPIO pin control to switch D+/D- lines b/w PMIC and SOC */ > - struct gpio_desc *gpio_mux_cntl; > -}; > - > /* generic helper function for reading 9-16 bit wide regs */ > static inline int axp20x_read_variable_width(struct regmap *regmap, > unsigned int reg, unsigned int width) >