From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753435AbeABAz1 (ORCPT + 1 other); Mon, 1 Jan 2018 19:55:27 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:18115 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751945AbeABAzZ (ORCPT ); Mon, 1 Jan 2018 19:55:25 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20180102005523epoutp042662612facc1dcf40677db2ac9b48b53~F2CnNjRsL0796307963epoutp04E X-AuditID: b6c32a46-9adff700000010ee-31-5a4ad87b0291 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Message-id: <5A4AD87A.1020702@samsung.com> Date: Tue, 02 Jan 2018 09:55:22 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] extcon: axp288: Handle reserved charger-type values better In-reply-to: <20171222123616.9562-4-hdegoede@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDKsWRmVeSWpSXmKPExsWy7bCmqW71Da8og/eHZCzeHJ/OZHF51xw2 i9uNK9gcmD3e77vK5tG3ZRWjx+dNcgHMUak2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6 hpYW5koKeYm5qbZKLj4Bum6ZOUCLlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2StGGhkZ6 hgbmekZGRnomxrFWRqZAJQmpGZ8m/mYvaOeseHl6E3MD43r2LkZODgkBE4l9xy8B2VwcQgI7 GCW+dU9mhXC+M0ocOrgIyOEAq1rSZAbSICSwgVFiQ4cQiM0rICjxY/I9FpASZgF5iSOXskHC zAKaElt3r4eaeY9RYvn2RiaQGl4BLYkjq5lAalgEVCVOXj3HCGKzAYX3v7jBBmLzCyhKXP3x GCwuKhAhsXP+N7A7RQSCJG58X8EKMV9B4te9TWC2sECoxM2VEDangIXExwfnGUH2SggsYZN4 8mIfI8STLhJ/+l+yQNjCEq+Ob4F6Xlri2aqNUA3tjBLte+cxQzhTGCXOXb/HBFFlLPFsYRcT xGo+iY7Df9khgcIr0dEmBFHiIbFwxgKoBY4Sm5+tYIL4fiejxLITv9gnMMrNQgqwWYgAm4UU YAsYmVcxiqUWFOempxYbFRjpFSfmFpfmpesl5+duYgSnLC23HYxLzvkcYhTgYFTi4Y2I9YoS Yk0sK67MPcQowcGsJMJbq+gZJcSbklhZlVqUH19UmpNafIjRFBjgE5mlRJPzgek0ryTe0MTS wMTMzMjczAKYvsR5WwNcooQE0hNLUrNTUwtSi2D6mDg4pRoYbQVerjvKa/PQ+WxV1/QDNTtO NsmkPhea9jzz2TrXtmU/P9l0u/x3LUiJFZ/22u7MvR8OzDNm+t+b4ngvavqkH5snPzu/89Z5 dYVTi474LmPbHBsRbbrxs5bNvCS+Q/p1Jw5Ev5xh/P3WOuaTTzOvKLHKnH6kb1q9ferr3949 Ky20Om1Z3h7dukyJpTgj0VCLuag4EQAnJ8PebwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRmVeSWpSXmKPExsVy+t9jQd2qG15RBnumW1q8OT6dyeLyrjls FrcbV7A5MHu833eVzaNvyypGj8+b5AKYo7hsUlJzMstSi/TtErgyPk38zV7Qzlnx8vQm5gbG 9exdjBwcEgImEkuazLoYuTiEBNYxSrR9WQAU5+TgFRCU+DH5HgtIDbOAvMSRS9kgYWYBdYlJ 8xYxQ9Q/YJTo2NLDBlLDK6AlcWQ1E0gNi4CqxMmr5xhBbDag8P4XN9hAbH4BRYmrPx4zgpSL CkRIdJ+oBAmLCARI/DzVzw4xXkHi171NrCC2sECoxM2VIDbIqp2MEu8f7QIr4hSwkPj44Dzj BEaBWUgunYVw6Swkly5gZF7FKJlaUJybnltsVGCUl1quV5yYW1yal66XnJ+7iREYqtsOa/Xv YHy8JP4QowAHoxIP74Z4rygh1sSy4srcQ4wSHMxKIry1ip5RQrwpiZVVqUX58UWlOanFhxil OViUxHn5849FCgmkJ5akZqemFqQWwWSZODilGhgXK3O8zLkVdq/EWO3UUY2LH7+y3cic25ou pqud7vjuudC3SS0toUHz3pzqdbo38fzrSafT91w+kvargOVBomcS8xlb18qgYp0W8d+r6zPO rpb/XbCPS9mwqUJug3TbvXmOlgas1o+4JOZVP1OQn+n4LlNXVyN4gYrO7frl5SpnoqNk87x7 XimxFGckGmoxFxUnAgA954qqUQIAAA== X-CMS-MailID: 20180102005522epcas2p292a81ad5b5c4cdf1367c2a977ae73dd7 X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171222123651epcas3p3e6cf82ac1143c2951f8a57b842182bc9 X-RootMTR: 20171222123651epcas3p3e6cf82ac1143c2951f8a57b842182bc9 References: <20171222123616.9562-1-hdegoede@redhat.com> <20171222123616.9562-4-hdegoede@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Hans, On 2017년 12월 22일 21:36, Hans de Goede wrote: > According to the data sheets all the values not handled in the > switch-case are "reserved". Update the dev_warn message to reflect > this and set the cable-type to EXTCON_CHG_USB_SDP (so max 500mA > current draw) as safe default. > > Signed-off-by: Hans de Goede > --- > drivers/extcon/extcon-axp288.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c > index cc7c35c7ff02..d60c615f709f 100644 > --- a/drivers/extcon/extcon-axp288.c > +++ b/drivers/extcon/extcon-axp288.c > @@ -205,8 +205,8 @@ static int axp288_handle_chrg_det_event(struct axp288_extcon_info *info) > cable = EXTCON_CHG_USB_DCP; > break; > default: > - dev_warn(info->dev, > - "disconnect or unknown or ID event\n"); > + dev_warn(info->dev, "unknown (reserved) bc detect result\n"); > + cable = EXTCON_CHG_USB_SDP; > } > > no_vbus: > Looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics