From: jiangyiwen <jiangyiwen@huawei.com>
To: <v9fs-developer@lists.sourceforge.net>, <viro@zeniv.linux.org.uk>
Cc: <ericvh@gmail.com>, <rminnich@sandia.gov>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Latchesar Ionkov" <lucho@ionkov.net>, Greg Kurz <groug@kaod.org>
Subject: Re: [V9fs-developer] [PATCH] fs/9p: don't set SB_NOATIME by default
Date: Sat, 24 Feb 2018 10:47:27 +0800 [thread overview]
Message-ID: <5A90D23F.5070601@huawei.com> (raw)
In-Reply-To: <5A7D3C08.7020309@huawei.com>
On 2018/2/9 14:13, jiangyiwen wrote:
> User use some syscall, for example mmap(v9fs_file_mmap), it will not
> update atime even if user's mnt_flags have MNT_NOATIME, because
> v9fs default set SB_NOATIME in v9fs_set_super.
>
> For supporting access time is updated when user mount with relatime,
> we should clear SB_NOATIME by default.
>
> Signed-off-by: Yiwen Jiang <jiangyiwen@huawei.com>
> ---
> fs/9p/vfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/9p/vfs_super.c b/fs/9p/vfs_super.c
> index af03c2a..48ce504 100644
> --- a/fs/9p/vfs_super.c
> +++ b/fs/9p/vfs_super.c
> @@ -94,7 +94,7 @@ static int v9fs_set_super(struct super_block *s, void *data)
> if (v9ses->cache)
> sb->s_bdi->ra_pages = (VM_MAX_READAHEAD * 1024)/PAGE_SIZE;
>
> - sb->s_flags |= SB_ACTIVE | SB_DIRSYNC | SB_NOATIME;
> + sb->s_flags |= SB_ACTIVE | SB_DIRSYNC;
> if (!v9ses->cache)
> sb->s_flags |= SB_SYNCHRONOUS;
>
Hi Alexander Viro and Eric,
My patch has already sent two weeks, but nobody help me
to review, I have a question about now who is the v9fs's
maintainer? Or who can help me review the patch?
I hope v9fs's maintainer can give me some advices or
merge into the mainline if it has no problem.
Thanks,
Yiwen.
next prev parent reply other threads:[~2018-02-24 2:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 6:13 [V9fs-developer] [PATCH] fs/9p: don't set SB_NOATIME by default jiangyiwen
2018-02-24 2:47 ` jiangyiwen [this message]
2018-02-26 1:34 ` jiangyiwen
2018-02-26 5:28 ` Bo YU
2018-03-27 1:50 jiangyiwen
2018-03-27 23:15 ` Andrew Morton
2018-03-28 1:14 ` jiangyiwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A90D23F.5070601@huawei.com \
--to=jiangyiwen@huawei.com \
--cc=ericvh@gmail.com \
--cc=groug@kaod.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).