linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Yan <yanaijie@huawei.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	<wen.yang99@zte.com.cn>
Cc: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>,
	<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<Bart.VanAssche@wdc.com>, <pmladek@suse.com>, <tj@kernel.org>,
	<jiang.biao2@zte.com.cn>, <zhong.weidong@zte.com.cn>,
	<tan.hu@zte.com.cn>
Subject: Re: 答复: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttlefrequent printk
Date: Mon, 2 Apr 2018 14:07:59 +0800	[thread overview]
Message-ID: <5AC1C8BF.1030503@huawei.com> (raw)
In-Reply-To: <20180402052920.GF3795@jagdpanzerIV>



On 2018/4/2 13:29, Sergey Senozhatsky wrote:
> On (04/02/18 13:14), wen.yang99@zte.com.cn wrote:
>>
>>     > It's true that this print for the same device is useless. But it's
>>     > useful for different devices. Is it possible to limit the print only
>>     > for the same device?
>>
>>     In our scene, it's  just for the same device (q->queuedata), Thanks.
>
> Yes, what Jason meant was that rate limit struct is shared by different call
> sites - including scsi_request_fn() from different devices.
>
> If device1->scsi_request_fn()->sdev_printk_ratelimited() causes printk rate
> limit, then messages from device2->scsi_request_fn()->sdev_printk_ratelimited()
> may be lost entirely, unless you have enough of them.
>
> 	-ss
>

Yes, that's exactly what I mean.

Thanks,

Jason

> .
>

  reply	other threads:[~2018-04-02  6:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-02  1:58 [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttle frequent printk Wen Yang
2018-04-02  2:10 ` Sergey Senozhatsky
     [not found]   ` <201804031419435288297@zte.com.cn>
2018-04-06  8:30     ` 答复: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttlefrequent printk Petr Mladek
2018-04-06  8:49       ` Petr Mladek
     [not found]         ` <201804091013439214247@zte.com.cn>
2018-04-09  8:59           ` 答复: Re: 答复: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited tothrottlefrequent printk Petr Mladek
2018-04-02  2:37 ` [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttle frequent printk Jason Yan
     [not found]   ` <201804021314481872986@zte.com.cn>
2018-04-02  5:29     ` 答复: Re: [PATCH v2] scsi: Introduce sdev_printk_ratelimited to throttlefrequent printk Sergey Senozhatsky
2018-04-02  6:07       ` Jason Yan [this message]
2018-04-02  6:06     ` Jason Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5AC1C8BF.1030503@huawei.com \
    --to=yanaijie@huawei.com \
    --cc=Bart.VanAssche@wdc.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=jiang.biao2@zte.com.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=pmladek@suse.com \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=tan.hu@zte.com.cn \
    --cc=tj@kernel.org \
    --cc=wen.yang99@zte.com.cn \
    --cc=zhong.weidong@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).