linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: zhong jiang <zhongjiang@huawei.com>
To: <axboe@kernel.dk>
Cc: <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: Use NULL to compare with pointer-typed value rather than 0
Date: Sat, 18 Aug 2018 14:17:15 +0800	[thread overview]
Message-ID: <5B77B9EB.9000700@huawei.com> (raw)
In-Reply-To: <1534512473-39710-1-git-send-email-zhongjiang@huawei.com>

On 2018/8/17 21:27, zhong jiang wrote:
> We should use NULL to compare with pointer-typed value rather than
> 0. The issue is detected with the help of Coccinelle.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  drivers/block/ataflop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c
> index dfb2c26..cca93e3 100644
> --- a/drivers/block/ataflop.c
> +++ b/drivers/block/ataflop.c
> @@ -1355,7 +1355,7 @@ static int floppy_revalidate(struct gendisk *disk)
>  
>  	if (test_bit(drive, &changed_floppies) ||
>  	    test_bit(drive, &fake_change) ||
> -	    p->disktype == 0) {
> +	    p->disktype == NULL) {
>  		if (UD.flags & FTD_MSG)
>  			printk(KERN_ERR "floppy: clear format %p!\n", UDT);
>  		BufferDrive = -1;
 Maybe if  (!p->disktype) is better,  So will change it in v2.

Thanks,
zhong jiang


      reply	other threads:[~2018-08-18  6:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17 13:27 [PATCH] block: Use NULL to compare with pointer-typed value rather than 0 zhong jiang
2018-08-18  6:17 ` zhong jiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B77B9EB.9000700@huawei.com \
    --to=zhongjiang@huawei.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).