linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] wireless: Use dma_zalloc_coherent instead of dma_alloc_coherent + memset
@ 2018-08-18 15:05 zhong jiang
  2018-08-18 18:29 ` Kalle Valo
  0 siblings, 1 reply; 4+ messages in thread
From: zhong jiang @ 2018-08-18 15:05 UTC (permalink / raw)
  To: kvalo, davem; +Cc: linux-kernel, netdev

dma_zalloc_coherent has implemented the dma_alloc_coherent() + memset (),
We prefer to dma_zalloc_coherent instead of open-codeing.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 drivers/net/wireless/ath/wcn36xx/dxe.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/dxe.c b/drivers/net/wireless/ath/wcn36xx/dxe.c
index 06cfe8d..e66ddaa 100644
--- a/drivers/net/wireless/ath/wcn36xx/dxe.c
+++ b/drivers/net/wireless/ath/wcn36xx/dxe.c
@@ -174,13 +174,11 @@ static int wcn36xx_dxe_init_descs(struct device *dev, struct wcn36xx_dxe_ch *wcn
 	int i;
 
 	size = wcn_ch->desc_num * sizeof(struct wcn36xx_dxe_desc);
-	wcn_ch->cpu_addr = dma_alloc_coherent(dev, size, &wcn_ch->dma_addr,
-					      GFP_KERNEL);
+	wcn_ch->cpu_addr = dma_zalloc_coherent(dev, size, &wcn_ch->dma_addr,
+					       GFP_KERNEL);
 	if (!wcn_ch->cpu_addr)
 		return -ENOMEM;
 
-	memset(wcn_ch->cpu_addr, 0, size);
-
 	cur_dxe = (struct wcn36xx_dxe_desc *)wcn_ch->cpu_addr;
 	cur_ctl = wcn_ch->head_blk_ctl;
 
-- 
1.7.12.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] wireless: Use dma_zalloc_coherent instead of dma_alloc_coherent + memset
  2018-08-18 15:05 [PATCH] wireless: Use dma_zalloc_coherent instead of dma_alloc_coherent + memset zhong jiang
@ 2018-08-18 18:29 ` Kalle Valo
  2018-08-18 18:31   ` Kalle Valo
  0 siblings, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2018-08-18 18:29 UTC (permalink / raw)
  To: zhong jiang; +Cc: davem, linux-kernel, netdev

zhong jiang <zhongjiang@huawei.com> writes:

> dma_zalloc_coherent has implemented the dma_alloc_coherent() + memset (),
> We prefer to dma_zalloc_coherent instead of open-codeing.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  drivers/net/wireless/ath/wcn36xx/dxe.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

The correct prefix is "wcn36xx: ", not "wireless:". I can fix it this
time.

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] wireless: Use dma_zalloc_coherent instead of dma_alloc_coherent + memset
  2018-08-18 18:29 ` Kalle Valo
@ 2018-08-18 18:31   ` Kalle Valo
  2018-08-20 10:53     ` zhong jiang
  0 siblings, 1 reply; 4+ messages in thread
From: Kalle Valo @ 2018-08-18 18:31 UTC (permalink / raw)
  To: zhong jiang; +Cc: davem, linux-kernel, netdev

Kalle Valo <kvalo@codeaurora.org> writes:

> zhong jiang <zhongjiang@huawei.com> writes:
>
>> dma_zalloc_coherent has implemented the dma_alloc_coherent() + memset (),
>> We prefer to dma_zalloc_coherent instead of open-codeing.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>>  drivers/net/wireless/ath/wcn36xx/dxe.c | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> The correct prefix is "wcn36xx: ", not "wireless:". I can fix it this
> time.
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong

Actually please resend this patch and CC linux-wireless so that
patchwork sees this.

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#who_to_address

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] wireless: Use dma_zalloc_coherent instead of dma_alloc_coherent + memset
  2018-08-18 18:31   ` Kalle Valo
@ 2018-08-20 10:53     ` zhong jiang
  0 siblings, 0 replies; 4+ messages in thread
From: zhong jiang @ 2018-08-20 10:53 UTC (permalink / raw)
  To: Kalle Valo; +Cc: davem, linux-kernel, netdev

On 2018/8/19 2:31, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
>
>> zhong jiang <zhongjiang@huawei.com> writes:
>>
>>> dma_zalloc_coherent has implemented the dma_alloc_coherent() + memset (),
>>> We prefer to dma_zalloc_coherent instead of open-codeing.
>>>
>>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>>> ---
>>>  drivers/net/wireless/ath/wcn36xx/dxe.c | 6 ++----
>>>  1 file changed, 2 insertions(+), 4 deletions(-)
>> The correct prefix is "wcn36xx: ", not "wireless:". I can fix it this
>> time.
>>
>> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
> Actually please resend this patch and CC linux-wireless so that
> patchwork sees this.
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#who_to_address
>
 Thanks. I will resend it in v2.

Best wishes,
zhong jiang


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-08-20 10:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-18 15:05 [PATCH] wireless: Use dma_zalloc_coherent instead of dma_alloc_coherent + memset zhong jiang
2018-08-18 18:29 ` Kalle Valo
2018-08-18 18:31   ` Kalle Valo
2018-08-20 10:53     ` zhong jiang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).