* [char-misc 1/2] mei: Fix debugfs filename in error output
@ 2015-08-24 12:27 Tomas Winkler
2015-08-24 12:27 ` [char-misc 2/2] mei: fix debugfs files leak on error path Tomas Winkler
2015-09-21 2:25 ` [char-misc 1/2] mei: Fix debugfs filename in error output Greg Kroah-Hartman
0 siblings, 2 replies; 6+ messages in thread
From: Tomas Winkler @ 2015-08-24 12:27 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: arnd, Alexander Usyskin, linux-kernel,
Signed-off-by: Alexander Kuleshov, Tomas Winkler
From: "Signed-off-by: Alexander Kuleshov" <kuleshovmail@gmail.com>
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/misc/mei/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c
index 4b469cf9e60f..c157f0ba575c 100644
--- a/drivers/misc/mei/debugfs.c
+++ b/drivers/misc/mei/debugfs.c
@@ -213,7 +213,7 @@ int mei_dbgfs_register(struct mei_device *dev, const char *name)
f = debugfs_create_file("active", S_IRUSR, dir,
dev, &mei_dbgfs_fops_active);
if (!f) {
- dev_err(dev->dev, "meclients: registration failed\n");
+ dev_err(dev->dev, "active: registration failed\n");
goto err;
}
f = debugfs_create_file("devstate", S_IRUSR, dir,
--
2.4.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [char-misc 2/2] mei: fix debugfs files leak on error path
2015-08-24 12:27 [char-misc 1/2] mei: Fix debugfs filename in error output Tomas Winkler
@ 2015-08-24 12:27 ` Tomas Winkler
2015-09-21 2:25 ` [char-misc 1/2] mei: Fix debugfs filename in error output Greg Kroah-Hartman
1 sibling, 0 replies; 6+ messages in thread
From: Tomas Winkler @ 2015-08-24 12:27 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: arnd, Alexander Usyskin, linux-kernel, Tomas Winkler
if dbgfs_dir is not set then debugfs_remove_recursive
is not called on the error path
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/misc/mei/debugfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c
index c157f0ba575c..a138d8a27ab5 100644
--- a/drivers/misc/mei/debugfs.c
+++ b/drivers/misc/mei/debugfs.c
@@ -204,6 +204,8 @@ int mei_dbgfs_register(struct mei_device *dev, const char *name)
if (!dir)
return -ENOMEM;
+ dev->dbgfs_dir = dir;
+
f = debugfs_create_file("meclients", S_IRUSR, dir,
dev, &mei_dbgfs_fops_meclients);
if (!f) {
@@ -228,7 +230,6 @@ int mei_dbgfs_register(struct mei_device *dev, const char *name)
dev_err(dev->dev, "allow_fixed_address: registration failed\n");
goto err;
}
- dev->dbgfs_dir = dir;
return 0;
err:
mei_dbgfs_deregister(dev);
--
2.4.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [char-misc 1/2] mei: Fix debugfs filename in error output
2015-08-24 12:27 [char-misc 1/2] mei: Fix debugfs filename in error output Tomas Winkler
2015-08-24 12:27 ` [char-misc 2/2] mei: fix debugfs files leak on error path Tomas Winkler
@ 2015-09-21 2:25 ` Greg Kroah-Hartman
2015-09-21 7:07 ` Alexander Kuleshov
1 sibling, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2015-09-21 2:25 UTC (permalink / raw)
To: Tomas Winkler
Cc: arnd, Alexander Usyskin, linux-kernel, Signed-off-by: Alexander Kuleshov
On Mon, Aug 24, 2015 at 03:27:36PM +0300, Tomas Winkler wrote:
> From: "Signed-off-by: Alexander Kuleshov" <kuleshovmail@gmail.com>
I kind of doubt that's the real author name :(
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [char-misc 1/2] mei: Fix debugfs filename in error output
2015-09-21 2:25 ` [char-misc 1/2] mei: Fix debugfs filename in error output Greg Kroah-Hartman
@ 2015-09-21 7:07 ` Alexander Kuleshov
2015-09-21 7:36 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Kuleshov @ 2015-09-21 7:07 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Tomas Winkler, Arnd Bergmann, Alexander Usyskin, LKML
Hello Greg,
On Mon, Sep 21, 2015 at 8:25 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Mon, Aug 24, 2015 at 03:27:36PM +0300, Tomas Winkler wrote:
>> From: "Signed-off-by: Alexander Kuleshov" <kuleshovmail@gmail.com>
>
> I kind of doubt that's the real author name :(
>
Why? I've definitely sent this patch sometime ago
(https://lkml.org/lkml/2015/8/14/560)
Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [char-misc 1/2] mei: Fix debugfs filename in error output
2015-09-21 7:07 ` Alexander Kuleshov
@ 2015-09-21 7:36 ` Greg Kroah-Hartman
2015-09-21 7:53 ` Winkler, Tomas
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2015-09-21 7:36 UTC (permalink / raw)
To: Alexander Kuleshov; +Cc: Tomas Winkler, Arnd Bergmann, Alexander Usyskin, LKML
On Mon, Sep 21, 2015 at 01:07:21PM +0600, Alexander Kuleshov wrote:
> Hello Greg,
>
> On Mon, Sep 21, 2015 at 8:25 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Mon, Aug 24, 2015 at 03:27:36PM +0300, Tomas Winkler wrote:
> >> From: "Signed-off-by: Alexander Kuleshov" <kuleshovmail@gmail.com>
> >
> > I kind of doubt that's the real author name :(
> >
>
> Why? I've definitely sent this patch sometime ago
> (https://lkml.org/lkml/2015/8/14/560)
Look at the line carefully...
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [char-misc 1/2] mei: Fix debugfs filename in error output
2015-09-21 7:36 ` Greg Kroah-Hartman
@ 2015-09-21 7:53 ` Winkler, Tomas
0 siblings, 0 replies; 6+ messages in thread
From: Winkler, Tomas @ 2015-09-21 7:53 UTC (permalink / raw)
To: Greg Kroah-Hartman, Alexander Kuleshov
Cc: Arnd Bergmann, Usyskin, Alexander, LKML
> -----Original Message-----
> From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org]
> Sent: Monday, September 21, 2015 10:37
> To: Alexander Kuleshov
> Cc: Winkler, Tomas; Arnd Bergmann; Usyskin, Alexander; LKML
> Subject: Re: [char-misc 1/2] mei: Fix debugfs filename in error output
>
> On Mon, Sep 21, 2015 at 01:07:21PM +0600, Alexander Kuleshov wrote:
> > Hello Greg,
> >
> > On Mon, Sep 21, 2015 at 8:25 AM, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > > On Mon, Aug 24, 2015 at 03:27:36PM +0300, Tomas Winkler wrote:
> > >> From: "Signed-off-by: Alexander Kuleshov" <kuleshovmail@gmail.com>
> > >
> > > I kind of doubt that's the real author name :(
> > >
> >
> > Why? I've definitely sent this patch sometime ago
> > (https://lkml.org/lkml/2015/8/14/560)
>
> Look at the line carefully.
I will resend w/o signed off
Tomas
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-21 7:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-24 12:27 [char-misc 1/2] mei: Fix debugfs filename in error output Tomas Winkler
2015-08-24 12:27 ` [char-misc 2/2] mei: fix debugfs files leak on error path Tomas Winkler
2015-09-21 2:25 ` [char-misc 1/2] mei: Fix debugfs filename in error output Greg Kroah-Hartman
2015-09-21 7:07 ` Alexander Kuleshov
2015-09-21 7:36 ` Greg Kroah-Hartman
2015-09-21 7:53 ` Winkler, Tomas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).