From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753533AbcGTJC6 (ORCPT ); Wed, 20 Jul 2016 05:02:58 -0400 Received: from mga03.intel.com ([134.134.136.65]:52132 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753374AbcGTJCz (ORCPT ); Wed, 20 Jul 2016 05:02:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,393,1464678000"; d="scan'208";a="998883033" From: "Winkler, Tomas" To: "Gortmaker, Paul (Wind River)" CC: Greg Kroah-Hartman , Ulf Hansson , "Hunter, Adrian" , "James Bottomley" , "Martin K. Petersen" , Vinayak Holikatti , Andy Lutomirski , Arve Hj?nnev?g , "Michael Ryleev" , Joao Pinto , "Christoph Hellwig" , Yaniv Gardi , LKML , "linux-mmc@vger.kernel.org" , "linux-scsi@vger.kernel.org" Subject: RE: [PATCH v5 4/8] char: rpmb: provide a user space interface Thread-Topic: [PATCH v5 4/8] char: rpmb: provide a user space interface Thread-Index: AQHR4TMi0pr1oZ+9I0ibbXYR5sxa76Aejw8AgAJ4YEA= Date: Wed, 20 Jul 2016 09:02:49 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B54297958@hasmsx108.ger.corp.intel.com> References: <1468873673-21776-1-git-send-email-tomas.winkler@intel.com> <1468873673-21776-5-git-send-email-tomas.winkler@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTkwNDY2ZjgtYTllMS00YWFjLWI1NDUtZjYwNmJhYTc3MzM3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImVaRmF3aStmYnhPdFY5M1ZMcjZidVdcL3NkVTR2a0NqR3V4ZVJMVGxRS1BZPSJ9 x-originating-ip: [10.184.70.10] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u6K934q4022304 > > On Mon, Jul 18, 2016 at 4:27 PM, Tomas Winkler > wrote: > > The user space API is achieved via two synchronous IOCTL. > > Simplified one, RPMB_IOC_REQ_CMD, were read result cycles is > performed > > by the framework on behalf the user and second, RPMB_IOC_SEQ_CMD > where > > the whole RPMB sequence including RESULT_READ is supplied by the caller. > > The latter is intended for easier adjusting of the applications > > that use MMC_IOC_MULTI_CMD ioctl. > > > > Signed-off-by: Tomas Winkler > > --- > > [...] > > > diff --git a/drivers/char/rpmb/Kconfig b/drivers/char/rpmb/Kconfig > > index c5e6e909efce..6794be9fcc5e 100644 > > --- a/drivers/char/rpmb/Kconfig > > +++ b/drivers/char/rpmb/Kconfig > > @@ -6,3 +6,10 @@ config RPMB > > access RPMB partition. > > > > If unsure, select N. > > + > > +config RPMB_INTF_DEV > > + bool "RPMB character device interface /dev/rpmbN" > > A bool Kconfig should ideally.... > > > + depends on RPMB > > + help > > + Say yes here if you want to access RPMB from user space > > + via character device interface /dev/rpmb%d > > diff --git a/drivers/char/rpmb/Makefile b/drivers/char/rpmb/Makefile > > index 812b3ed264c0..b5dc087b1299 100644 > > --- a/drivers/char/rpmb/Makefile > > +++ b/drivers/char/rpmb/Makefile > > @@ -1,4 +1,5 @@ > > obj-$(CONFIG_RPMB) += rpmb.o > > rpmb-objs += core.o > > +rpmb-$(CONFIG_RPMB_INTF_DEV) += cdev.o This is not a builtin, this is an optional part of the module > > +#include > > ....not use module.h or any MODULE_ macros from within it. Can be dropped in this case as no macros are used, but the pattern Kconfig bool -> no include module.h you are following has false positive cases. Thanks Tomas