From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752601AbcJHSTy convert rfc822-to-8bit (ORCPT ); Sat, 8 Oct 2016 14:19:54 -0400 Received: from mga05.intel.com ([192.55.52.43]:25977 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbcJHSTq (ORCPT ); Sat, 8 Oct 2016 14:19:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,462,1473145200"; d="scan'208";a="888063119" From: "Winkler, Tomas" To: Jarkko Sakkinen CC: "tpmdd-devel@lists.sourceforge.net" , Jason Gunthorpe , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb Thread-Topic: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb Thread-Index: AQHSIVvBRDIPGvbpy0iefweCFgxt2aCeTyYAgAA+0yD///dmAIAAWEjg Date: Sat, 8 Oct 2016 18:18:36 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B542F684D@hasmsx108.ger.corp.intel.com> References: <1475927979-23484-1-git-send-email-tomas.winkler@intel.com> <1475927979-23484-5-git-send-email-tomas.winkler@intel.com> <20161008124708.GA10317@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B542F6741@hasmsx108.ger.corp.intel.com> <20161008160112.GB25893@intel.com> In-Reply-To: <20161008160112.GB25893@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmM3YWQ3NzUtNzMzNS00ZTVjLTg3OWQtMGI4ZDE4MzI4MDNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InRwdTRLRzB1Q0hpa1pHNUZlclZQVndtQWtqQzFzNEdOdFFKK21lZGRHMlE9In0= x-originating-ip: [10.184.70.11] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Jarkko Sakkinen [mailto:jarkko.sakkinen@linux.intel.com] > Sent: Saturday, October 08, 2016 19:01 > To: Winkler, Tomas > Cc: tpmdd-devel@lists.sourceforge.net; Jason Gunthorpe > ; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb > > On Sat, Oct 08, 2016 at 01:37:31PM +0000, Winkler, Tomas wrote: > > > > > > On Sat, Oct 08, 2016 at 02:59:39PM +0300, Tomas Winkler wrote: > > > > From: "Winkler, Tomas" > > > > > > > > Utilize runtime_pm for driving tpm crb idle states. > > > > The framework calls cmd_ready from the pm_runtime_resume handler > > > > and go idle from the pm_runtime_suspend handler. > > > > The TPM framework should wake the device before transmit and receive. > > > > In case the runtime_pm framework is not compiled in or enabled, > > > > the device will be in the permanent ready state. > > > > > > > > Signed-off-by: Tomas Winkler > > > > > > I would rather want the fix as a separate patch to make review + > > > testing easier (without and with). Thanks. > > > > But you've dropped the patches, so I've resent them. > > Can you do the diff yourself, just branch it off. it's really just > > few lines > > Nope. I have only dropped the workaround. This is what is current in the linus tree: git log --oneline linux/master -- drivers/char/tpm/ 324152502b0e Revert "tpm/tpm_crb: implement tpm crb idle state" cfa188220363 Revert "tmp/tpm_crb: fix Intel PTT hw bug during idle state" 2b7926ae1cd4 Revert "tpm/tpm_crb: open code the crb_init into acpi_add" 4886cd80cb8e Revert "tmp/tpm_crb: implement runtime pm for tpm_crb" e350e24694e4 tmp/tpm_crb: implement runtime pm for tpm_crb 0c22db435bf7 tpm/tpm_crb: open code the crb_init into acpi_add 9514ff1961c6 tmp/tpm_crb: fix Intel PTT hw bug during idle state e17acbbb69d3 tpm/tpm_crb: implement tpm crb idle state