From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754303AbdAKWOj convert rfc822-to-8bit (ORCPT ); Wed, 11 Jan 2017 17:14:39 -0500 Received: from mga06.intel.com ([134.134.136.31]:63116 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753219AbdAKWOi (ORCPT ); Wed, 11 Jan 2017 17:14:38 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,347,1477983600"; d="scan'208";a="1111288547" From: "Winkler, Tomas" To: Paul Menzel , Thorsten Leemhuis CC: Greg Kroah-Hartman , Jan Niehusmann , Linux Kernel Mailing List , Daniel Blueman , "Brown, Len" , "Usyskin, Alexander" Subject: RE: Dell XPS13 does not suspend with Linux 4.10-rc3 Thread-Topic: Dell XPS13 does not suspend with Linux 4.10-rc3 Thread-Index: AQHSa+4rfOj/0U9KdkO3wFn/Xb4UHKEy5G4AgAAjAeCAAFv+AIAAdKPQ Date: Wed, 11 Jan 2017 22:14:26 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B5437A7B7@hasmsx108.ger.corp.intel.com> References: <7b1ba8e4-03b2-8a73-603b-63cce6403c31@molgen.mpg.de> <20170110204331.GA3974@x61s.reliablesolutions.de> <20170110222437.GA3022@x61s.reliablesolutions.de> <384df4ea-8a3e-0db3-c057-e8ef46912504@molgen.mpg.de> <20170111093622.GA16662@kroah.com> <18fde78a-d1fd-0978-1170-211ee2b0b857@molgen.mpg.de> <5B8DA87D05A7694D9FA63FD143655C1B5437A141@hasmsx108.ger.corp.intel.com> <639d2a00-3094-951a-3665-b0f1cb6dec91@molgen.mpg.de> In-Reply-To: <639d2a00-3094-951a-3665-b0f1cb6dec91@molgen.mpg.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDQyZWU0MjMtNzBiNy00N2IyLTk5MTktODUxMDViOGEwMmJiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im5kRFRHY05CRkFlUEV1WjRYNjE0OWFyQmc4RHQrcXpWNTZ4dHgwY2dcL0ZNPSJ9 x-originating-ip: [10.184.70.11] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On 01/11/17 10:49, Winkler, Tomas wrote: > > >> Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3 > >> > >> On 01/11/17 10:36, Greg Kroah-Hartman wrote: > >>> On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote: > >> > >>>> On 01/10/17 23:24, Jan Niehusmann wrote: > >>>>> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote: > >>>>>> And I bisected the issue to commit 7279b238ba, "mei: send OS type > >>>>>> to the FW" > >>>>> > >>>>> Indeed, just disabling the FIXUP implemented by that commit fixes > >>>>> suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s. > >>>>> > >>>>> (For the addressees newly added to cc, it seems like the mentioned > >>>>> commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s) > >>>>> > >>>>> --- a/drivers/misc/mei/bus-fixup.c > >>>>> +++ b/drivers/misc/mei/bus-fixup.c > >>>>> @@ -406,3 +406,3 @@ static struct mei_fixup { > >>>>> MEI_FIXUP(MEI_UUID_WD, mei_wd), > >>>>> - MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix), > >>>>> +// MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix), > >>>>> }; > >>>>> > >>>>> > >>>>> I don't know what this may break, as the description of 7279b23 > >>>>> just > >>>>> says: > >>>>> "This workaround was added to support other broken OS and we need > >>>>> to follow here." > >>>>> > >>>>> Unless there is a better justification, I think the commit should > >>>>> be reverted, for now. > >>>> > >>>> Somebody else already created the bug 192051 in the Linux Kernel > >>>> Bug Tracker [1]. > >>> > >>> There's a fix for this in my tree to go to Linus for 4.10-rc4. > >> > >> Yes, Tomas referenced it in the bug report. I test it on the Dell > >> XPS13 > >> (9360) now. > > As written elsewhere, the issue on the Dell XPS13 seems to be a different issue. > (No idea, which message I should have replied to.) I have to run, and won't > have access to the machine until Monday, so here is as far as I got. > > ``` > $ git bisect log > git bisect start > # good: [69973b830859bc6529a7a0468ba0d80ee5117826] Linux 4.9 git bisect > good 69973b830859bc6529a7a0468ba0d80ee5117826 > # good: [69973b830859bc6529a7a0468ba0d80ee5117826] Linux 4.9 git bisect > good 69973b830859bc6529a7a0468ba0d80ee5117826 > # bad: [a121103c922847ba5010819a3f250f1f7fc84ab8] Linux 4.10-rc3 git bisect > bad a121103c922847ba5010819a3f250f1f7fc84ab8 > # bad: [72cca7baf4fba777b8ab770b902cf2e08941773f] Merge tag 'staging- > 4.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging > git bisect bad 72cca7baf4fba777b8ab770b902cf2e08941773f > # good: [b8d2798f32785398fcd1c48ea80c0c6c5ab88537] Merge tag 'clk-for- > linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux > git bisect good b8d2798f32785398fcd1c48ea80c0c6c5ab88537 > # good: [9439b3710df688d853eb6cb4851256f2c92b1797] Merge tag 'drm-for- > v4.10' of git://people.freedesktop.org/~airlied/linux > git bisect good 9439b3710df688d853eb6cb4851256f2c92b1797 > ``` Can you please hattach your .config as well Thanks Tomas