From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755882AbdCTXjH (ORCPT <rfc822;w@1wt.eu>);
        Mon, 20 Mar 2017 19:39:07 -0400
Received: from mga14.intel.com ([192.55.52.115]:54279 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754163AbdCTXjG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Mar 2017 19:39:06 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,196,1486454400"; 
   d="scan'208";a="1110498517"
From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
CC: Arnd Bergmann <arnd@arndb.de>, Peter Huewe <peterhuewe@gmx.de>,
        "Marcel Selhorst" <tpmdd@selhorst.net>,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        Jerry Snitselaar <jsnitsel@redhat.com>,
        "tpmdd-devel@lists.sourceforge.net" 
        <tpmdd-devel@lists.sourceforge.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused
Thread-Topic: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused
Thread-Index: AQHSoVr9x3fd6karfEGn7YYVRJSuU6GdoYFw///k8wCAAM3ZQP//5B4AgAAnwsA=
Date: Mon, 20 Mar 2017 23:35:57 +0000
Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B543B0650@hasmsx108.ger.corp.intel.com>
References: <20170320091755.1043811-1-arnd@arndb.de>
 <5B8DA87D05A7694D9FA63FD143655C1B543B032E@hasmsx108.ger.corp.intel.com>
 <CAK8P3a25sh0U=N9E1pWACL_9h7VBseUBX50WZe5rXMpNHY=GbA@mail.gmail.com>
 <5B8DA87D05A7694D9FA63FD143655C1B543B0620@hasmsx108.ger.corp.intel.com>
 <20170320230430.GA25163@obsidianresearch.com>
In-Reply-To: <20170320230430.GA25163@obsidianresearch.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTYxNTYwYTgtMWUyYi00NTY5LTkzNWItNWZmNDYyYjA5NjVmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImVwa0tTcTErOEZ2WDJlMkN5UzZQT3NSdmlrZDBiQ2Y0ZGw4RlNNUlBYS2s9In0=
x-originating-ip: [10.184.70.11]
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2KNdGNk028736


> 
> On Mon, Mar 20, 2017 at 11:01:36PM +0000, Winkler, Tomas wrote:
> 
> > I believe that in this case the #ifdefs can be done correctly quite
> > easily, but now I'm not against your solution as well, just maybe put
> > some of this info to the commit message.
> 
> I perfer fewer ifdefs, it makes it more maintainable..

Sure,
> 
> The compiler will remove unused static functions.

I'm not sure if this goes away w/o --gc-sections, but it might. 
Will check, didn't looked at that for a while. 

Thanks
Tomas 

Tomas