From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752533AbdCVVZy (ORCPT ); Wed, 22 Mar 2017 17:25:54 -0400 Received: from mga04.intel.com ([192.55.52.120]:24994 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079AbdCVVZl (ORCPT ); Wed, 22 Mar 2017 17:25:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,206,1486454400"; d="scan'208";a="239293931" From: "Winkler, Tomas" To: Christoph Hellwig CC: Greg Kroah-Hartman , Ulf Hansson , "Hunter, Adrian" , "James Bottomley" , "Martin K . Petersen" , Vinayak Holikatti , Andy Lutomirski , Arve Hj?nnev?g , "Michael Ryleev" , Joao Pinto , Yaniv Gardi , Avri Altman , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-doc@vger.kernel.org" , "Usyskin, Alexander" Subject: RE: [PATCH v7 09/11] scsi: ufs: connect to RPMB subsystem Thread-Topic: [PATCH v7 09/11] scsi: ufs: connect to RPMB subsystem Thread-Index: AQHSOSjV53ZeniQD5UKbC3Ck9d4uNqDNvsCAgAAj9PCAAAfYAIDUNDvQ Date: Wed, 22 Mar 2017 21:25:36 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B543C0457@hasmsx108.ger.corp.intel.com> References: <1478548394-8184-1-git-send-email-tomas.winkler@intel.com> <1478548394-8184-10-git-send-email-tomas.winkler@intel.com> <20161107190109.GA5110@lst.de> <5B8DA87D05A7694D9FA63FD143655C1B5431750E@hasmsx108.ger.corp.intel.com> <20161107213754.GA10433@lst.de> In-Reply-To: <20161107213754.GA10433@lst.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzc1OTliNjEtMGQ0Yy00NmE5LWIwNmItMGNiZWUwMmFkNThiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikc4SmhJbUlpUVwvSDN0Q0QzNXk0N2k4XC9zMitQcHFlYWdcL0dLNmhzXC8xM1JJPSJ9 x-originating-ip: [10.184.70.11] Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2MLQ3cd008514 > > On Mon, Nov 07, 2016 at 07:27:38PM +0000, Winkler, Tomas wrote: > > I value your opinion but I'm not responsible for inventing RPMB > > and/or its implementation storage devices (eMMC, UFC, NVMe), it's pretty > much done deal out there in the wild. > > I'm just trying to provide common API above it. Somehow I've missed that answer, now I got back when search for comments before I'll post a new series. > And the common API must go through the SCSI midlayer. I've actually tried to do a midlayer, but I found it's too UFS specific, so there is no point to this abstraction. As not all needed data are accessible via scsi calls. The solution I propose fits with what is done in eMMC (emmc specific IOCTL). There is already some code that breaks that layering in ufshcd_set_dev_pwr_mode when talking to the special sdev_ufs. Maybe I need more hint for the correct directions. If it can't we won't > support it, so please drop the UFS patches from the series. If you have more constructive comments, I'll be glad to hear and address. Thanks Tomas