linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: Nayna Jain <nayna@linux.ibm.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Nayna Jain <nayna@linux.vnet.ibm.com>,
	"Usyskin, Alexander" <alexander.usyskin@intel.com>,
	"Struk, Tadeusz" <tadeusz.struk@intel.com>,
	"linux-integrity@vger.kernel.org"
	<linux-integrity@vger.kernel.org>,
	"linux-security-module@vger.kernel.org" 
	<linux-security-module@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Mimi Zohar <zohar@linux.ibm.com>
Subject: RE: [PATCH v6 03/20] tpm: factor out tpm 1.x duration calculation to tpm1-cmd.c
Date: Wed, 17 Oct 2018 15:28:27 +0000	[thread overview]
Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9D9F49D7@hasmsx109.ger.corp.intel.com> (raw)
In-Reply-To: <650c00b1-d53e-27e8-3e1f-94e34c2ae2e9@linux.ibm.com>


> 
> 
> On 10/17/2018 05:54 PM, Winkler, Tomas wrote:
> >>
> >>>    	ordinal = be32_to_cpu(*((__be32 *) (buf + 6)));
> >>> -	rc = i2c_nuvoton_wait_for_data_avail(chip,
> >>> -					     tpm_calc_ordinal_duration(chip,
> >>> -								       ordinal),
> >>> -					     &priv->read_queue);
> >>> +	duration = tpm1_calc_ordinal_duration(chip, ordinal);
> >>
> >> This version of the patch didn't address my previous comment - "The
> >> original code in the nuvoton driver does not differentiate between
> >> TPM 1.2 and TPM
> >> 2.0 as it does in tpm_tis_core.c.
> >> Before making any changes, I would first fix it, so that it could
> >> easily be backported. Only then do the refactoring."
> > This patch doesn't change the original behavior, just change the name of
> the function,  so there is no regression.
> > I would suggest there is another bug in those drivers/devices that is
> orthogonal to this refactoring and should not block this from merging.
> 
> The problem is that you are inadvertently fixing a bug without realizing it -
> [Patch 04/20]. Bug fixes should be addressed independently of this change,
> so that they can be backported properly.
>
This would be ideal,  but that's happen more than often that the fix cannot be applied w/o changes to older kernels.
I can send that patch, are you able to test it? Frankly nobody complained about it so I'm not sure what to do.
 
> > According to what you say  it can call just
> > tpm_calc_oridnal_duration() instead of tpm1_calc_ordinal_duration(chip,
> ordinal), but I prefer that someone that has those devices will do that
> change on top of this series as  I cannot test it.
> 
> The problem is:
> 
> 1. This patch calls tpm1_calc_ordinal_duration for both the TPM 1.2 and
> TPM 2.0.
That's correct 
> 2. In the next patch, it adds a new function tpm_calc_ordinal_duration as a
> wrapper for both the TPM 1.2 and TPM 2.0. After this change when it calls
> tpm_calc_ordinal_duration(), it now calls different functions for TPM 1.2 and
> TPM 2.0. This is a change in behavior.
That's not correct,   I missed that.  Either someone can test the TPM 2.0 device  or I need to revert it for nuvoton, in the next patch.  

Thanks
Tomas


  reply	other threads:[~2018-10-17 15:28 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17  6:45 [PATCH v6 00/21] tpm: separate tpm 1.x and tpm 2.x commands Tomas Winkler
2018-10-17  6:45 ` [PATCH v6 01/20] tpm2: add new tpm2 commands according to TCG 1.36 Tomas Winkler
2018-10-17  6:45 ` [PATCH v6 02/20] tpm: sort objects in the Makefile Tomas Winkler
2018-10-17  6:45 ` [PATCH v6 03/20] tpm: factor out tpm 1.x duration calculation to tpm1-cmd.c Tomas Winkler
2018-10-17 11:54   ` Nayna Jain
2018-10-17 12:24     ` Winkler, Tomas
2018-10-17 15:07       ` Nayna Jain
2018-10-17 15:28         ` Winkler, Tomas [this message]
2018-10-17  6:45 ` [PATCH v6 04/20] tpm: add tpm_calc_ordinal_duration() wrapper Tomas Winkler
2018-10-17  6:45 ` [PATCH v6 05/20] tpm: factor out tpm_get_timeouts() Tomas Winkler
2018-10-17  6:45 ` [PATCH v6 06/20] tpm: move tpm1_pcr_extend to tpm1-cmd.c Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 07/20] tpm: move tpm_getcap " Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 08/20] tpm: factor out tpm1_get_random into tpm1-cmd.c Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 09/20] tpm: move tpm 1.x selftest code from tpm-interface.c tpm1-cmd.c Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 10/20] tpm: factor out tpm 1.x pm suspend flow into tpm1-cmd.c Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 11/20] tpm: factor out tpm_startup function Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 12/20] tpm: add tpm_auto_startup() into tpm-interface.c Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 13/20] tpm: tpm-interface.c drop unused macros Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 14/20] tpm: tpm-space.c remove unneeded semicolon Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 15/20] tpm: tpm1: rewrite tpm1_get_random() using tpm_buf structure Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 16/20] tpm1: implement tpm1_pcr_read_dev() " Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 17/20] tmp1: rename tpm1_pcr_read_dev to tpm1_pcr_read() Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 18/20] tpm1: reimplement SAVESTATE using tpm_buf Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 19/20] tpm1: reimplement tpm1_continue_selftest() " Tomas Winkler
2018-10-17  6:46 ` [PATCH v6 20/20] tpm: use u32 instead of int for PCR index Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B8DA87D05A7694D9FA63FD143655C1B9D9F49D7@hasmsx109.ger.corp.intel.com \
    --to=tomas.winkler@intel.com \
    --cc=alexander.usyskin@intel.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=nayna@linux.ibm.com \
    --cc=nayna@linux.vnet.ibm.com \
    --cc=tadeusz.struk@intel.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).