From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA95C43381 for ; Sun, 10 Mar 2019 10:14:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99555206BA for ; Sun, 10 Mar 2019 10:14:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726488AbfCJKOI convert rfc822-to-8bit (ORCPT ); Sun, 10 Mar 2019 06:14:08 -0400 Received: from mga02.intel.com ([134.134.136.20]:31838 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbfCJKOH (ORCPT ); Sun, 10 Mar 2019 06:14:07 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Mar 2019 03:14:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,463,1544515200"; d="scan'208";a="153669330" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 10 Mar 2019 03:14:07 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 10 Mar 2019 03:14:06 -0700 Received: from hasmsx113.ger.corp.intel.com (10.184.198.64) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 10 Mar 2019 03:14:06 -0700 Received: from hasmsx108.ger.corp.intel.com ([169.254.9.237]) by HASMSX113.ger.corp.intel.com ([169.254.13.155]) with mapi id 14.03.0415.000; Sun, 10 Mar 2019 12:14:04 +0200 From: "Winkler, Tomas" To: Greg Kroah-Hartman CC: "Usyskin, Alexander" , "linux-kernel@vger.kernel.org" Subject: RE: [char-misc] mei: convert to SPDX license tags Thread-Topic: [char-misc] mei: convert to SPDX license tags Thread-Index: AQHU1ybJNips0XONy0yJUSiwdKR3g6YEn8Cw Date: Sun, 10 Mar 2019 10:14:03 +0000 Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9DAC7ED3@hasmsx108.ger.corp.intel.com> References: <20190310100323.6912-1-tomas.winkler@intel.com> <20190310094817.GA2987@kroah.com> In-Reply-To: <20190310094817.GA2987@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.12.119.15] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Sun, Mar 10, 2019 at 12:03:23PM +0200, Tomas Winkler wrote: > > Signed-off-by: Tomas Winkler > > I can not take patches without any changelog text. Ok, my mistake. > > Especially a patch that does not actually do what your subject: line says it does. Yep, I should be more verbose. > > > --- a/drivers/misc/mei/Makefile > > +++ b/drivers/misc/mei/Makefile > > @@ -1,7 +1,7 @@ > > # SPDX-License-Identifier: GPL-2.0 > > # > > # Makefile - Intel Management Engine Interface (Intel MEI) Linux > > driver -# Copyright (c) 2010-2014, Intel Corporation. > > +# Copyright (c) 2010-2019, Intel Corporation. > > # > > obj-$(CONFIG_INTEL_MEI) += mei.o > > mei-objs := init.o > > As an example, why did you update this copyright line? That has nothing to do > with the SPDX identifier :( Right, will update the commit message. > > > > --- a/drivers/misc/mei/client.c > > +++ b/drivers/misc/mei/client.c > > @@ -1,17 +1,8 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > /* > > + * Copyright(c) 2003-2019, Intel Corporation. All rights reserved. > > * > > * Intel Management Engine Interface (Intel MEI) Linux driver > > - * Copyright (c) 2003-2012, Intel Corporation. > > Are you _SURE_ you mean to change the dates of the copyright in this manner > for this file (and elsewhere?) Was the copyright really updated every year for > the past 7 years? Yes, this particular file was updated, will go over other files. > > Please break this up into two (at the least) patches and resend as a series. Can you be please, more specific what split are you expecting. > > This patch makes me feel like it is a kernel intern application process patch, > and that's not good, you all know better than this. No, sorry, I take that back, > the intern application patches are of much higher quality... > Have hard time to put the soul into it, where it comes to legal :) Will fix. Tomas