From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B90CC433F5 for ; Thu, 6 Sep 2018 14:51:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDE5020857 for ; Thu, 6 Sep 2018 14:51:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDE5020857 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730262AbeIFT1b (ORCPT ); Thu, 6 Sep 2018 15:27:31 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:42435 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729920AbeIFT1b (ORCPT ); Thu, 6 Sep 2018 15:27:31 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 97E65B55FC49C; Thu, 6 Sep 2018 22:51:32 +0800 (CST) Received: from [127.0.0.1] (10.177.29.68) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.399.0; Thu, 6 Sep 2018 22:51:30 +0800 Message-ID: <5B913EF2.1010209@huawei.com> Date: Thu, 6 Sep 2018 22:51:30 +0800 From: zhong jiang User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: , , , CC: , Subject: Re: [PATCH] gpu: do not double put device node in zx_drm_probe References: <1534472646-10368-1-git-send-email-zhongjiang@huawei.com> In-Reply-To: <1534472646-10368-1-git-send-email-zhongjiang@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.29.68] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +to maintainer. On 2018/8/17 10:24, zhong jiang wrote: > for_each_available_child_of_node will get and put the node properly, > the following of_node_put will lead to the double put. So just > remove it. > > Signed-off-by: zhong jiang gg > --- > drivers/gpu/drm/zte/zx_drm_drv.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c > index 6f4205e8..d7b9870 100644 > --- a/drivers/gpu/drm/zte/zx_drm_drv.c > +++ b/drivers/gpu/drm/zte/zx_drm_drv.c > @@ -161,10 +161,8 @@ static int zx_drm_probe(struct platform_device *pdev) > if (ret) > return ret; > > - for_each_available_child_of_node(parent, child) { > + for_each_available_child_of_node(parent, child) > component_match_add(dev, &match, compare_of, child); > - of_node_put(child); > - } > > return component_master_add_with_match(dev, &zx_drm_master_ops, match); > }