From: zhong jiang <zhongjiang@huawei.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Himanshu Jha <himanshujha199640@gmail.com>, <knaack.h@gmx.de>,
<lars@metafoo.de>, <pmeerw@pmeerw.net>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: remove unnecessary condition judgment in am2315_trigger_handler
Date: Tue, 11 Sep 2018 09:16:42 +0800 [thread overview]
Message-ID: <5B97177A.6010301@huawei.com> (raw)
In-Reply-To: <5B967653.1030007@huawei.com>
On 2018/9/10 21:49, zhong jiang wrote:
> On 2018/9/8 22:17, Jonathan Cameron wrote:
>> On Sat, 8 Sep 2018 17:59:13 +0530
>> Himanshu Jha <himanshujha199640@gmail.com> wrote:
>>
>>> On Sat, Sep 08, 2018 at 06:57:36PM +0800, zhong jiang wrote:
>>>> The iterator in for_each_set_bit is never null, therefore, remove
>>>> the redundant conditional judgment.
>>>>
>>>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>>>> ---
>>>> drivers/iio/humidity/am2315.c | 3 +--
>>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c
>>>> index 7d8669d..dc12e37 100644
>>>> --- a/drivers/iio/humidity/am2315.c
>>>> +++ b/drivers/iio/humidity/am2315.c
>>>> @@ -176,8 +176,7 @@ static irqreturn_t am2315_trigger_handler(int irq, void *p)
>>>> i = 0;
>>>> for_each_set_bit(bit, indio_dev->active_scan_mask,
>>>> indio_dev->masklength) {
>>>> - data->buffer[i] = (bit ? sensor_data.temp_data :
>>>> - sensor_data.hum_data);
>>>> + data->buffer[i] = sensor_data.temp_data;
>>> No, this seems wrong!
>>>
>>> We have buffer support to either take both readings(temp & humid)
>>> simultaneously, or only single channel using specified scan mask.
>> Key think is that bit most definitely can be 0 if the 0th bit is set.
>> This isn't a null check at all.
>>
>> I'm curious, was this a by inspection case or did some script throw
>> this one up?
> Hi, Jonathan
>
> bit is a iterator that find the non-zero bit in indio_dev->active_scan_mask. if all bit is
> zero , it should return the masklength.
That's my stupid fault. The patch is totally wrong.:-(
Thanks,
zhong jiang
> Yep. I find the issue with the help of Coccinelle.
>
> Thanks
> zhong jiang
>> Thanks,
>>
>> Jonathan
>>
>>> Patch title should be:
>>>
>>> "iio: humidity: am2315: .... .. "
>>>
>>>
>>> Thanks
>> .
>>
>
>
> .
>
next prev parent reply other threads:[~2018-09-11 1:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 10:57 [PATCH] iio: remove unnecessary condition judgment in am2315_trigger_handler zhong jiang
2018-09-08 12:29 ` Himanshu Jha
2018-09-08 14:17 ` Jonathan Cameron
2018-09-10 13:49 ` zhong jiang
2018-09-11 1:16 ` zhong jiang [this message]
2018-09-10 15:57 ` David Frey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B97177A.6010301@huawei.com \
--to=zhongjiang@huawei.com \
--cc=himanshujha199640@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).