From: wangyufen <wangyufen@huawei.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <akpm@linux-foundation.org>,
<kstewart@linuxfoundation.org>, <rppt@linux.vnet.ibm.com>,
<gregkh@linuxfoundation.org>, <tglx@linutronix.de>,
<pombredanne@nexb.com>, <weiyongjun1@huawei.com>,
<huawei.libin@huawei.com>
Subject: Re: [PATCH] ARM:kexec:offline panic_smp_self_stop CPU
Date: Fri, 2 Nov 2018 09:17:00 +0800 [thread overview]
Message-ID: <5BDBA58C.9090803@huawei.com> (raw)
In-Reply-To: <20181101113430.GO30658@n2100.armlinux.org.uk>
On 2018/11/1 19:34, Russell King - ARM Linux wrote:
> On Thu, Nov 01, 2018 at 07:20:49PM +0800, Wang Yufen wrote:
>> From: Yufen Wang <wangyufen@huawei.com>
>>
>> In case panic() and panic() called at the same time on different CPUS.
>> For example:
>> CPU 0:
>> panic()
>> __crash_kexec
>> machine_crash_shutdown
>> crash_smp_send_stop
>> machine_kexec
>> BUG_ON(num_online_cpus() > 1);
>>
>> CPU 1:
>> panic()
>> local_irq_disable
>> panic_smp_self_stop
>>
>> If CPU 1 calls panic_smp_self_stop() before crash_smp_send_stop(), kdump
>> fails. CPU1 can't receive the ipi irq, CPU1 will be always online.
>> I changed BUG_ON to WARN in kexec crash as arm64 does, kdump also fails.
>> Because num_online_cpus() > 1, can't disable the L2 in _soft_restart.
>> To fix this problem, this patch split out the panic_smp_self_stop()
>> and add set_cpu_online(smp_processor_id(), false).
> Thanks.
>
> I think this may as well go into arch/arm/kernel/smp.c - it won't be
> required for single-CPU systems, since there aren't "other" CPUs.
>
> It's probably also worth a comment above the function as to why we
> have this.
Thanks.
I will send v2.
>> Signed-off-by: Yufen Wang <wangyufen@huawei.com>
>> ---
>> arch/arm/kernel/setup.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
>> index 31940bd..151861f 100644
>> --- a/arch/arm/kernel/setup.c
>> +++ b/arch/arm/kernel/setup.c
>> @@ -602,6 +602,16 @@ static void __init smp_build_mpidr_hash(void)
>> }
>> #endif
>>
>> +void panic_smp_self_stop(void)
>> +{
>> + printk(KERN_DEBUG "CPU %u will stop doing anything useful since another CPU has paniced\n",
>> + smp_processor_id());
>> + set_cpu_online(smp_processor_id(), false);
>> + while (1)
>> + cpu_relax();
>> +
>> +}
>> +
>> static void __init setup_processor(void)
>> {
>> struct proc_info_list *list;
>> --
>> 2.7.4
>>
>>
next prev parent reply other threads:[~2018-11-02 1:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 11:20 [PATCH] ARM:kexec:offline panic_smp_self_stop CPU Wang Yufen
2018-11-01 11:34 ` Russell King - ARM Linux
2018-11-02 1:17 ` wangyufen [this message]
2018-11-02 2:31 ` [PATCH v2] " wangyufen
2018-11-02 9:55 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BDBA58C.9090803@huawei.com \
--to=wangyufen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=huawei.libin@huawei.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=pombredanne@nexb.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).