From: Wei Xu <xuwei5@hisilicon.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>, <arm@kernel.org>
Cc: <devicetree@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 04/10] arm64: dts: hi3660: Add missing cooling device properties for CPUs
Date: Thu, 29 Nov 2018 15:44:39 +0000 [thread overview]
Message-ID: <5C000967.7070103@hisilicon.com> (raw)
In-Reply-To: <042e5e647a7b54f4322024f1b3e286b6b6d69175.1542362530.git.viresh.kumar@linaro.org>
Hi Viresh,
On 2018/11/16 10:04, Viresh Kumar wrote:
> The cooling device properties, like "#cooling-cells" and
> "dynamic-power-coefficient", should either be present for all the CPUs
> of a cluster or none. If these are present only for a subset of CPUs of
> a cluster then things will start falling apart as soon as the CPUs are
> brought online in a different order. For example, this will happen
> because the operating system looks for such properties in the CPU node
> it is trying to bring up, so that it can register a cooling device.
>
> Add such missing properties.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Applied to the hisilicon soc dt tree.
Thanks!
Best Regards,
Wei
> ---
> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index f432b0a88c65..d943a96eedee 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -79,6 +79,7 @@
> capacity-dmips-mhz = <592>;
> clocks = <&stub_clock HI3660_CLK_STUB_CLUSTER0>;
> operating-points-v2 = <&cluster0_opp>;
> + #cooling-cells = <2>;
> };
>
> cpu2: cpu@2 {
> @@ -91,6 +92,7 @@
> capacity-dmips-mhz = <592>;
> clocks = <&stub_clock HI3660_CLK_STUB_CLUSTER0>;
> operating-points-v2 = <&cluster0_opp>;
> + #cooling-cells = <2>;
> };
>
> cpu3: cpu@3 {
> @@ -103,6 +105,7 @@
> capacity-dmips-mhz = <592>;
> clocks = <&stub_clock HI3660_CLK_STUB_CLUSTER0>;
> operating-points-v2 = <&cluster0_opp>;
> + #cooling-cells = <2>;
> };
>
> cpu4: cpu@100 {
> @@ -129,6 +132,7 @@
> capacity-dmips-mhz = <1024>;
> clocks = <&stub_clock HI3660_CLK_STUB_CLUSTER1>;
> operating-points-v2 = <&cluster1_opp>;
> + #cooling-cells = <2>;
> };
>
> cpu6: cpu@102 {
> @@ -141,6 +145,7 @@
> capacity-dmips-mhz = <1024>;
> clocks = <&stub_clock HI3660_CLK_STUB_CLUSTER1>;
> operating-points-v2 = <&cluster1_opp>;
> + #cooling-cells = <2>;
> };
>
> cpu7: cpu@103 {
> @@ -153,6 +158,7 @@
> capacity-dmips-mhz = <1024>;
> clocks = <&stub_clock HI3660_CLK_STUB_CLUSTER1>;
> operating-points-v2 = <&cluster1_opp>;
> + #cooling-cells = <2>;
> };
>
> idle-states {
>
next prev parent reply other threads:[~2018-11-29 15:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 10:04 [PATCH 00/10] ARM64: dts: Fix incomplete cooling-maps Viresh Kumar
2018-11-16 10:04 ` [PATCH 01/10] ARM64: dts: amlogic: Add all CPUs in cooling maps Viresh Kumar
2018-11-16 10:07 ` Neil Armstrong
2018-11-29 0:35 ` Kevin Hilman
2018-11-16 10:04 ` [PATCH 02/10] ARM64: dts: exynos: " Viresh Kumar
2018-11-18 14:20 ` Krzysztof Kozlowski
2018-11-16 10:04 ` [PATCH 03/10] ARM64: dts: fsl: " Viresh Kumar
2018-11-28 2:46 ` Shawn Guo
2018-11-16 10:04 ` [PATCH 04/10] arm64: dts: hi3660: Add missing cooling device properties for CPUs Viresh Kumar
2018-11-29 15:44 ` Wei Xu [this message]
2018-11-16 10:04 ` [PATCH 05/10] ARM64: dts: hisilicon: Add all CPUs in cooling maps Viresh Kumar
2018-11-29 15:45 ` Wei Xu
2018-11-16 10:04 ` [PATCH 06/10] ARM64: dts: mediatek: " Viresh Kumar
2018-11-16 10:04 ` [PATCH 07/10] ARM64: dts: msm8916: " Viresh Kumar
2018-11-16 10:04 ` [PATCH 08/10] ARM64: dts: renesas: " Viresh Kumar
2018-11-23 12:51 ` Simon Horman
2018-11-16 10:04 ` [PATCH 09/10] ARM64: dts: rockchip: " Viresh Kumar
2018-11-26 13:16 ` Heiko Stuebner
2018-11-16 10:04 ` [PATCH 10/10] ARM64: dts: uniphier: " Viresh Kumar
2018-11-26 15:49 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C000967.7070103@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=arm@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).