From: Roger Quadros <rogerq@ti.com>
To: Pawel Laszczak <pawell@cadence.com>, <devicetree@vger.kernel.org>
Cc: <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
<balbi@kernel.org>, <linux-kernel@vger.kernel.org>,
<adouglas@cadence.com>, <jbergsagel@ti.com>, <nsekhar@ti.com>,
<nm@ti.com>, <sureshp@cadence.com>, <peter.chen@nxp.com>,
<pjez@cadence.com>, <kurahul@cadence.com>
Subject: Re: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver
Date: Tue, 11 Dec 2018 11:39:48 +0200 [thread overview]
Message-ID: <5C0F85E4.10609@ti.com> (raw)
In-Reply-To: <1544445555-17325-3-git-send-email-pawell@cadence.com>
Pawel,
On 10/12/18 14:39, Pawel Laszczak wrote:
> This patch introduce new Cadence USBSS DRD driver
> to linux kernel.
>
> The Cadence USBSS DRD Driver is a highly
> configurable IP Core which can be
> instantiated as Dual-Role Device (DRD),
> Peripheral Only and Host Only (XHCI)
> configurations.
>
> The current driver has been validated with
> FPGA burned. We have support for PCIe
> bus, which is used on FPGA prototyping.
>
> The host side of USBSS-DRD controller is compliance
> with XHCI specification, so it works with
> standard XHCI linux driver.
>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
> drivers/usb/Kconfig | 2 +
> drivers/usb/Makefile | 2 +
> drivers/usb/cdns3/Kconfig | 44 +
> drivers/usb/cdns3/Makefile | 16 +
> drivers/usb/cdns3/cdns3-pci-wrap.c | 157 +++
> drivers/usb/cdns3/core.c | 451 +++++++
> drivers/usb/cdns3/core.h | 108 ++
> drivers/usb/cdns3/debug.h | 346 ++++++
> drivers/usb/cdns3/debugfs.c | 168 +++
> drivers/usb/cdns3/drd.c | 315 +++++
> drivers/usb/cdns3/drd.h | 129 ++
> drivers/usb/cdns3/ep0.c | 864 +++++++++++++
> drivers/usb/cdns3/gadget-export.h | 28 +
> drivers/usb/cdns3/gadget.c | 1802 ++++++++++++++++++++++++++++
> drivers/usb/cdns3/gadget.h | 1177 ++++++++++++++++++
> drivers/usb/cdns3/host-export.h | 28 +
> drivers/usb/cdns3/host.c | 74 ++
> drivers/usb/cdns3/trace.c | 11 +
> drivers/usb/cdns3/trace.h | 343 ++++++
You went to the other extreme of combining everything (host/gadget/drd) together
which again makes this very hard to review.
I think what Felipe meant was to only combine the gadget driver code into one patch.
The series could be split into 6 patches like so.
-dt binding
-pci glue
-core driver
-host driver
-gadget driver
-drd driver
> 19 files changed, 6065 insertions(+)
> create mode 100644 drivers/usb/cdns3/Kconfig
> create mode 100644 drivers/usb/cdns3/Makefile
> create mode 100644 drivers/usb/cdns3/cdns3-pci-wrap.c
> create mode 100644 drivers/usb/cdns3/core.c
> create mode 100644 drivers/usb/cdns3/core.h
> create mode 100644 drivers/usb/cdns3/debug.h
> create mode 100644 drivers/usb/cdns3/debugfs.c
> create mode 100644 drivers/usb/cdns3/drd.c
> create mode 100644 drivers/usb/cdns3/drd.h
> create mode 100644 drivers/usb/cdns3/ep0.c
> create mode 100644 drivers/usb/cdns3/gadget-export.h
> create mode 100644 drivers/usb/cdns3/gadget.c
> create mode 100644 drivers/usb/cdns3/gadget.h
> create mode 100644 drivers/usb/cdns3/host-export.h
> create mode 100644 drivers/usb/cdns3/host.c
> create mode 100644 drivers/usb/cdns3/trace.c
> create mode 100644 drivers/usb/cdns3/trace.h
>
<snip>
cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2018-12-11 9:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 12:39 [PATCH v1 0/2] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 1/2] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2018-12-11 10:16 ` Roger Quadros
2018-12-13 9:20 ` Peter Chen
2018-12-13 9:25 ` Pawel Laszczak
2018-12-20 20:01 ` Rob Herring
2018-12-22 22:24 ` Pawel Laszczak
2018-12-27 21:01 ` Rob Herring
2018-12-31 5:35 ` Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2018-12-11 9:39 ` Roger Quadros [this message]
2018-12-11 10:01 ` Pawel Laszczak
2018-12-11 12:15 ` Felipe Balbi
2018-12-11 11:46 ` Felipe Balbi
2018-12-11 12:14 ` Felipe Balbi
2018-12-11 19:04 ` Pawel Laszczak
2018-12-12 2:04 ` Peter Chen
2018-12-12 6:55 ` Felipe Balbi
2018-12-12 7:38 ` Peter Chen
2018-12-12 8:34 ` Felipe Balbi
2018-12-12 9:24 ` Peter Chen
2018-12-12 15:53 ` Bin Liu
2018-12-13 1:21 ` Peter Chen
2018-12-12 6:52 ` Felipe Balbi
2018-12-14 3:46 ` Kishon Vijay Abraham I
2018-12-17 5:46 ` Pawel Laszczak
2018-12-17 11:25 ` Pawel Laszczak
2018-12-17 11:34 ` Felipe Balbi
2018-12-17 11:51 ` Pawel Laszczak
2018-12-17 11:56 ` Felipe Balbi
2018-12-13 9:35 ` Peter Chen
2018-12-16 13:01 ` Pawel Laszczak
2018-12-14 22:56 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C0F85E4.10609@ti.com \
--to=rogerq@ti.com \
--cc=adouglas@cadence.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbergsagel@ti.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=pjez@cadence.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).