linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Seiji Aguchi <seiji.aguchi@hds.com>
To: "Luck, Tony" <tony.luck@intel.com>, Don Zickus <dzickus@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Matthew Garrett <mjg@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
	"Chen, Gong" <gong.chen@intel.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"Brown, Len" <len.brown@intel.com>,
	"'ying.huang@intel.com'" <'ying.huang@intel.com'>,
	"'ak@linux.intel.com'" <'ak@linux.intel.com'>,
	"'hughd@chromium.org'" <'hughd@chromium.org'>,
	"'mingo@elte.hu'" <'mingo@elte.hu'>,
	"jmorris@namei.org" <jmorris@namei.org>,
	"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
	"namhyung@gmail.com" <namhyung@gmail.com>,
	"dle-develop@lists.sourceforge.net" 
	<dle-develop@lists.sourceforge.net>,
	Satoru Moriya <satoru.moriya@hds.com>
Subject: [RFC][PATCH v4 -next 3/4]Skip subsequent kmsg_dump() function calls in panic path
Date: Thu, 5 Jan 2012 12:39:59 -0500	[thread overview]
Message-ID: <5C4C569E8A4B9B42A84A977CF070A35B2C5827AF86@USINDEVS01.corp.hds.com> (raw)
In-Reply-To: <5C4C569E8A4B9B42A84A977CF070A35B2C5827AF7F@USINDEVS01.corp.hds.com>

This patch skips subsequent kmsg_dump() function calls in panic path

With this patch, we can avoid deadlock due to the subsequent calls.
Actually, kmsg_dump(KMSG_DUMP_EMREG) is called after kmsg_dump(KMSG_DUMP_PANIC) 
when panic_timeout variable is set.

 Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>

---
 kernel/printk.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/kernel/printk.c b/kernel/printk.c
index 5294426..186d792 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -1731,6 +1731,16 @@ void kmsg_dump(enum kmsg_dump_reason reason)
 	const char *s1, *s2;
 	unsigned long l1, l2;
 	unsigned long flags;
+	static bool panicked;
+
+	/*
+	 * kmsg_dump() is skipped because we already got panic log.
+	 */
+	if (panicked)
+		return;
+
+	if (reason == KMSG_DUMP_PANIC)
+		panicked = true;
 
 	/*
 	 * Currently, "in_nmi() && reason != KMSG_DUMP_PANIC" case never happens
-- 
1.7.1



  parent reply	other threads:[~2012-01-05 17:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-05 17:35 [RFC][PATCH v4 -next 0/4] Make pstore/kmsg_dump run after stopping other cpus in panic path Seiji Aguchi
2012-01-05 17:36 ` [RFC][PATCH v4 -next 1/4] Move kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop() Seiji Aguchi
2012-01-05 19:06   ` Luck, Tony
2012-01-05 20:10     ` Seiji Aguchi
2012-01-05 21:01       ` Don Zickus
2012-01-09 17:59         ` Seiji Aguchi
2012-01-10  3:06           ` Chen Gong
2012-01-10 20:29             ` Seiji Aguchi
2012-01-11  7:28               ` Chen Gong
2012-01-11 17:25                 ` Don Zickus
2012-01-11 22:22                   ` Luck, Tony
2012-01-13 22:50                     ` Seiji Aguchi
     [not found]                     ` <32727E9A83EE9A42A1F0906295A3A77B2C78F49973@USINDEVS01.corp.hds.com>
2012-01-19 20:58                       ` Seiji Aguchi
2012-01-20 17:56                         ` Luck, Tony
2012-02-03 17:18                           ` Don Zickus
2012-02-03 22:32                             ` Luck, Tony
2012-02-03 22:57                               ` Don Zickus
2012-02-08 20:19                                 ` Don Zickus
2012-02-08 21:28                                   ` Luck, Tony
2012-02-08 22:48                                     ` Don Zickus
2012-02-08 22:56                                       ` Seiji Aguchi
2012-01-05 17:38 ` [RFC][PATCH v4 -next 2/4] Skip spin_locks in panic case and Add WARN_ON() Seiji Aguchi
2012-01-05 17:39 ` Seiji Aguchi [this message]
2012-01-05 17:41 ` [RFC][PATCH v4 -next 4/4] Skip spin_lock of efi_pstore_write() in panic case Seiji Aguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5C4C569E8A4B9B42A84A977CF070A35B2C5827AF86@USINDEVS01.corp.hds.com \
    --to=seiji.aguchi@hds.com \
    --cc='ak@linux.intel.com' \
    --cc='hughd@chromium.org' \
    --cc='mingo@elte.hu' \
    --cc='ying.huang@intel.com' \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=dle-develop@lists.sourceforge.net \
    --cc=dzickus@redhat.com \
    --cc=gong.chen@intel.com \
    --cc=jmorris@namei.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=namhyung@gmail.com \
    --cc=satoru.moriya@hds.com \
    --cc=tony.luck@intel.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).