From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00284C282C4 for ; Mon, 4 Feb 2019 15:34:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD08720823 for ; Mon, 4 Feb 2019 15:34:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="f35UZhYj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731133AbfBDPeV (ORCPT ); Mon, 4 Feb 2019 10:34:21 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:33688 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbfBDPeU (ORCPT ); Mon, 4 Feb 2019 10:34:20 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x14FXC1B063883; Mon, 4 Feb 2019 09:33:12 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1549294392; bh=IEyo7PLz2Q/FxzailgO9nX6m+dDz3G65hSLJKIaBxU8=; h=Subject:To:References:CC:From:Date:In-Reply-To; b=f35UZhYjMQ0BGvrvELpH94Eo26aR9lYg9tjM8PzmCBGTR8tir8n8L7BNKXw+3Sm5a d6ct29C5MEnA44meICkcuUgXNedIseWziyXcZznFYtehnA9vG/anUfzRvYFSGCnJVY Q9Xa90b+I4xSDSNawZOl6RG2GLlS+0f/lUvQ14F4= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x14FXC0p089205 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 4 Feb 2019 09:33:12 -0600 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 4 Feb 2019 09:33:12 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Mon, 4 Feb 2019 09:33:12 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x14FX70l023222; Mon, 4 Feb 2019 09:33:08 -0600 Subject: Re: [PATCH v2 04/14] irqchip: pruss: Add a PRUSS irqchip driver for PRUSS interrupts To: "Andrew F. Davis" , , , References: <1549290167-876-1-git-send-email-rogerq@ti.com> <1549290167-876-5-git-send-email-rogerq@ti.com> <57e5b54e-430e-daa1-4b5d-f61827095606@ti.com> CC: , , , , , , , , , , , , Thomas Gleixner , Jason Cooper , Marc Zyngier From: Roger Quadros Message-ID: <5C585B33.4030505@ti.com> Date: Mon, 4 Feb 2019 17:33:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <57e5b54e-430e-daa1-4b5d-f61827095606@ti.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/02/19 17:11, Andrew F. Davis wrote: > On 2/4/19 8:22 AM, Roger Quadros wrote: >> From: "Andrew F. Davis" >> > > [...] > >> +static const struct pruss_intc_match_data am437x_pruss_intc_data = { >> + .no_host7_intr = true, > > Like done for the PRUSS driver with 'has_no_sharedram' becoming a DT > flag the same could be done here, then all this match data stuff could > be dropped. Agreed. > >> +}; >> + >> +static const struct of_device_id pruss_intc_of_match[] = { >> + { >> + .compatible = "ti,am3356-pruss-intc", >> + .data = NULL, >> + }, >> + { >> + .compatible = "ti,am4376-pruss-intc", >> + .data = &am437x_pruss_intc_data, >> + }, >> + { >> + .compatible = "ti,am5728-pruss-intc", >> + .data = NULL, >> + }, >> + { /* sentinel */ }, >> +}; >> +MODULE_DEVICE_TABLE(of, pruss_intc_of_match); >> + >> +static struct platform_driver pruss_intc_driver = { >> + .driver = { >> + .name = "pruss-intc", >> + .of_match_table = pruss_intc_of_match, >> + }, >> + .probe = pruss_intc_probe, >> + .remove = pruss_intc_remove, >> +}; >> +module_platform_driver(pruss_intc_driver); >> + >> +MODULE_AUTHOR("Andrew F. Davis "); >> +MODULE_AUTHOR("Suman Anna "); >> +MODULE_DESCRIPTION("PRU-ICSS INTC Driver"); >> +MODULE_LICENSE("GPL v2"); >> diff --git a/include/linux/irqchip/irq-pruss-intc.h b/include/linux/irqchip/irq-pruss-intc.h >> new file mode 100644 >> index 0000000..4538a0b >> --- /dev/null >> +++ b/include/linux/irqchip/irq-pruss-intc.h >> @@ -0,0 +1,94 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/** >> + * irq-pruss-intc.h - PRU-ICSS INTC management > > Filename not needed. OK. cheers, -roger > > Andrew > >> + * >> + * Copyright (C) 2019 Texas Instruments Incorporated - http://www.ti.com >> + */ >> + >> +#ifndef __INCLUDE_LINUX_IRQCHIP_IRQ_PRUSS_INTC_H >> +#define __INCLUDE_LINUX_IRQCHIP_IRQ_PRUSS_INTC_H >> + >> +/* maximum number of system events */ >> +#define MAX_PRU_SYS_EVENTS 64 >> + >> +/* maximum number of interrupt channels */ >> +#define MAX_PRU_CHANNELS 10 >> + >> +/** >> + * struct pruss_intc_config - INTC configuration info >> + * @sysev_to_ch: system events to channel mapping information >> + * @ch_to_host: interrupt channel to host interrupt information >> + */ >> +struct pruss_intc_config { >> + s8 sysev_to_ch[MAX_PRU_SYS_EVENTS]; >> + s8 ch_to_host[MAX_PRU_CHANNELS]; >> +}; >> + >> +#if IS_ENABLED(CONFIG_TI_PRUSS) >> + >> +/** >> + * pruss_intc_configure() - configure the PRUSS INTC >> + * @dev: device >> + * @intc_config: PRU core-specific INTC configuration >> + * >> + * Configures the PRUSS INTC with the provided configuration from >> + * a PRU core. Any existing event to channel mappings or channel to >> + * host interrupt mappings are checked to make sure there are no >> + * conflicting configuration between both the PRU cores. The function >> + * is intended to be used only by the PRU remoteproc driver. >> + * >> + * Returns 0 on success, or a suitable error code otherwise >> + */ >> +int pruss_intc_configure(struct device *dev, >> + struct pruss_intc_config *intc_config); >> + >> +/** >> + * pruss_intc_unconfigure() - unconfigure the PRUSS INTC >> + * @dev: device >> + * @intc_config: PRU core specific INTC configuration >> + * >> + * Undo whatever was done in pruss_intc_configure() for a PRU core. >> + * It should be sufficient to just mark the resources free in the >> + * global map and disable the host interrupts and sysevents. >> + */ >> +int pruss_intc_unconfigure(struct device *dev, >> + struct pruss_intc_config *intc_config); >> +/** >> + * pruss_intc_trigger() - trigger a PRU system event >> + * @irq: linux IRQ number associated with a PRU system event >> + * >> + * Trigger an interrupt by signalling a specific PRU system event. >> + * This can be used by PRUSS client users to raise/send an event to >> + * a PRU or any other core that is listening on the host interrupt >> + * mapped to that specific PRU system event. The @irq variable is the >> + * Linux IRQ number associated with a specific PRU system event that >> + * a client user/application uses. The interrupt mappings for this is >> + * provided by the PRUSS INTC irqchip instance. >> + * >> + * Returns 0 on success, or an error value upon failure. >> + */ >> +int pruss_intc_trigger(unsigned int irq); >> + >> +#else >> + >> +static inline int pruss_intc_configure(struct device *dev, >> + struct pruss_intc_config *intc_config) >> +{ >> + return -ENOTSUPP; >> +} >> + >> +static inline int pruss_intc_unconfigure(struct device *dev, >> + struct pruss_intc_config *intc_config) >> +{ >> + return -ENOTSUPP; >> +} >> + >> +static inline int pruss_intc_trigger(unsigned int irq) >> +{ >> + return -ENOTSUPP; >> +} >> + >> +#endif /* CONFIG_TI_PRUSS */ >> + >> +#endif /* __INCLUDE_LINUX_IRQCHIP_IRQ_OMAP_INTC_H */ >> + >> -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki