From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0AC7C7618F for ; Mon, 29 Jul 2019 01:45:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95659206DD for ; Mon, 29 Jul 2019 01:45:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726455AbfG2BpA (ORCPT ); Sun, 28 Jul 2019 21:45:00 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3190 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726216AbfG2Bo7 (ORCPT ); Sun, 28 Jul 2019 21:44:59 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 10A16CC1ED126121B8D2; Mon, 29 Jul 2019 09:44:58 +0800 (CST) Received: from [127.0.0.1] (10.63.139.185) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Mon, 29 Jul 2019 09:44:50 +0800 Subject: Re: [PATCH resend v2] lib: scatterlist: Fix to support no mapped sg To: , , References: <1563940463-95597-1-git-send-email-wangzhou1@hisilicon.com> CC: , From: Zhou Wang Message-ID: <5D3E4F91.4020605@hisilicon.com> Date: Mon, 29 Jul 2019 09:44:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1563940463-95597-1-git-send-email-wangzhou1@hisilicon.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.63.139.185] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/7/24 11:54, Zhou Wang wrote: > In function sg_split, the second sg_calculate_split will return -EINVAL > when in_mapped_nents is 0. > > Indeed there is no need to do second sg_calculate_split and sg_split_mapped > when in_mapped_nents is 0, as in_mapped_nents indicates no mapped entry in > original sgl. > > Signed-off-by: Zhou Wang > Acked-by: Robert Jarzmik > --- > v2: Just add Acked-by from Robert. > > lib/sg_split.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/lib/sg_split.c b/lib/sg_split.c > index 9982c63..60a0bab 100644 > --- a/lib/sg_split.c > +++ b/lib/sg_split.c > @@ -176,11 +176,13 @@ int sg_split(struct scatterlist *in, const int in_mapped_nents, > * The order of these 3 calls is important and should be kept. > */ > sg_split_phys(splitters, nb_splits); > - ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip, > - split_sizes, splitters, true); > - if (ret < 0) > - goto err; > - sg_split_mapped(splitters, nb_splits); > + if (in_mapped_nents) { > + ret = sg_calculate_split(in, in_mapped_nents, nb_splits, skip, > + split_sizes, splitters, true); > + if (ret < 0) > + goto err; > + sg_split_mapped(splitters, nb_splits); > + } > > for (i = 0; i < nb_splits; i++) { > out[i] = splitters[i].out_sg; > Hi Jens, I saw you are the committer of sg_splite.c, could you help to take this patch? Many thanks, Zhou