From: Qian Cai <cai@lca.pw>
To: Chris Down <chris@chrisdown.name>
Cc: Michal Hocko <mhocko@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memcontrol.c: move mem_cgroup_id_get_many under CONFIG_MMU
Date: Tue, 17 Dec 2019 10:09:33 -0500 [thread overview]
Message-ID: <5D853968-99FD-4B66-9784-C1C540B23F92@lca.pw> (raw)
In-Reply-To: <20191217143720.GB131030@chrisdown.name>
> On Dec 17, 2019, at 9:37 AM, Chris Down <chris@chrisdown.name> wrote:
>
> I struggle to imagine a real issue this would catch that wouldn't already be caught by other means. If it's just the risks of dead code, that seems equally risky as taking time away from reviewers.
Hate to say this but ignore unrealistic configs compiling test should not take that much time.
next prev parent reply other threads:[~2019-12-17 15:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 6:47 [PATCH] mm: memcontrol.c: move mem_cgroup_id_get_many under CONFIG_MMU Kuninori Morimoto
2019-12-17 9:53 ` Michal Hocko
2019-12-17 13:54 ` Chris Down
2019-12-17 14:16 ` Qian Cai
2019-12-17 14:37 ` Chris Down
2019-12-17 15:09 ` Qian Cai [this message]
2019-12-17 14:46 ` Michal Hocko
2019-12-17 15:04 ` Qian Cai
2019-12-17 15:13 ` Michal Hocko
2019-12-17 15:17 ` Qian Cai
2019-12-17 15:09 ` Chris Down
2019-12-17 15:19 ` Michal Hocko
2019-12-17 15:28 ` Chris Down
2019-12-17 15:32 ` Chris Down
2019-12-17 15:34 ` Qian Cai
2019-12-17 15:46 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D853968-99FD-4B66-9784-C1C540B23F92@lca.pw \
--to=cai@lca.pw \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=hannes@cmpxchg.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).