From: zhong jiang <zhongjiang@huawei.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fault-inject: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops
Date: Wed, 30 Oct 2019 20:09:53 +0800 [thread overview]
Message-ID: <5DB97D91.1010500@huawei.com> (raw)
In-Reply-To: <CAC5umygBcEic4HXCWfFKj0ZJHo8RRzPkO959051eYoH7y4C39A@mail.gmail.com>
On 2019/10/30 18:29, Akinobu Mita wrote:
> 2019年10月30日(水) 17:26 zhong jiang <zhongjiang@huawei.com>:
>> It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file
>> operation rather than DEFINE_SIMPLE_ATTRIBUTE.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> lib/fault-inject.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
>> index 8186ca8..4e61326 100644
>> --- a/lib/fault-inject.c
>> +++ b/lib/fault-inject.c
>> @@ -164,7 +164,7 @@ static int debugfs_ul_get(void *data, u64 *val)
>> return 0;
>> }
>>
>> -DEFINE_SIMPLE_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n");
>> +DEFINE_DEBUGFS_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n");
>>
>> static void debugfs_create_ul(const char *name, umode_t mode,
>> struct dentry *parent, unsigned long *value)
> Nowadays we have debugfs_create_ulong(), so should we use it instead of
> debugfs_create_ul() defined in this file and remove the definision
> altogether?
>
> .
yes, you are right. That is better. I will repost in v2. Thanks
Sincerely,
zhong jiang
>
prev parent reply other threads:[~2019-10-30 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 8:22 [PATCH] fault-inject: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops zhong jiang
2019-10-30 9:10 ` Greg KH
2019-10-30 9:31 ` zhong jiang
2019-10-30 10:29 ` Akinobu Mita
2019-10-30 12:09 ` zhong jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DB97D91.1010500@huawei.com \
--to=zhongjiang@huawei.com \
--cc=akinobu.mita@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).