* [PATCH] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static
@ 2019-12-16 10:08 zhong jiang
2019-12-16 13:01 ` Andrew F. Davis
0 siblings, 1 reply; 9+ messages in thread
From: zhong jiang @ 2019-12-16 10:08 UTC (permalink / raw)
To: sumit.semwal, afd, benjamin.gaignard
Cc: lmark, labbott, Brian.Starkey, john.stultz, linux-media,
linux-kernel, zhongjiang
Fix the following sparse warning.
drivers/gpu/drm/ast/ast_main.c:391:22: warning: symbol 'ast_mode_config_mode_valid' was not declared. Should it be static?
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/dma-buf/dma-heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
index 4f04d10..da2090e 100644
--- a/drivers/dma-buf/dma-heap.c
+++ b/drivers/dma-buf/dma-heap.c
@@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data)
return 0;
}
-unsigned int dma_heap_ioctl_cmds[] = {
+static unsigned int dma_heap_ioctl_cmds[] = {
DMA_HEAP_IOC_ALLOC,
};
--
1.7.12.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static
2019-12-16 10:08 [PATCH] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static zhong jiang
@ 2019-12-16 13:01 ` Andrew F. Davis
2019-12-16 13:36 ` zhong jiang
2019-12-16 13:38 ` [PATCH v2] " zhong jiang
0 siblings, 2 replies; 9+ messages in thread
From: Andrew F. Davis @ 2019-12-16 13:01 UTC (permalink / raw)
To: zhong jiang, sumit.semwal, benjamin.gaignard
Cc: lmark, labbott, Brian.Starkey, john.stultz, linux-media, linux-kernel
On 12/16/19 5:08 AM, zhong jiang wrote:
> Fix the following sparse warning.
>
> drivers/gpu/drm/ast/ast_main.c:391:22: warning: symbol 'ast_mode_config_mode_valid' was not declared. Should it be static?
>
The patch looks valid, but this commit message does not seem to match..
Andrew
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/dma-buf/dma-heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
> index 4f04d10..da2090e 100644
> --- a/drivers/dma-buf/dma-heap.c
> +++ b/drivers/dma-buf/dma-heap.c
> @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data)
> return 0;
> }
>
> -unsigned int dma_heap_ioctl_cmds[] = {
> +static unsigned int dma_heap_ioctl_cmds[] = {
> DMA_HEAP_IOC_ALLOC,
> };
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static
2019-12-16 13:01 ` Andrew F. Davis
@ 2019-12-16 13:36 ` zhong jiang
2019-12-16 13:38 ` [PATCH v2] " zhong jiang
1 sibling, 0 replies; 9+ messages in thread
From: zhong jiang @ 2019-12-16 13:36 UTC (permalink / raw)
To: Andrew F. Davis
Cc: sumit.semwal, benjamin.gaignard, lmark, labbott, Brian.Starkey,
john.stultz, linux-media, linux-kernel
On 2019/12/16 21:01, Andrew F. Davis wrote:
> On 12/16/19 5:08 AM, zhong jiang wrote:
>> Fix the following sparse warning.
>>
>> drivers/gpu/drm/ast/ast_main.c:391:22: warning: symbol 'ast_mode_config_mode_valid' was not declared. Should it be static?
>>
>
> The patch looks valid, but this commit message does not seem to match..
Sorry for stupid mistake. Will repost it in v2.
Thanks,
zhong jiang
>
> Andrew
>
>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> drivers/dma-buf/dma-heap.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
>> index 4f04d10..da2090e 100644
>> --- a/drivers/dma-buf/dma-heap.c
>> +++ b/drivers/dma-buf/dma-heap.c
>> @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data)
>> return 0;
>> }
>>
>> -unsigned int dma_heap_ioctl_cmds[] = {
>> +static unsigned int dma_heap_ioctl_cmds[] = {
>> DMA_HEAP_IOC_ALLOC,
>> };
>>
>>
> .
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static
2019-12-16 13:01 ` Andrew F. Davis
2019-12-16 13:36 ` zhong jiang
@ 2019-12-16 13:38 ` zhong jiang
2019-12-16 13:45 ` Andrew F. Davis
2019-12-16 21:13 ` John Stultz
1 sibling, 2 replies; 9+ messages in thread
From: zhong jiang @ 2019-12-16 13:38 UTC (permalink / raw)
To: afd, sumit.semwal, benjamin.gaignard
Cc: labbott, Brian.Starkey, john.stultz, linux-kernel, linux-media,
zhongjiang
Fix the following sparse warning.
drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds' was not declared. Should it be static?
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/dma-buf/dma-heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
index 4f04d10..da2090e 100644
--- a/drivers/dma-buf/dma-heap.c
+++ b/drivers/dma-buf/dma-heap.c
@@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data)
return 0;
}
-unsigned int dma_heap_ioctl_cmds[] = {
+static unsigned int dma_heap_ioctl_cmds[] = {
DMA_HEAP_IOC_ALLOC,
};
--
1.7.12.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static
2019-12-16 13:38 ` [PATCH v2] " zhong jiang
@ 2019-12-16 13:45 ` Andrew F. Davis
2019-12-16 21:13 ` John Stultz
1 sibling, 0 replies; 9+ messages in thread
From: Andrew F. Davis @ 2019-12-16 13:45 UTC (permalink / raw)
To: zhong jiang, sumit.semwal, benjamin.gaignard
Cc: labbott, Brian.Starkey, john.stultz, linux-kernel, linux-media
On 12/16/19 8:38 AM, zhong jiang wrote:
> Fix the following sparse warning.
>
> drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds' was not declared. Should it be static?
>
Acked-by: Andrew F. Davis <afd@ti.com>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/dma-buf/dma-heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
> index 4f04d10..da2090e 100644
> --- a/drivers/dma-buf/dma-heap.c
> +++ b/drivers/dma-buf/dma-heap.c
> @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data)
> return 0;
> }
>
> -unsigned int dma_heap_ioctl_cmds[] = {
> +static unsigned int dma_heap_ioctl_cmds[] = {
> DMA_HEAP_IOC_ALLOC,
> };
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static
2019-12-16 13:38 ` [PATCH v2] " zhong jiang
2019-12-16 13:45 ` Andrew F. Davis
@ 2019-12-16 21:13 ` John Stultz
2019-12-17 2:26 ` zhong jiang
1 sibling, 1 reply; 9+ messages in thread
From: John Stultz @ 2019-12-16 21:13 UTC (permalink / raw)
To: zhong jiang
Cc: Andrew F. Davis, Sumit Semwal, Benjamin Gaignard, Laura Abbott,
Brian Starkey, lkml, linux-media
On Mon, Dec 16, 2019 at 5:43 AM zhong jiang <zhongjiang@huawei.com> wrote:
>
> Fix the following sparse warning.
>
> drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds' was not declared. Should it be static?
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/dma-buf/dma-heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
> index 4f04d10..da2090e 100644
> --- a/drivers/dma-buf/dma-heap.c
> +++ b/drivers/dma-buf/dma-heap.c
> @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data)
> return 0;
> }
>
> -unsigned int dma_heap_ioctl_cmds[] = {
> +static unsigned int dma_heap_ioctl_cmds[] = {
> DMA_HEAP_IOC_ALLOC,
> };
Acked-by: John Stultz <john.stultz@linaro.org>
This patch will collide with Andrew's _IOCTL_ naming change, but its a
fairly simple thing to resolve.
Sumit: If you're comfortable resolving the collision, please queue
with the rest of the recent changes for drm-misc-next.
Otherwise, I'm happy to submit the resolution I tested with here
afterwards. Let me know.
thanks
-john
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static
2019-12-16 21:13 ` John Stultz
@ 2019-12-17 2:26 ` zhong jiang
2019-12-17 17:08 ` Sumit Semwal
0 siblings, 1 reply; 9+ messages in thread
From: zhong jiang @ 2019-12-17 2:26 UTC (permalink / raw)
To: John Stultz
Cc: Andrew F. Davis, Sumit Semwal, Benjamin Gaignard, Laura Abbott,
Brian Starkey, lkml, linux-media
On 2019/12/17 5:13, John Stultz wrote:
> On Mon, Dec 16, 2019 at 5:43 AM zhong jiang <zhongjiang@huawei.com> wrote:
>> Fix the following sparse warning.
>>
>> drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds' was not declared. Should it be static?
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>> drivers/dma-buf/dma-heap.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
>> index 4f04d10..da2090e 100644
>> --- a/drivers/dma-buf/dma-heap.c
>> +++ b/drivers/dma-buf/dma-heap.c
>> @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data)
>> return 0;
>> }
>>
>> -unsigned int dma_heap_ioctl_cmds[] = {
>> +static unsigned int dma_heap_ioctl_cmds[] = {
>> DMA_HEAP_IOC_ALLOC,
>> };
> Acked-by: John Stultz <john.stultz@linaro.org>
>
> This patch will collide with Andrew's _IOCTL_ naming change, but its a
> fairly simple thing to resolve.
>
> Sumit: If you're comfortable resolving the collision, please queue
> with the rest of the recent changes for drm-misc-next.
> Otherwise, I'm happy to submit the resolution I tested with here
> afterwards. Let me know.
As it is an fairly simple patch, I hope you can resolve the issue directly.
Thanks,
zhong jiang
> thanks
> -john
>
> .
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static
2019-12-17 2:26 ` zhong jiang
@ 2019-12-17 17:08 ` Sumit Semwal
0 siblings, 0 replies; 9+ messages in thread
From: Sumit Semwal @ 2019-12-17 17:08 UTC (permalink / raw)
To: zhong jiang
Cc: John Stultz, Andrew F. Davis, Benjamin Gaignard, Laura Abbott,
Brian Starkey, lkml, open list:DMA BUFFER SHARING FRAMEWORK,
DRI mailing list
Hello Zhong Jiang,
On Tue, 17 Dec 2019 at 07:56, zhong jiang <zhongjiang@huawei.com> wrote:
>
> On 2019/12/17 5:13, John Stultz wrote:
> > On Mon, Dec 16, 2019 at 5:43 AM zhong jiang <zhongjiang@huawei.com> wrote:
> >> Fix the following sparse warning.
Thanks for the patch; could I request you to please use
scripts/get_maintainer.pl to get the cc: list for the patches?
+ dri-devel.
> >>
> >> drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds' was not declared. Should it be static?
> >>
> >> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> >> ---
> >> drivers/dma-buf/dma-heap.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
> >> index 4f04d10..da2090e 100644
> >> --- a/drivers/dma-buf/dma-heap.c
> >> +++ b/drivers/dma-buf/dma-heap.c
> >> @@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data)
> >> return 0;
> >> }
> >>
> >> -unsigned int dma_heap_ioctl_cmds[] = {
> >> +static unsigned int dma_heap_ioctl_cmds[] = {
> >> DMA_HEAP_IOC_ALLOC,
> >> };
> > Acked-by: John Stultz <john.stultz@linaro.org>
> >
> > This patch will collide with Andrew's _IOCTL_ naming change, but its a
> > fairly simple thing to resolve.
> >
> > Sumit: If you're comfortable resolving the collision, please queue
> > with the rest of the recent changes for drm-misc-next.
> > Otherwise, I'm happy to submit the resolution I tested with here
> > afterwards. Let me know.
Of course, I am sure I can handle collisions, John, or else being a
maintainer might get a tad difficult :)
> As it is an fairly simple patch, I hope you can resolve the issue directly.
>
> Thanks,
> zhong jiang
> > thanks
> > -john
> >
Best,
Sumit.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static
@ 2019-12-17 19:08 Sumit Semwal
0 siblings, 0 replies; 9+ messages in thread
From: Sumit Semwal @ 2019-12-17 19:08 UTC (permalink / raw)
To: sumit.semwal
Cc: afd, benjamin.gaignard, lmark, labbott, Brian.Starkey,
john.stultz, linux-media, dri-devel, linaro-mm-sig, linux-kernel,
zhong jiang
From: zhong jiang <zhongjiang@huawei.com>
Fix the following sparse warning.
drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds'
was not declared. Should it be static?
Acked-by: Andrew F. Davis <afd@ti.com>
Acked-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
[sumits: rebased over IOCTL rename patches]
---
drivers/dma-buf/dma-heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
index 1886aee46131..afd22c9dbdcf 100644
--- a/drivers/dma-buf/dma-heap.c
+++ b/drivers/dma-buf/dma-heap.c
@@ -106,7 +106,7 @@ static long dma_heap_ioctl_allocate(struct file *file, void *data)
return 0;
}
-unsigned int dma_heap_ioctl_cmds[] = {
+static unsigned int dma_heap_ioctl_cmds[] = {
DMA_HEAP_IOCTL_ALLOC,
};
--
2.18.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-12-17 19:08 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-16 10:08 [PATCH] dma-heap: Make the symbol 'dma_heap_ioctl_cmds' static zhong jiang
2019-12-16 13:01 ` Andrew F. Davis
2019-12-16 13:36 ` zhong jiang
2019-12-16 13:38 ` [PATCH v2] " zhong jiang
2019-12-16 13:45 ` Andrew F. Davis
2019-12-16 21:13 ` John Stultz
2019-12-17 2:26 ` zhong jiang
2019-12-17 17:08 ` Sumit Semwal
2019-12-17 19:08 [PATCH] " Sumit Semwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).