From: Qian Cai <cai@lca.pw>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jiang, Dave" <dave.jiang@intel.com>,
"Busch, Keith" <keith.busch@intel.com>,
"Weiny, Ira" <ira.weiny@intel.com>
Subject: Re: [PATCH v2] nvdimm/btt: fix variable 'rc' set but not used
Date: Wed, 30 Oct 2019 17:54:05 -0400 [thread overview]
Message-ID: <5E00893B-D36C-446F-9E71-54FB32772DA0@lca.pw> (raw)
In-Reply-To: <03cacc16f2fcd7cc74cf15c57070c78e73206e68.camel@intel.com>
> On Oct 30, 2019, at 5:38 PM, Verma, Vishal L <vishal.l.verma@intel.com> wrote:
>
> Good find! Since we're not really using rc later, we should just
> simplify this to:
>
> if (btt_map_write(...))
> dev_warn_ratelimited(...)
> goto out_rtt;
Ah, I thought about printing the rc as well at first, but it seems only return -EIO for errors, so I agree with you.
prev parent reply other threads:[~2019-10-30 21:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 21:28 [PATCH v2] nvdimm/btt: fix variable 'rc' set but not used Qian Cai
2019-10-30 21:38 ` Verma, Vishal L
2019-10-30 21:54 ` Qian Cai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E00893B-D36C-446F-9E71-54FB32772DA0@lca.pw \
--to=cai@lca.pw \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).