From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CBD7C3F6B0 for ; Tue, 2 Aug 2022 02:47:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235740AbiHBCrt convert rfc822-to-8bit (ORCPT ); Mon, 1 Aug 2022 22:47:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231213AbiHBCrm (ORCPT ); Mon, 1 Aug 2022 22:47:42 -0400 Received: from smtp236.sjtu.edu.cn (smtp236.sjtu.edu.cn [202.120.2.236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CF691AF28; Mon, 1 Aug 2022 19:47:34 -0700 (PDT) Received: from proxy01.sjtu.edu.cn (unknown [202.112.26.54]) by smtp236.sjtu.edu.cn (Postfix) with ESMTPS id D39291008B391; Tue, 2 Aug 2022 10:47:32 +0800 (CST) Received: from localhost (localhost [127.0.0.1]) by proxy01.sjtu.edu.cn (Postfix) with ESMTP id AC7D6203D801B; Tue, 2 Aug 2022 10:47:32 +0800 (CST) X-Virus-Scanned: amavisd-new at proxy01.sjtu.edu.cn Received: from proxy01.sjtu.edu.cn ([127.0.0.1]) by localhost (proxy01.sjtu.edu.cn [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id z8dqFZ4H9EgJ; Tue, 2 Aug 2022 10:47:32 +0800 (CST) Received: from smtpclient.apple (unknown [58.45.124.125]) (Authenticated sender: qtxuning1999@sjtu.edu.cn) by proxy01.sjtu.edu.cn (Postfix) with ESMTPSA id D593B203D8011; Tue, 2 Aug 2022 10:47:05 +0800 (CST) From: Guo Zhi Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\)) Subject: Re: [RFC 3/5] vhost_test: batch used buffer Date: Tue, 2 Aug 2022 10:47:01 +0800 In-Reply-To: Cc: jasowang , sgarzare , Michael Tsirkin , netdev , linux-kernel , kvm list , virtualization To: eperezma Message-Id: <5E347090-9EB2-4961-B435-D6783CB46CAF@sjtu.edu.cn> X-Mailer: Apple Mail (2.3693.20.0.1.32) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- From: "eperezma" To: "Guo Zhi" Cc: "jasowang" , "sgarzare" , "Michael Tsirkin" , "netdev" , "linux-kernel" , "kvm list" , "virtualization" Sent: Friday, July 22, 2022 3:12:47 PM Subject: Re: [RFC 3/5] vhost_test: batch used buffer On Thu, Jul 21, 2022 at 10:44 AM Guo Zhi wrote: > > Only add to used ring when a batch a buffer have all been used. And if > in order feature negotiated, add randomness to the used buffer's order, > test the ability of vhost to reorder batched buffer. > > Signed-off-by: Guo Zhi > --- > drivers/vhost/test.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/vhost/test.c b/drivers/vhost/test.c > index bc8e7fb1e..1c9c40c11 100644 > --- a/drivers/vhost/test.c > +++ b/drivers/vhost/test.c > @@ -43,6 +43,9 @@ struct vhost_test { > static void handle_vq(struct vhost_test *n) > { > struct vhost_virtqueue *vq = &n->vqs[VHOST_TEST_VQ]; > + struct vring_used_elem *heads = kmalloc(sizeof(*heads) > + * vq->num, GFP_KERNEL); > + int batch_idx = 0; > unsigned out, in; > int head; > size_t len, total_len = 0; > @@ -84,11 +87,21 @@ static void handle_vq(struct vhost_test *n) > vq_err(vq, "Unexpected 0 len for TX\n"); > break; > } > - vhost_add_used_and_signal(&n->dev, vq, head, 0); > + heads[batch_idx].id = cpu_to_vhost32(vq, head); > + heads[batch_idx++].len = cpu_to_vhost32(vq, len); > total_len += len; > if (unlikely(vhost_exceeds_weight(vq, 0, total_len))) > break; > } > + if (batch_idx) { > + if (vhost_has_feature(vq, VIRTIO_F_IN_ORDER) && batch_idx >= 2) { Maybe to add a module parameter to test this? Instead of trusting in feature negotiation, "unorder_used=1" or something like that. vhost.c:vhost_add_used_and_signal_n should support receiving buffers in order or out of order whether F_IN_ORDER is negotiated or not. Thanks! > + vhost_add_used_and_signal_n(&n->dev, vq, &heads[batch_idx / 2], > + batch_idx - batch_idx / 2); > + vhost_add_used_and_signal_n(&n->dev, vq, heads, batch_idx / 2); > + } else { > + vhost_add_used_and_signal_n(&n->dev, vq, heads, batch_idx); > + } > + } > > mutex_unlock(&vq->mutex); > } > -- > 2.17.1