From: "Piotr Masłowski" <piotr@maslowski.xyz>
To: marcan@marcan.st
Cc: SHA-cyfmac-dev-list@infineon.com, alyssa@rosenzweig.io,
andy.shevchenko@gmail.com, arend.vanspriel@broadcom.com,
aspriel@gmail.com, brcm80211-dev-list.pdl@broadcom.com,
davem@davemloft.net, devicetree@vger.kernel.org,
digetx@gmail.com, franky.lin@broadcom.com,
hante.meuleman@broadcom.com, hdegoede@redhat.com,
kettenis@openbsd.org, kuba@kernel.org, kvalo@codeaurora.org,
lenb@kernel.org, linus.walleij@linaro.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, linville@tuxdriver.com,
netdev@vger.kernel.org, pieter-paul.giesberts@broadcom.com,
rafael@kernel.org, robh+dt@kernel.org,
sandals@crustytoothpaste.net, sven@svenpeter.dev,
wright.feng@infineon.com, zajec5@gmail.com
Subject: Re: [PATCH v4 7/9] brcmfmac: of: Use devm_kstrdup for board_type & check for errors
Date: Mon, 31 Jan 2022 23:33:49 +0100 [thread overview]
Message-ID: <5E81748D-C6A8-4904-9A03-F61512AF22E5@maslowski.xyz> (raw)
In-Reply-To: <20220131160713.245637-8-marcan@marcan.st>
On Mon, Jan 31, 2022 at 5:07 PM Hector Martin <marcan@marcan.st> wrote:
>
>This was missing a NULL check, and we can collapse the strlen/alloc/copy
>into a devm_kstrdup().
...
> /* get rid of '/' in the compatible string to be able to find the FW */
> len = strlen(tmp) + 1;
>- board_type = devm_kzalloc(dev, len, >GFP_KERNEL);
>- strscpy(board_type, tmp, len);
>+ board_type = devm_kstrdup(dev, tmp, GFP_KERNEL);
Also `len` can be dropped, since it is now unused.
--
Best regards,
Piotr Masłowski
next prev parent reply other threads:[~2022-01-31 22:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 16:07 [PATCH v4 0/9] misc brcmfmac fixes (M1/T2 series spin-off) Hector Martin
2022-01-31 16:07 ` [PATCH v4 1/9] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path Hector Martin
2022-01-31 16:26 ` Andy Shevchenko
2022-02-01 12:27 ` Kalle Valo
2022-01-31 16:07 ` [PATCH v4 2/9] brcmfmac: firmware: Allocate space for default boardrev in nvram Hector Martin
2022-01-31 16:26 ` Andy Shevchenko
2022-01-31 16:07 ` [PATCH v4 3/9] brcmfmac: firmware: Do not crash on a NULL board_type Hector Martin
2022-01-31 16:28 ` Andy Shevchenko
2022-01-31 16:49 ` Kalle Valo
2022-01-31 16:53 ` Hector Martin
2022-02-01 5:12 ` Kalle Valo
2022-01-31 17:49 ` Andy Shevchenko
2022-01-31 16:07 ` [PATCH v4 4/9] brcmfmac: pcie: Declare missing firmware files in pcie.c Hector Martin
2022-01-31 16:07 ` [PATCH v4 5/9] brcmfmac: pcie: Replace brcmf_pcie_copy_mem_todev with memcpy_toio Hector Martin
2022-01-31 16:07 ` [PATCH v4 6/9] brcmfmac: pcie: Fix crashes due to early IRQs Hector Martin
2022-01-31 16:25 ` Andy Shevchenko
2022-01-31 16:07 ` [PATCH v4 7/9] brcmfmac: of: Use devm_kstrdup for board_type & check for errors Hector Martin
2022-01-31 22:33 ` Piotr Masłowski [this message]
2022-01-31 16:07 ` [PATCH v4 8/9] brcmfmac: fwil: Constify iovar name arguments Hector Martin
2022-01-31 16:07 ` [PATCH v4 9/9] brcmfmac: pcie: Read the console on init and shutdown Hector Martin
2022-01-31 16:25 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E81748D-C6A8-4904-9A03-F61512AF22E5@maslowski.xyz \
--to=piotr@maslowski.xyz \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=alyssa@rosenzweig.io \
--cc=andy.shevchenko@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=kettenis@openbsd.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcan@marcan.st \
--cc=netdev@vger.kernel.org \
--cc=pieter-paul.giesberts@broadcom.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sandals@crustytoothpaste.net \
--cc=sven@svenpeter.dev \
--cc=wright.feng@infineon.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).