From: Zhou Wang <wangzhou1@hisilicon.com>
To: Yang Shen <shenyang39@huawei.com>, <herbert@gondor.apana.org.au>,
<davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
<xuzaibo@huawei.com>
Subject: Re: [PATCH] crypto: hisilicon/zip - add a work_queue for zip irq
Date: Thu, 19 Nov 2020 16:49:12 +0800 [thread overview]
Message-ID: <5FB63188.5050303@hisilicon.com> (raw)
In-Reply-To: <1605259955-17796-1-git-send-email-shenyang39@huawei.com>
On 2020/11/13 17:32, Yang Shen wrote:
> The patch 'irqchip/gic-v3-its: Balance initial LPI affinity across CPUs'
> set the IRQ to an uncentain CPU. If an IRQ is bound to the CPU used by the
> thread which is sending request, the throughput will be just half.
>
> So allocate a 'work_queue' and set as 'WQ_UNBOUND' to do the back half work
> on some different CPUS.
>
> Signed-off-by: Yang Shen <shenyang39@huawei.com>
> Reviewed-by: Zaibo Xu <xuzaibo@huawei.com>
Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
Thanks,
Zhou
> ---
> drivers/crypto/hisilicon/zip/zip_main.c | 26 +++++++++++++++++++++++---
> 1 file changed, 23 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/hisilicon/zip/zip_main.c b/drivers/crypto/hisilicon/zip/zip_main.c
> index 3d1524b..4fb5a32b 100644
> --- a/drivers/crypto/hisilicon/zip/zip_main.c
> +++ b/drivers/crypto/hisilicon/zip/zip_main.c
> @@ -747,6 +747,8 @@ static int hisi_zip_pf_probe_init(struct hisi_zip *hisi_zip)
>
> static int hisi_zip_qm_init(struct hisi_qm *qm, struct pci_dev *pdev)
> {
> + int ret;
> +
> qm->pdev = pdev;
> qm->ver = pdev->revision;
> qm->algs = "zlib\ngzip";
> @@ -772,7 +774,25 @@ static int hisi_zip_qm_init(struct hisi_qm *qm, struct pci_dev *pdev)
> qm->qp_num = HZIP_QUEUE_NUM_V1 - HZIP_PF_DEF_Q_NUM;
> }
>
> - return hisi_qm_init(qm);
> + qm->wq = alloc_workqueue("%s", WQ_HIGHPRI | WQ_MEM_RECLAIM |
> + WQ_UNBOUND, num_online_cpus(),
> + pci_name(qm->pdev));
> + if (!qm->wq) {
> + pci_err(qm->pdev, "fail to alloc workqueue\n");
> + return -ENOMEM;
> + }
> +
> + ret = hisi_qm_init(qm);
> + if (ret)
> + destroy_workqueue(qm->wq);
> +
> + return ret;
> +}
> +
> +static void hisi_zip_qm_uninit(struct hisi_qm *qm)
> +{
> + hisi_qm_uninit(qm);
> + destroy_workqueue(qm->wq);
> }
>
> static int hisi_zip_probe_init(struct hisi_zip *hisi_zip)
> @@ -854,7 +874,7 @@ static int hisi_zip_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> hisi_qm_dev_err_uninit(qm);
>
> err_qm_uninit:
> - hisi_qm_uninit(qm);
> + hisi_zip_qm_uninit(qm);
>
> return ret;
> }
> @@ -872,7 +892,7 @@ static void hisi_zip_remove(struct pci_dev *pdev)
> hisi_zip_debugfs_exit(qm);
> hisi_qm_stop(qm, QM_NORMAL);
> hisi_qm_dev_err_uninit(qm);
> - hisi_qm_uninit(qm);
> + hisi_zip_qm_uninit(qm);
> }
>
> static const struct pci_error_handlers hisi_zip_err_handler = {
> --
> 2.7.4
>
> .
>
next prev parent reply other threads:[~2020-11-19 8:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 9:32 [PATCH] crypto: hisilicon/zip - add a work_queue for zip irq Yang Shen
2020-11-19 8:49 ` Zhou Wang [this message]
2020-11-20 6:57 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5FB63188.5050303@hisilicon.com \
--to=wangzhou1@hisilicon.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shenyang39@huawei.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).