linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 0/3] Handle UART without interrupt on TEMT using em485
@ 2021-01-29  0:12 Giulio Benetti
  2021-02-02  0:02 ` Eric Tremblay
  0 siblings, 1 reply; 4+ messages in thread
From: Giulio Benetti @ 2021-01-29  0:12 UTC (permalink / raw)
  To: Eric Tremblay
  Cc: gregkh, jslaby, andriy.shevchenko, matwey.kornilov, lukas,
	linux-serial, linux-kernel, christoph.muellner, heiko,
	heiko.stuebner

Hi Eric,

> Il giorno 29 gen 2021, alle ore 00:37, Eric Tremblay <etremblay@distech-controls.com> ha scritto:
> 
> The series is mainly about the support of 8250 UART without TEMT
> interrupt. I saw that there was some development in the past but
> it was never merged. Since the last discussion were quite some
> time ago, I was not sure if I should post a v4 over the
> last v3 or start from scratch so I decided to post a new patch. Please
> advice if I should have done the reverse.

Please keep my and Heiko’s SoB and add your SoB too describing between [ ] what Heiko has done and what you’ve done. 
For example:
SoB: Giulio
SoB: Heiko
[Heiko: ...]
SoB Eric
[Eric: improved timeout etc.]

> 
> The approach is a little different from the last proposed patch which was
> doing using a polling at 100us. I tought that it could be really long on 
> some fast baudrate and really not that long on slow baudrate. The current
> approach is to calculate the time of a bytes when the settings are changed.
> When we get the interrupt for the empty FIFO, it's the longer it can take
> to empty the shift register.

Good idea.

> 
> The other two patches are to use that features with the PORT_16550A_FSL64
> found on some chip like the LS1043A.

Do you mind to add my 8250_dw patch that was originally part of this patchset? I had to send it
soon, you’ve preceded me :-)

Thank you
Best regards
Giulio

> 
> Thanks
> 
> Eric Tremblay (3):
> serial: 8250: Handle UART without interrupt on TEMT using em485
> serial: 8250: add compatible for fsl,16550-FIFO64
> serial: 8250: remove UART_CAP_TEMT on PORT_16550A_FSL64
> 
> drivers/tty/serial/8250/8250.h            |  1 +
> drivers/tty/serial/8250/8250_bcm2835aux.c |  2 +-
> drivers/tty/serial/8250/8250_of.c         |  5 ++
> drivers/tty/serial/8250/8250_omap.c       |  2 +-
> drivers/tty/serial/8250/8250_port.c       | 89 ++++++++++++++++++++++-
> include/linux/serial_8250.h               |  2 +
> 6 files changed, 98 insertions(+), 3 deletions(-)
> 
> -- 
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/3] Handle UART without interrupt on TEMT using em485
  2021-01-29  0:12 [PATCH 0/3] Handle UART without interrupt on TEMT using em485 Giulio Benetti
@ 2021-02-02  0:02 ` Eric Tremblay
  2021-02-02  0:28   ` Giulio Benetti
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Tremblay @ 2021-02-02  0:02 UTC (permalink / raw)
  To: Giulio Benetti
  Cc: gregkh, jslaby, andriy.shevchenko, matwey.kornilov, lukas,
	linux-serial, linux-kernel, christoph.muellner, heiko,
	heiko.stuebner

On 2021-01-28 7:12 p.m., Giulio Benetti wrote:
> Hi Eric,
>
>> Il giorno 29 gen 2021, alle ore 00:37, Eric Tremblay <etremblay@distech-controls.com> ha scritto:
>>
>> The series is mainly about the support of 8250 UART without TEMT
>> interrupt. I saw that there was some development in the past but
>> it was never merged. Since the last discussion were quite some
>> time ago, I was not sure if I should post a v4 over the
>> last v3 or start from scratch so I decided to post a new patch. Please
>> advice if I should have done the reverse.
> Please keep my and Heiko’s SoB and add your SoB too describing between [ ] what Heiko has done and what you’ve done. 
> For example:
> SoB: Giulio
> SoB: Heiko
> [Heiko: ...]
> SoB Eric
> [Eric: improved timeout etc.]

I will add them in the next version, thanks for mentioning it.

>
>> The approach is a little different from the last proposed patch which was
>> doing using a polling at 100us. I tought that it could be really long on 
>> some fast baudrate and really not that long on slow baudrate. The current
>> approach is to calculate the time of a bytes when the settings are changed.
>> When we get the interrupt for the empty FIFO, it's the longer it can take
>> to empty the shift register.
> Good idea.
>
>> The other two patches are to use that features with the PORT_16550A_FSL64
>> found on some chip like the LS1043A.
> Do you mind to add my 8250_dw patch that was originally part of this patchset? I had to send it
> soon, you’ve preceded me :-)

I think there was still a comment pending on that patch. I think you should resubmit
since I think it's a bit out-of-scope for me.

>
> Thank you
> Best regards
> Giulio
>
>> Thanks
>>
>> Eric Tremblay (3):
>> serial: 8250: Handle UART without interrupt on TEMT using em485
>> serial: 8250: add compatible for fsl,16550-FIFO64
>> serial: 8250: remove UART_CAP_TEMT on PORT_16550A_FSL64
>>
>> drivers/tty/serial/8250/8250.h            |  1 +
>> drivers/tty/serial/8250/8250_bcm2835aux.c |  2 +-
>> drivers/tty/serial/8250/8250_of.c         |  5 ++
>> drivers/tty/serial/8250/8250_omap.c       |  2 +-
>> drivers/tty/serial/8250/8250_port.c       | 89 ++++++++++++++++++++++-
>> include/linux/serial_8250.h               |  2 +
>> 6 files changed, 98 insertions(+), 3 deletions(-)
>>
>> -- 
>> 2.17.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/3] Handle UART without interrupt on TEMT using em485
  2021-02-02  0:02 ` Eric Tremblay
@ 2021-02-02  0:28   ` Giulio Benetti
  0 siblings, 0 replies; 4+ messages in thread
From: Giulio Benetti @ 2021-02-02  0:28 UTC (permalink / raw)
  To: Eric Tremblay
  Cc: gregkh, jslaby, andriy.shevchenko, matwey.kornilov, lukas,
	linux-serial, linux-kernel, christoph.muellner, heiko,
	heiko.stuebner

Il 02/02/2021 01:02, Eric Tremblay ha scritto:
> On 2021-01-28 7:12 p.m., Giulio Benetti wrote:
>> Hi Eric,
>>
>>> Il giorno 29 gen 2021, alle ore 00:37, Eric Tremblay <etremblay@distech-controls.com> ha scritto:
>>>
>>> The series is mainly about the support of 8250 UART without TEMT
>>> interrupt. I saw that there was some development in the past but
>>> it was never merged. Since the last discussion were quite some
>>> time ago, I was not sure if I should post a v4 over the
>>> last v3 or start from scratch so I decided to post a new patch. Please
>>> advice if I should have done the reverse.
>> Please keep my and Heiko’s SoB and add your SoB too describing between [ ] what Heiko has done and what you’ve done.
>> For example:
>> SoB: Giulio
>> SoB: Heiko
>> [Heiko: ...]
>> SoB Eric
>> [Eric: improved timeout etc.]
> 
> I will add them in the next version, thanks for mentioning it.

Thank you

>>
>>> The approach is a little different from the last proposed patch which was
>>> doing using a polling at 100us. I tought that it could be really long on
>>> some fast baudrate and really not that long on slow baudrate. The current
>>> approach is to calculate the time of a bytes when the settings are changed.
>>> When we get the interrupt for the empty FIFO, it's the longer it can take
>>> to empty the shift register.
>> Good idea.
>>
>>> The other two patches are to use that features with the PORT_16550A_FSL64
>>> found on some chip like the LS1043A.
>> Do you mind to add my 8250_dw patch that was originally part of this patchset? I had to send it
>> soon, you’ve preceded me :-)
> 
> I think there was still a comment pending on that patch. I think you should resubmit
> since I think it's a bit out-of-scope for me.

Ah yes, you're correct, I will submit it then.

Best regards
-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

>>
>> Thank you
>> Best regards
>> Giulio
>>
>>> Thanks
>>>
>>> Eric Tremblay (3):
>>> serial: 8250: Handle UART without interrupt on TEMT using em485
>>> serial: 8250: add compatible for fsl,16550-FIFO64
>>> serial: 8250: remove UART_CAP_TEMT on PORT_16550A_FSL64
>>>
>>> drivers/tty/serial/8250/8250.h            |  1 +
>>> drivers/tty/serial/8250/8250_bcm2835aux.c |  2 +-
>>> drivers/tty/serial/8250/8250_of.c         |  5 ++
>>> drivers/tty/serial/8250/8250_omap.c       |  2 +-
>>> drivers/tty/serial/8250/8250_port.c       | 89 ++++++++++++++++++++++-
>>> include/linux/serial_8250.h               |  2 +
>>> 6 files changed, 98 insertions(+), 3 deletions(-)
>>>
>>> -- 
>>> 2.17.1
> 
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 0/3] Handle UART without interrupt on TEMT using em485
@ 2021-01-28 23:36 Eric Tremblay
  0 siblings, 0 replies; 4+ messages in thread
From: Eric Tremblay @ 2021-01-28 23:36 UTC (permalink / raw)
  To: gregkh
  Cc: jslaby, andriy.shevchenko, matwey.kornilov, giulio.benetti,
	lukas, linux-serial, linux-kernel, christoph.muellner, heiko,
	heiko.stuebner, Eric Tremblay

The series is mainly about the support of 8250 UART without TEMT
interrupt. I saw that there was some development in the past but
it was never merged. Since the last discussion were quite some
time ago, I was not sure if I should post a v4 over the
last v3 or start from scratch so I decided to post a new patch. Please
advice if I should have done the reverse.

The approach is a little different from the last proposed patch which was
doing using a polling at 100us. I tought that it could be really long on 
some fast baudrate and really not that long on slow baudrate. The current
approach is to calculate the time of a bytes when the settings are changed.
When we get the interrupt for the empty FIFO, it's the longer it can take
to empty the shift register.

The other two patches are to use that features with the PORT_16550A_FSL64
found on some chip like the LS1043A.

Thanks

Eric Tremblay (3):
  serial: 8250: Handle UART without interrupt on TEMT using em485
  serial: 8250: add compatible for fsl,16550-FIFO64
  serial: 8250: remove UART_CAP_TEMT on PORT_16550A_FSL64

 drivers/tty/serial/8250/8250.h            |  1 +
 drivers/tty/serial/8250/8250_bcm2835aux.c |  2 +-
 drivers/tty/serial/8250/8250_of.c         |  5 ++
 drivers/tty/serial/8250/8250_omap.c       |  2 +-
 drivers/tty/serial/8250/8250_port.c       | 89 ++++++++++++++++++++++-
 include/linux/serial_8250.h               |  2 +
 6 files changed, 98 insertions(+), 3 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-02  0:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-29  0:12 [PATCH 0/3] Handle UART without interrupt on TEMT using em485 Giulio Benetti
2021-02-02  0:02 ` Eric Tremblay
2021-02-02  0:28   ` Giulio Benetti
  -- strict thread matches above, loose matches on Subject: below --
2021-01-28 23:36 Eric Tremblay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).