Re: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF

From: Johannes Berg <johannes@sipsolutions.net>
To: Mario Limonciello <mario.limonciello@amd.com>,
	Evan Quan <evan.quan@amd.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-wireless@vger.kernel.org, rafael@kernel.org,
	lenb@kernel.org, Alexander.Deucher@amd.com,
	Christian.Koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
	daniel@ffwll.ch, kvalo@kernel.org, nbd@nbd.name,
	lorenzo@kernel.org, ryder.lee@mediatek.com,
	shayne.chen@mediatek.com, sean.wang@mediatek.com,
	matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
	Lijo.Lazar@amd.com
Subject: Re: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF
Date: Mon, 19 Jun 2023 10:24:25 +0200	[thread overview]
Message-ID: <5a19bd3074d2763b02a722f31713bbf3bae97e8f.camel@sipsolutions.net> (raw)
In-Reply-To: <3c3dccd6-6772-d62f-f183-bd84e109a366@amd.com>

On Sun, 2023-06-18 at 21:17 -0500, Mario Limonciello wrote:
> 
> > --- a/include/net/cfg80211.h
> > +++ b/include/net/cfg80211.h
> > @@ -920,6 +920,14 @@ const struct cfg80211_chan_def *
> >   cfg80211_chandef_compatible(const struct cfg80211_chan_def *chandef1,
> >   			    const struct cfg80211_chan_def *chandef2);
> >   
> > +/**
> > + * nl80211_chan_width_to_mhz - get the channel width in Mhz
> > + * @chan_width: the channel width from &enum nl80211_chan_width
> > + * Return: channel width in Mhz if the chan_width from &enum nl80211_chan_width
> > + * is valid. -1 otherwise.
> > + */
> > +int nl80211_chan_width_to_mhz(enum nl80211_chan_width chan_width);
> > +
> 
> It's up to mac80211 maintainers, but I would think that the changes to 
> change nl80211_chan_width_to_mhz from static to exported should be 
> separate from the patch to introduced WBRF support in the series.

Yeah, that'd be nice :)


> > +#define KHZ_TO_HZ(freq)		((freq) * 1000ULL)

Together with MHZ_TO_KHZ() for example :)

johannes