From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754097AbcKUKv1 (ORCPT ); Mon, 21 Nov 2016 05:51:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48720 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753502AbcKUKvZ (ORCPT ); Mon, 21 Nov 2016 05:51:25 -0500 Subject: Re: [PATCH v14 15/22] vfio: Introduce vfio_set_irqs_validate_and_prepare() To: Kirti Wankhede , alex.williamson@redhat.com, pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com References: <1479329194-10247-1-git-send-email-kwankhede@nvidia.com> <1479329194-10247-16-git-send-email-kwankhede@nvidia.com> Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com, jike.song@intel.com, bjsdjshi@linux.vnet.ibm.com, linux-kernel@vger.kernel.org From: Auger Eric Message-ID: <5a2ca21c-ccd0-7bb5-1a49-4ee03dbe9cd7@redhat.com> Date: Mon, 21 Nov 2016 11:51:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1479329194-10247-16-git-send-email-kwankhede@nvidia.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 21 Nov 2016 10:51:25 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 16/11/2016 21:46, Kirti Wankhede wrote: > Vendor driver using mediated device framework would use same mechnism to > validate and prepare IRQs. Introducing this function to reduce code > replication in multiple drivers. > > Signed-off-by: Kirti Wankhede > Signed-off-by: Neo Jia > Change-Id: Ie201f269dda0713ca18a07dc4852500bd8b48309 > --- > drivers/vfio/vfio.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/vfio.h | 4 ++++ > 2 files changed, 52 insertions(+) > > diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c > index 82257cf30f52..2c044af09a2c 100644 > --- a/drivers/vfio/vfio.c > +++ b/drivers/vfio/vfio.c > @@ -1858,6 +1858,54 @@ int vfio_info_add_capability(struct vfio_info_cap *caps, int cap_type_id, > } > EXPORT_SYMBOL(vfio_info_add_capability); > > +int vfio_set_irqs_validate_and_prepare(struct vfio_irq_set *hdr, int num_irqs, > + int max_irq_type, size_t *data_size) > +{ > + unsigned long minsz; > + size_t size; > + > + minsz = offsetofend(struct vfio_irq_set, count); > + > + if ((hdr->argsz < minsz) || (hdr->index >= max_irq_type) || > + (hdr->count >= (U32_MAX - hdr->start)) || > + (hdr->flags & ~(VFIO_IRQ_SET_DATA_TYPE_MASK | > + VFIO_IRQ_SET_ACTION_TYPE_MASK))) > + return -EINVAL; > + > + if (data_size) > + *data_size = 0; > + > + if (hdr->start >= num_irqs || hdr->start + hdr->count > num_irqs) > + return -EINVAL; > + > + switch (hdr->flags & VFIO_IRQ_SET_DATA_TYPE_MASK) { > + case VFIO_IRQ_SET_DATA_NONE: > + size = 0; > + break; > + case VFIO_IRQ_SET_DATA_BOOL: > + size = sizeof(uint8_t); > + break; > + case VFIO_IRQ_SET_DATA_EVENTFD: > + size = sizeof(int32_t); > + break; > + default: > + return -EINVAL; > + } > + > + if (size) { > + if (hdr->argsz - minsz < hdr->count * size) > + return -EINVAL; > + > + if (!data_size) > + return -EINVAL; nit: this could have done on the first check above. Reviewed-by: Eric Auger Thanks Eric > + > + *data_size = hdr->count * size; > + } > + > + return 0; > +} > +EXPORT_SYMBOL(vfio_set_irqs_validate_and_prepare); > + > /* > * Pin a set of guest PFNs and return their associated host PFNs for local > * domain only. > diff --git a/include/linux/vfio.h b/include/linux/vfio.h > index e26f7ccab564..15ff0421b423 100644 > --- a/include/linux/vfio.h > +++ b/include/linux/vfio.h > @@ -129,6 +129,10 @@ extern void vfio_info_cap_shift(struct vfio_info_cap *caps, size_t offset); > extern int vfio_info_add_capability(struct vfio_info_cap *caps, > int cap_type_id, void *cap_type); > > +extern int vfio_set_irqs_validate_and_prepare(struct vfio_irq_set *hdr, > + int num_irqs, int max_irq_type, > + size_t *data_size); > + > struct pci_dev; > #ifdef CONFIG_EEH > extern void vfio_spapr_pci_eeh_open(struct pci_dev *pdev); >