From: "Wu, Songjun" <Songjun.Wu@microchip.com>
To: Rob Herring <robh@kernel.org>
Cc: <nicolas.ferre@atmel.com>, <laurent.pinchart@ideasonboard.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver
Date: Mon, 1 Aug 2016 09:23:11 +0800 [thread overview]
Message-ID: <5a2cea98-dd8a-159b-7adb-a2533cfde1b0@microchip.com> (raw)
In-Reply-To: <20160729214454.GA21408@rob-hp-laptop>
On 7/30/2016 05:44, Rob Herring wrote:
> On Fri, Jul 29, 2016 at 03:54:08PM +0800, Songjun Wu wrote:
>> DT binding documentation for ISC driver.
>>
>> Signed-off-by: Songjun Wu <songjun.wu@microchip.com>
>> ---
>>
>> Changes in v7: None
>> Changes in v6:
>> - Add "iscck" and "gck" to clock-names.
>>
>> Changes in v5:
>> - Add clock-output-names.
>>
>> Changes in v4:
>> - Remove the isc clock nodes.
>>
>> Changes in v3:
>> - Remove the 'atmel,sensor-preferred'.
>> - Modify the isc clock node according to the Rob's remarks.
>>
>> Changes in v2:
>> - Remove the unit address of the endpoint.
>> - Add the unit address to the clock node.
>> - Avoid using underscores in node names.
>> - Drop the "0x" in the unit address of the i2c node.
>> - Modify the description of 'atmel,sensor-preferred'.
>> - Add the description for the ISC internal clock.
>>
>> .../devicetree/bindings/media/atmel-isc.txt | 65 ++++++++++++++++++++++
>> 1 file changed, 65 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/media/atmel-isc.txt
>
> Please add acks when posting new versions.
>
> Rob
>
Hi Rob,
Thank you for your reminder.
Should I Add 'Acked-by: Rob Herring <robh@kernel.org>' behind
'Signed-off-by: Songjun Wu <songjun.wu@microchip.com>'?
Should I resend this patch?
next prev parent reply other threads:[~2016-08-01 1:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 7:54 [PATCH v7 0/2] [media] atmel-isc: add driver for Atmel ISC Songjun Wu
2016-07-29 7:54 ` [PATCH v7 1/2] [media] atmel-isc: add the Image Sensor Controller code Songjun Wu
2016-08-01 9:47 ` Hans Verkuil
2016-08-02 6:20 ` Wu, Songjun
2016-08-02 7:32 ` Hans Verkuil
2016-08-02 7:48 ` Wu, Songjun
2016-07-29 7:54 ` [PATCH v7 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver Songjun Wu
2016-07-29 21:44 ` Rob Herring
2016-08-01 1:23 ` Wu, Songjun [this message]
2016-08-01 1:57 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a2cea98-dd8a-159b-7adb-a2533cfde1b0@microchip.com \
--to=songjun.wu@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).