From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A3DC433EF for ; Tue, 7 Sep 2021 10:10:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A889610FE for ; Tue, 7 Sep 2021 10:10:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245036AbhIGKLp convert rfc822-to-8bit (ORCPT ); Tue, 7 Sep 2021 06:11:45 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:41685 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244982AbhIGKLn (ORCPT ); Tue, 7 Sep 2021 06:11:43 -0400 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-285-AjN96C9hN9WOcY0vzSbalw-1; Tue, 07 Sep 2021 11:10:26 +0100 X-MC-Unique: AjN96C9hN9WOcY0vzSbalw-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Tue, 7 Sep 2021 11:10:19 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.023; Tue, 7 Sep 2021 11:10:19 +0100 From: David Laight To: "'Fabio M. De Francesco'" , Larry Finger , Phillip Potter , "Greg Kroah-Hartman" , Pavel Skripkin , "linux-staging@lists.linux.dev" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v3 3/3] staging: r8188eu: Shorten calls chain of rtw_write8/16/32/N() Thread-Topic: [PATCH v3 3/3] staging: r8188eu: Shorten calls chain of rtw_write8/16/32/N() Thread-Index: AQHXowbxud4S7oFeskKSrbEZlc25E6uYWqHg Date: Tue, 7 Sep 2021 10:10:19 +0000 Message-ID: <5a359f20e80341c9910ecc6286eb0aec@AcuMS.aculab.com> References: <20210904220048.12822-1-fmdefrancesco@gmail.com> <20210904220048.12822-4-fmdefrancesco@gmail.com> In-Reply-To: <20210904220048.12822-4-fmdefrancesco@gmail.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fabio M. De Francesco > Sent: 04 September 2021 23:01 > > Shorten the calls chain of rtw_write8/16/32() down to the actual writes. > For this purpose unify the four usb_write8/16/32/N() into the new > usb_write(); make the latter parameterizable with 'size'; embed most of > the code of usbctrl_vendorreq() into usb_write() and use in it the new > usb_control_msg_send() API of USB Core. > ... > diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c > index f9c4fd5a2c53..e31d1b1fdb12 100644 > --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c > +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c > @@ -8,76 +8,51 @@ > #include "../include/recv_osdep.h" > #include "../include/rtl8188e_hal.h" > > -static int usbctrl_vendorreq(struct intf_hdl *pintfhdl, u16 value, void *pdata, u16 len, u8 > requesttype) > +static int usb_read(struct intf_hdl *intfhdl, u32 addr, void *data, u8 size) > { > - struct adapter *adapt = pintfhdl->padapter; > - struct dvobj_priv *dvobjpriv = adapter_to_dvobj(adapt); > + u16 value = (u16)(addr & 0x0000ffff); > + struct adapter *adapt = intfhdl->padapter; > + struct dvobj_priv *dvobjpriv = adapter_to_dvobj(adapt); > struct usb_device *udev = dvobjpriv->pusbdev; > - unsigned int pipe; > - int status = 0; > - u8 *pIo_buf; > + int status; > + u8 *io_buf; Some of these changes are whitespace or renames. They ought to be in a different patch. I think you'll need 'reverse xmas tree' ordering as well. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)