From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <js1304@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
Minchan Kim <minchan@kernel.org>,
Alexander Potapenko <glider@google.com>,
Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2 2/7] mm/page_owner: initialize page owner without holding the zone lock
Date: Mon, 6 Jun 2016 17:20:03 +0200 [thread overview]
Message-ID: <5a37c41e-88cd-1345-218f-01b6760c0fd6@suse.cz> (raw)
In-Reply-To: <CAAmzW4NrJ8jFckmMdF+RY-++uoZ=RCpB34OF9+6=DEt1pSkQuw@mail.gmail.com>
On 06/03/2016 02:47 PM, Joonsoo Kim wrote:
[...]
>>> @@ -128,8 +127,12 @@ static void unset_migratetype_isolate(struct page
>>> *page, unsigned migratetype)
>>> zone->nr_isolate_pageblock--;
>>> out:
>>> spin_unlock_irqrestore(&zone->lock, flags);
>>> - if (isolated_page)
>>> + if (isolated_page) {
>>> + kernel_map_pages(page, (1 << order), 1);
>>
>>
>> So why we don't need the other stuff done by e.g. map_pages()? For example
>> arch_alloc_page() and kasan_alloc_pages(). Maybe kasan_free_pages() (called
>> below via __free_pages() I assume) now doesn't check if the allocation part
>> was done. But maybe it will start doing that?
>>
>> See how the multiple places doing similar stuff is fragile? :(
>
> I answered it in reply of comment of patch 1.
Right.
Acked-by: Vlastimil Babka <vbabka@suse.cz>
>
>>> + set_page_refcounted(page);
>>> + set_page_owner(page, order, __GFP_MOVABLE);
>>> __free_pages(isolated_page, order);
>>
>>
>> This mixing of "isolated_page" and "page" is not a bug, but quite ugly.
>> Can't isolated_page variable just be a bool?
>>
>
> Looks better. I will do it.
>
> Thanks.
>
next prev parent reply other threads:[~2016-06-06 15:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 2:37 [PATCH v2 1/7] mm/compaction: split freepages without holding the zone lock js1304
2016-05-26 2:37 ` [PATCH v2 2/7] mm/page_owner: initialize page owner " js1304
2016-06-03 10:23 ` Vlastimil Babka
2016-06-03 12:47 ` Joonsoo Kim
2016-06-06 15:20 ` Vlastimil Babka [this message]
2016-05-26 2:37 ` [PATCH v2 3/7] mm/page_owner: copy last_migrate_reason in copy_page_owner() js1304
2016-06-06 13:31 ` Vlastimil Babka
2016-05-26 2:37 ` [PATCH v2 4/7] mm/page_owner: introduce split_page_owner and replace manual handling js1304
2016-05-26 2:37 ` [PATCH v2 5/7] tools/vm/page_owner: increase temporary buffer size js1304
2016-05-26 2:37 ` [PATCH v2 6/7] mm/page_owner: use stackdepot to store stacktrace js1304
2016-06-06 13:56 ` Michal Hocko
2016-06-17 7:25 ` Joonsoo Kim
2016-06-17 9:55 ` Michal Hocko
2016-06-20 6:58 ` Joonsoo Kim
2016-06-06 14:51 ` Vlastimil Babka
2016-06-20 13:04 ` Alexander Potapenko
2016-05-26 2:37 ` [PATCH v2 7/7] mm/page_alloc: introduce post allocation processing on page allocator js1304
2016-06-06 15:21 ` Vlastimil Babka
2016-06-17 7:55 ` Joonsoo Kim
2016-06-03 10:10 ` [PATCH v2 1/7] mm/compaction: split freepages without holding the zone lock Vlastimil Babka
2016-06-03 12:45 ` Joonsoo Kim
2016-06-06 15:19 ` Vlastimil Babka
2016-06-13 20:31 ` Sasha Levin
2016-06-14 5:52 ` Joonsoo Kim
2016-06-14 19:10 ` Sasha Levin
2016-06-15 2:27 ` Joonsoo Kim
2016-06-17 7:27 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a37c41e-88cd-1345-218f-01b6760c0fd6@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=glider@google.com \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).