From: Saeed Mahameed <saeedm@mellanox.com>
To: Arnd Bergmann <arnd@arndb.de>, Matan Barak <matanb@mellanox.com>,
"Leon Romanovsky" <leonro@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Daniel Jurgens <danielj@mellanox.com>,
Tariq Toukan <tariqt@mellanox.com>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/3] net/mlx5e: use %pad format string for dma_addr_t
Date: Fri, 9 Dec 2016 01:16:22 +0200 [thread overview]
Message-ID: <5a451128-7d3a-1204-c2e2-2a928b8638e9@mellanox.com> (raw)
In-Reply-To: <20161208215727.44841-1-arnd@arndb.de>
On 12/08/2016 11:57 PM, Arnd Bergmann wrote:
> On 32-bit ARM with 64-bit dma_addr_t I get this warning about an
> incorrect format string:
>
> In file included from /git/arm-soc/drivers/net/ethernet/mellanox/mlx5/core/alloc.c:42:0:
> drivers/net/ethernet/mellanox/mlx5/core/alloc.c: In function ‘mlx5_frag_buf_alloc_node’:
> drivers/net/ethernet/mellanox/mlx5/core/alloc.c:134:12: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>
> We have the special %pad format for printing dma_addr_t, so use that
> to print the correct address and avoid the warning.
>
> Fixes: 1c1b522808a1 ("net/mlx5e: Implement Fragmented Work Queue (WQ)")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thank you Arnd !!
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
next prev parent reply other threads:[~2016-12-09 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 21:57 [PATCH net-next 1/3] net/mlx5e: use %pad format string for dma_addr_t Arnd Bergmann
2016-12-08 21:57 ` [PATCH net-next 2/3] net: xgene: move xgene_cle_ptree_ewdn data off stack Arnd Bergmann
2016-12-09 2:31 ` David Miller
2016-12-08 21:57 ` [PATCH net-next 3/3] net: xgene: avoid bogus maybe-uninitialized warning Arnd Bergmann
2016-12-09 2:31 ` David Miller
2016-12-08 23:16 ` Saeed Mahameed [this message]
2016-12-09 2:31 ` [PATCH net-next 1/3] net/mlx5e: use %pad format string for dma_addr_t David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a451128-7d3a-1204-c2e2-2a928b8638e9@mellanox.com \
--to=saeedm@mellanox.com \
--cc=arnd@arndb.de \
--cc=danielj@mellanox.com \
--cc=davem@davemloft.net \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).