From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jeremy Kerr <jk@ozlabs.org>,
userm57@yahoo.com, Finn Thain <fthain@telegraphics.com.au>,
"David S. Miller" <davem@davemloft.net>
Cc: Paul Mackerras <paulus@samba.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: bmac: Fix stack corruption panic in bmac_probe()
Date: Tue, 19 May 2020 19:19:25 +1000 [thread overview]
Message-ID: <5a6de40ebbf0587f245fcff2636080977fda9d96.camel@kernel.crashing.org> (raw)
In-Reply-To: <f23cf92ee3639e0112e67051009651a88dd0b53b.camel@ozlabs.org>
On Tue, 2020-05-19 at 08:59 +0800, Jeremy Kerr wrote:
> Hi Stan,
>
> > The new kernel compiled and booted with no errors, with these
> > STACKPROTECTOR options in .config (the last two revealed the bug):
> >
> > CONFIG_HAVE_STACKPROTECTOR=y
> > CONFIG_CC_HAS_STACKPROTECTOR_NONE=y
> > CONFIG_STACKPROTECTOR=y
> > CONFIG_STACKPROTECTOR_STRONG=y
>
> Brilliant, thanks for testing. I'll send a standalone patch to
> netdev.
Nice catch :-) Lots of people used these machines for years without
noticing :-) .... Granted most people used newer generation stuff with
a gmac instead.
Cheers,
Ben.
prev parent reply other threads:[~2020-05-19 9:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 0:20 [PATCH] net: bmac: Fix stack corruption panic in bmac_probe() Finn Thain
2020-05-18 1:06 ` Jeremy Kerr
[not found] ` <05aa357d-4b9c-4038-c0f4-1bfea613c6e4@yahoo.com>
2020-05-19 0:59 ` Jeremy Kerr
2020-05-19 9:19 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a6de40ebbf0587f245fcff2636080977fda9d96.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=jk@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=userm57@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).