From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07A04C433F5 for ; Fri, 30 Sep 2022 10:51:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231390AbiI3Kvk (ORCPT ); Fri, 30 Sep 2022 06:51:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231959AbiI3Kuu (ORCPT ); Fri, 30 Sep 2022 06:50:50 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 805B91A4089 for ; Fri, 30 Sep 2022 03:32:49 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id a3so6213390lfk.9 for ; Fri, 30 Sep 2022 03:32:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=VCcjqI6lIu04HFhLKmRbYa9mB8gAqC8jVTskBWTzJXo=; b=FHYSBxlEjRIKM8t17O7AXtrYySgUtZjTPoXBCaVIsnNxCcsyKanEZ40nuiWCkTPfA3 hoP6JdjjZh3JqFv0tn+sz+5JWzoxEVSRSrLFZ0JQ22UrIhdP/xg7saUtV+EazvbQBL9T I3V6zY9pyFYm93PhnGorlOkjbvJsZVpfhZlLH6yTVDMtqANOr0XcgmMXRX36e0TymXQz I0WL1lWBKkiyz5pZ6kkuliZcqkgc459DiUjr/DZlvZCaqZSfjDfx/Qe+lyzF0Qk7JRnE b16j/UmDTeKADHzTpCx1hsXzLZz8cQ9XJ6/akhlUqtsQ4jZGJLzAIsdeXPn1DuDEBDv1 D2gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=VCcjqI6lIu04HFhLKmRbYa9mB8gAqC8jVTskBWTzJXo=; b=fyoNaJa2fim1wEfw+Ptu/Ma1BBYmUN2jwuwg39dUCG7AZEzJbu4A0QmCYtPt9MXdg0 KcNh3YzHE/96WpolKC1xdtgcfThgZPyke279ziirtiJW5LVPwxoSIn8DnC0QMLUdeXUs 7y79S04V3lN8VKXwDhVzu0djYFUz62uibgufv56Nq9zZkpva2rIk2GSj/vNhjaMqQrLQ CpjgyklgjFx2bnJWg0ac9w4XLEMbA9jlS1+zGFwk3FV8URgEo0TjTFXOcNbLdZUOcNIy WSMVodvI6zRTcHk3x9aiB9j6hYzhrfwqrP1YEOZOP/ysnZbGsZa/T4Xfd0UfiA5a4uAH LR0w== X-Gm-Message-State: ACrzQf1dRrFHkC6dsVgettoViHuzTaHHUgvBtQeMdCIG52C/iJ3qu/Xr qtp93YBVvcZ3Cp1q4+CktNKMkA== X-Google-Smtp-Source: AMsMyM5s7ML6znk6zMTOl8dbaSCTLirncMLsCAGUYXeuPUEtGi4SXx9smkRDdsjGWoaplzPyHYYkKw== X-Received: by 2002:a05:6512:3128:b0:499:3c1d:f9e with SMTP id p8-20020a056512312800b004993c1d0f9emr3124332lfd.634.1664533902120; Fri, 30 Sep 2022 03:31:42 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id k29-20020a192d1d000000b0049e9122bd0esm253963lfj.114.2022.09.30.03.31.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 03:31:41 -0700 (PDT) Message-ID: <5a7816e8-9ee8-a2c6-04a1-d27807ace0f2@linaro.org> Date: Fri, 30 Sep 2022 12:31:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 1/3] dt-bindings: watchdog: xlnx,versal-wwdt: Add binding documentation for xilinx window watchdog device Content-Language: en-US To: Srinivas Neeli , wim@linux-watchdog.org, linux@roeck-us.net, shubhrajyoti.datta@amd.com, michal.simek@amd.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, git@amd.com References: <20220927110257.41963-1-srinivas.neeli@amd.com> <20220927110257.41963-2-srinivas.neeli@amd.com> From: Krzysztof Kozlowski In-Reply-To: <20220927110257.41963-2-srinivas.neeli@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/09/2022 13:02, Srinivas Neeli wrote: > Add documentation for the binding of window watchdog device. > > Signed-off-by: Srinivas Neeli > --- > .../bindings/watchdog/xlnx,versal-wwdt.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > new file mode 100644 > index 000000000000..986455efa6f4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/xlnx,versal-wwdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx Versal window watchdog timer controller > + > +maintainers: > + - Neeli Srinivas > + > +description: > + Versal watchdog driver uses window watchdog mode. Window watchdog > + timer(WWDT) contains closed(first) and open(second) window with > + 32 bit width. Write to the watchdog timer within predefined window > + periods of time. This means a period that is not too soon and a > + period that is not too late. The WWDT has to be restarted within > + the open window time. If software tries to restart WWDT outside of > + the open window time period, it generates a reset. > + Missing ref to watchdog. > +properties: > + compatible: > + enum: > + - xlnx,versal-wwdt-1.0 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + timeout-sec: true This can be dropped. > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false and this then can be unevaluatedProperties:false > + > +examples: > + - | > + watchdog@fd4d0000 { Use 4 spaces for example indentation. > + compatible = "xlnx,versal-wwdt-1.0"; > + reg = <0xfd4d0000 0x10000>; > + clocks = <&clock25>; > + timeout-sec = <30>; > + }; > +... Best regards, Krzysztof