From: John Syne <rodrigosiqueiramelo@gmail.com>
To: John Syne <john3909@gmail.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Barry Song <21cnbao@gmail.com>
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
daniel.baluta@nxp.com, linux-kernel@vger.kernel.org
Subject: [PATCH v3 2/8] staging:iio:ade7854: Fix the wrong number of bits to read
Date: Fri, 23 Mar 2018 11:25:48 -0300 [thread overview]
Message-ID: <5a7be7d02989db19d35f6d919fc9bce995666a55.1521813782.git.rodrigosiqueiramelo@gmail.com> (raw)
In-Reply-To: <cover.1521813782.git.rodrigosiqueiramelo@gmail.com>
Fixes: correctly handle the data size in the read operation for I2C
The function ade7854_i2c_read_reg_32() have to invoke the
i2c_master_recv() for read 32 bits values, however, the counter is set
to 3 which means 24 bits. This patch fixes the wrong size of 24 bits, to
32 bits.
Signed-off-by: John Syne <john3909@gmail.com>
Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
---
Changes in v3:
- Clarify authorship
- Add Fixes tag in the commit message
drivers/staging/iio/meter/ade7854-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c
index 4437f1e33261..37c957482493 100644
--- a/drivers/staging/iio/meter/ade7854-i2c.c
+++ b/drivers/staging/iio/meter/ade7854-i2c.c
@@ -191,7 +191,7 @@ static int ade7854_i2c_read_reg_32(struct device *dev,
if (ret < 0)
goto out;
- ret = i2c_master_recv(st->i2c, st->rx, 3);
+ ret = i2c_master_recv(st->i2c, st->rx, 4);
if (ret < 0)
goto out;
--
2.16.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-23 14:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 14:21 [PATCH v3 0/8] Cleanup on I2C/SPI code Rodrigo Siqueira
2018-03-23 14:22 ` [PATCH v3 1/8] staging:iio:ade7854: Fix error handling on read/write John Syne
2018-03-24 12:41 ` Jonathan Cameron
2018-03-23 14:25 ` John Syne [this message]
2018-03-24 13:23 ` [PATCH v3 2/8] staging:iio:ade7854: Fix the wrong number of bits to read Jonathan Cameron
2018-03-23 14:26 ` [PATCH v3 3/8] staging:iio:ade7854: Rework I2C write function Rodrigo Siqueira
2018-03-24 13:24 ` Jonathan Cameron
2018-03-23 14:26 ` [PATCH v3 4/8] staging:iio:ade7854: Rework SPI " Rodrigo Siqueira
2018-03-24 13:25 ` Jonathan Cameron
2018-03-23 14:26 ` [PATCH v3 5/8] staging:iio:ade7854: Remove write_reg_* duplications Rodrigo Siqueira
2018-03-24 13:26 ` Jonathan Cameron
2018-03-23 14:26 ` [PATCH v3 6/8] staging:iio:ade7854: Rework I2C read function Rodrigo Siqueira
2018-03-24 13:27 ` Jonathan Cameron
2018-03-23 14:27 ` [PATCH v3 7/8] staging:iio:ade7854: Rework SPI " Rodrigo Siqueira
2018-03-24 13:28 ` Jonathan Cameron
2018-03-23 14:27 ` [PATCH v3 8/8] staging:iio:ade7854: Remove read_reg_* duplications Rodrigo Siqueira
2018-03-24 13:29 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a7be7d02989db19d35f6d919fc9bce995666a55.1521813782.git.rodrigosiqueiramelo@gmail.com \
--to=rodrigosiqueiramelo@gmail.com \
--cc=21cnbao@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=john3909@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).