linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Ping-Ke Shih <pkshih@realtek.com>, Kalle Valo <kvalo@kernel.org>,
	Brett Hassall <brett.hassall@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Wireless <linux-wireless@vger.kernel.org>,
	Linux Regressions <regressions@lists.linux.dev>
Subject: Fwd: 5c8a79e8e12b ("wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS", 2023-05-27) increases CPU usage usage for irq
Date: Sun, 27 Aug 2023 09:37:21 +0700	[thread overview]
Message-ID: <5a7f2a6e-46a4-a5c8-fe6a-c2581496b5cd@gmail.com> (raw)

Hi,

I notice a regression report on Bugzilla [1]. Quoting from it:

> This commit improves power saving - it enables the kernel to achieve package C8. To achieve package C8, 3 Ubuntu VMD commits must be applied as well. The combined patch for the 3 Ubuntu VMD commits is attached (just in case). Package C8 lowers power usage on the laptop from 5.6W to 2.6W.
> 
> However, a side-effect of this commit is that CPU usage for irq/155-rtw88_pci has increased noticeably. This commit was introduced in 6.4-rc6. To confirm this commit is the cause, a branch was created from 6.4-rc5. This commit and the 3 Ubuntu VMD commits were applied. The resulting kernel was built and tested - it can achieve package C8 and exhibits the increased CPU usage on irq/155-rtw88_pci.
> 
> Booting and running top for 30 min with the system otherwise idle, gives these results for CPU on irq/155-rtw88_pci:
> 6.4-rc5     - 00:02.9, mostly   0% and 0.3% displayed
> patched rc5 - 00:13.4, mostly 0.7% and 1.0% displayed
> By comparison, an 8th Gen Dell with an Intel WIFI has CPU usage of 00:01.7 under the same conditions.
> 
> Laptop is a HP 15s-fq4011TU 11th Gen (Tiger Lake) Intel with (from lspci) Realtek Semiconductor Co., Ltd. RTL8822CE 802.11ac PCIe Wireless Network Adapter and Intel Corporation Volume Management Device NVMe RAID Controller.
> 
> Ubuntu bug https://bugs.launchpad.net/ubuntu/+source/linux-hwe-6.2/+bug/2025040 provides further background.
> 
> Please advise if I can assist with further testing.

See Bugzilla for the full thread and attached proposed patch(es) that fix
this regression.

Anyway, I'm adding this regression to be tracked by regzbot:

#regzbot introduced: 26a125f550a3bf https://bugzilla.kernel.org/show_bug.cgi?id=217828
#regzbot title: correcting SUPPORTS_DYNAMIC_PS calculation for rtw88 increases CPU utilization
#regzbot link: https://bugs.launchpad.net/ubuntu/+source/linux-hwe-6.2/+bug/2025040

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=217828

-- 
An old man doll... just what I always wanted! - Clara

             reply	other threads:[~2023-08-27  2:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-27  2:37 Bagas Sanjaya [this message]
2023-09-11 13:29 ` Fwd: 5c8a79e8e12b ("wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS", 2023-05-27) increases CPU usage usage for irq Linux regression tracking (Thorsten Leemhuis)
2023-09-15 23:04   ` brett hassall
2023-09-20 14:09     ` Thorsten Leemhuis
2023-09-22 20:52       ` brett hassall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a7f2a6e-46a4-a5c8-fe6a-c2581496b5cd@gmail.com \
    --to=bagasdotme@gmail.com \
    --cc=brett.hassall@gmail.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).