linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Fwd: 5c8a79e8e12b ("wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS", 2023-05-27) increases CPU usage usage for irq
@ 2023-08-27  2:37 Bagas Sanjaya
  2023-09-11 13:29 ` Linux regression tracking (Thorsten Leemhuis)
  0 siblings, 1 reply; 5+ messages in thread
From: Bagas Sanjaya @ 2023-08-27  2:37 UTC (permalink / raw)
  To: Ping-Ke Shih, Kalle Valo, Brett Hassall
  Cc: Linux Kernel Mailing List, Linux Wireless, Linux Regressions

Hi,

I notice a regression report on Bugzilla [1]. Quoting from it:

> This commit improves power saving - it enables the kernel to achieve package C8. To achieve package C8, 3 Ubuntu VMD commits must be applied as well. The combined patch for the 3 Ubuntu VMD commits is attached (just in case). Package C8 lowers power usage on the laptop from 5.6W to 2.6W.
> 
> However, a side-effect of this commit is that CPU usage for irq/155-rtw88_pci has increased noticeably. This commit was introduced in 6.4-rc6. To confirm this commit is the cause, a branch was created from 6.4-rc5. This commit and the 3 Ubuntu VMD commits were applied. The resulting kernel was built and tested - it can achieve package C8 and exhibits the increased CPU usage on irq/155-rtw88_pci.
> 
> Booting and running top for 30 min with the system otherwise idle, gives these results for CPU on irq/155-rtw88_pci:
> 6.4-rc5     - 00:02.9, mostly   0% and 0.3% displayed
> patched rc5 - 00:13.4, mostly 0.7% and 1.0% displayed
> By comparison, an 8th Gen Dell with an Intel WIFI has CPU usage of 00:01.7 under the same conditions.
> 
> Laptop is a HP 15s-fq4011TU 11th Gen (Tiger Lake) Intel with (from lspci) Realtek Semiconductor Co., Ltd. RTL8822CE 802.11ac PCIe Wireless Network Adapter and Intel Corporation Volume Management Device NVMe RAID Controller.
> 
> Ubuntu bug https://bugs.launchpad.net/ubuntu/+source/linux-hwe-6.2/+bug/2025040 provides further background.
> 
> Please advise if I can assist with further testing.

See Bugzilla for the full thread and attached proposed patch(es) that fix
this regression.

Anyway, I'm adding this regression to be tracked by regzbot:

#regzbot introduced: 26a125f550a3bf https://bugzilla.kernel.org/show_bug.cgi?id=217828
#regzbot title: correcting SUPPORTS_DYNAMIC_PS calculation for rtw88 increases CPU utilization
#regzbot link: https://bugs.launchpad.net/ubuntu/+source/linux-hwe-6.2/+bug/2025040

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=217828

-- 
An old man doll... just what I always wanted! - Clara

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fwd: 5c8a79e8e12b ("wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS", 2023-05-27) increases CPU usage usage for irq
  2023-08-27  2:37 Fwd: 5c8a79e8e12b ("wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS", 2023-05-27) increases CPU usage usage for irq Bagas Sanjaya
@ 2023-09-11 13:29 ` Linux regression tracking (Thorsten Leemhuis)
  2023-09-15 23:04   ` brett hassall
  0 siblings, 1 reply; 5+ messages in thread
From: Linux regression tracking (Thorsten Leemhuis) @ 2023-09-11 13:29 UTC (permalink / raw)
  To: Bagas Sanjaya, Ping-Ke Shih, Kalle Valo, Brett Hassall
  Cc: Linux Kernel Mailing List, Linux Wireless, Linux Regressions

On 27.08.23 04:37, Bagas Sanjaya wrote:
> 
> I notice a regression report on Bugzilla [1]. Quoting from it:
> 
>> This commit improves power saving - it enables the kernel to
>> achieve package C8. To achieve package C8, 3 Ubuntu VMD commits
>> must be applied as well. [...]

To me that sounds like there is no upstream problem, hence this
shouldn't be tracked as a regression. Please correct me if I'm wrong.

> #regzbot introduced: 26a125f550a3bf
> https://bugzilla.kernel.org/show_bug.cgi?id=217828 #regzbot title:
> correcting SUPPORTS_DYNAMIC_PS calculation for rtw88 increases CPU
> utilization #regzbot link:
> https://bugs.launchpad.net/ubuntu/+source/linux-hwe-6.2/+bug/2025040
> 
> Thanks.
> 
> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217828

#regzbot resolved: invalid: seems to only be a problem with a patched kernel
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fwd: 5c8a79e8e12b ("wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS", 2023-05-27) increases CPU usage usage for irq
  2023-09-11 13:29 ` Linux regression tracking (Thorsten Leemhuis)
@ 2023-09-15 23:04   ` brett hassall
  2023-09-20 14:09     ` Thorsten Leemhuis
  0 siblings, 1 reply; 5+ messages in thread
From: brett hassall @ 2023-09-15 23:04 UTC (permalink / raw)
  To: Linux regressions mailing list
  Cc: Bagas Sanjaya, Ping-Ke Shih, Kalle Valo,
	Linux Kernel Mailing List, Linux Wireless

Hi

I'd suggest that there are actually 2 regressions
(https://bugzilla.kernel.org/show_bug.cgi?id=217841 and this bug). Bug
217841 masks this bug as it prevents the laptop reaching package C8
and I'm assuming this bug shows when in C8. The patch for 21784 only
affects devices connected to a VMD controller so I wouldn't expect it
to affect the 8822CE.

Options that I can see are:
1. Park this bug until 217841 is resolved
2. Try to test on a laptop with a Realtek 8822CE but not a VMD
controller. I have access to 5 different laptop models but none meet
those criteria.


Thanks for the reply
Brett

On Mon, 11 Sept 2023 at 23:29, Linux regression tracking (Thorsten
Leemhuis) <regressions@leemhuis.info> wrote:
>
> On 27.08.23 04:37, Bagas Sanjaya wrote:
> >
> > I notice a regression report on Bugzilla [1]. Quoting from it:
> >
> >> This commit improves power saving - it enables the kernel to
> >> achieve package C8. To achieve package C8, 3 Ubuntu VMD commits
> >> must be applied as well. [...]
>
> To me that sounds like there is no upstream problem, hence this
> shouldn't be tracked as a regression. Please correct me if I'm wrong.
>
> > #regzbot introduced: 26a125f550a3bf
> > https://bugzilla.kernel.org/show_bug.cgi?id=217828 #regzbot title:
> > correcting SUPPORTS_DYNAMIC_PS calculation for rtw88 increases CPU
> > utilization #regzbot link:
> > https://bugs.launchpad.net/ubuntu/+source/linux-hwe-6.2/+bug/2025040
> >
> > Thanks.
> >
> > [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217828
>
> #regzbot resolved: invalid: seems to only be a problem with a patched kernel
> #regzbot ignore-activity
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fwd: 5c8a79e8e12b ("wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS", 2023-05-27) increases CPU usage usage for irq
  2023-09-15 23:04   ` brett hassall
@ 2023-09-20 14:09     ` Thorsten Leemhuis
  2023-09-22 20:52       ` brett hassall
  0 siblings, 1 reply; 5+ messages in thread
From: Thorsten Leemhuis @ 2023-09-20 14:09 UTC (permalink / raw)
  To: brett hassall, Linux regressions mailing list
  Cc: Bagas Sanjaya, Ping-Ke Shih, Kalle Valo,
	Linux Kernel Mailing List, Linux Wireless

On 16.09.23 01:04, brett hassall wrote:
> 
> I'd suggest that there are actually 2 regressions
> (https://bugzilla.kernel.org/show_bug.cgi?id=217841 and this bug). Bug
> 217841 masks this bug

Is that maybe a duplicate of this one:
https://bugzilla.kernel.org/show_bug.cgi?id=217321

In that case it might make sense to test with a proposed fix for that
bug (that iirc is
https://lore.kernel.org/all/20230911073352.3472918-1-mika.westerberg@linux.intel.com/
) to speed up fixing the rtw88 regression in case there is one.

Ciao, Thorsten

> as it prevents the laptop reaching package C8
> and I'm assuming this bug shows when in C8. The patch for 21784 only
> affects devices connected to a VMD controller so I wouldn't expect it
> to affect the 8822CE.
> 
> Options that I can see are:
> 1. Park this bug until 217841 is resolved
> 2. Try to test on a laptop with a Realtek 8822CE but not a VMD
> controller. I have access to 5 different laptop models but none meet
> those criteria.
> 
> 
> Thanks for the reply
> Brett
> 
> On Mon, 11 Sept 2023 at 23:29, Linux regression tracking (Thorsten
> Leemhuis) <regressions@leemhuis.info> wrote:
>>
>> On 27.08.23 04:37, Bagas Sanjaya wrote:
>>>
>>> I notice a regression report on Bugzilla [1]. Quoting from it:
>>>
>>>> This commit improves power saving - it enables the kernel to
>>>> achieve package C8. To achieve package C8, 3 Ubuntu VMD commits
>>>> must be applied as well. [...]
>>
>> To me that sounds like there is no upstream problem, hence this
>> shouldn't be tracked as a regression. Please correct me if I'm wrong.
>>
>>> #regzbot introduced: 26a125f550a3bf
>>> https://bugzilla.kernel.org/show_bug.cgi?id=217828 #regzbot title:
>>> correcting SUPPORTS_DYNAMIC_PS calculation for rtw88 increases CPU
>>> utilization #regzbot link:
>>> https://bugs.launchpad.net/ubuntu/+source/linux-hwe-6.2/+bug/2025040
>>>
>>> Thanks.
>>>
>>> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217828
>>
>> #regzbot resolved: invalid: seems to only be a problem with a patched kernel
>> #regzbot ignore-activity
>>
>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>> --
>> Everything you wanna know about Linux kernel regression tracking:
>> https://linux-regtracking.leemhuis.info/about/#tldr
>> If I did something stupid, please tell me, as explained on that page.
>>
>>
> 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fwd: 5c8a79e8e12b ("wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS", 2023-05-27) increases CPU usage usage for irq
  2023-09-20 14:09     ` Thorsten Leemhuis
@ 2023-09-22 20:52       ` brett hassall
  0 siblings, 0 replies; 5+ messages in thread
From: brett hassall @ 2023-09-22 20:52 UTC (permalink / raw)
  To: Thorsten Leemhuis
  Cc: Linux regressions mailing list, Bagas Sanjaya, Ping-Ke Shih,
	Kalle Valo, Linux Kernel Mailing List, Linux Wireless

Hi

I don't think it is a duplicate.

https://bugzilla.kernel.org/show_bug.cgi?id=217841 affects systems
with VMD controllers. I searched the lspci output from
https://bugzilla.kernel.org/show_bug.cgi?id=217321 and the system does
not have a VMD controller.

I also checked that patch code and it does not appear related.

Thanks

On Thu, 21 Sept 2023 at 00:09, Thorsten Leemhuis
<regressions@leemhuis.info> wrote:
>
> On 16.09.23 01:04, brett hassall wrote:
> >
> > I'd suggest that there are actually 2 regressions
> > (https://bugzilla.kernel.org/show_bug.cgi?id=217841 and this bug). Bug
> > 217841 masks this bug
>
> Is that maybe a duplicate of this one:
> https://bugzilla.kernel.org/show_bug.cgi?id=217321
>
> In that case it might make sense to test with a proposed fix for that
> bug (that iirc is
> https://lore.kernel.org/all/20230911073352.3472918-1-mika.westerberg@linux.intel.com/
> ) to speed up fixing the rtw88 regression in case there is one.
>
> Ciao, Thorsten
>
> > as it prevents the laptop reaching package C8
> > and I'm assuming this bug shows when in C8. The patch for 21784 only
> > affects devices connected to a VMD controller so I wouldn't expect it
> > to affect the 8822CE.
> >
> > Options that I can see are:
> > 1. Park this bug until 217841 is resolved
> > 2. Try to test on a laptop with a Realtek 8822CE but not a VMD
> > controller. I have access to 5 different laptop models but none meet
> > those criteria.
> >
> >
> > Thanks for the reply
> > Brett
> >
> > On Mon, 11 Sept 2023 at 23:29, Linux regression tracking (Thorsten
> > Leemhuis) <regressions@leemhuis.info> wrote:
> >>
> >> On 27.08.23 04:37, Bagas Sanjaya wrote:
> >>>
> >>> I notice a regression report on Bugzilla [1]. Quoting from it:
> >>>
> >>>> This commit improves power saving - it enables the kernel to
> >>>> achieve package C8. To achieve package C8, 3 Ubuntu VMD commits
> >>>> must be applied as well. [...]
> >>
> >> To me that sounds like there is no upstream problem, hence this
> >> shouldn't be tracked as a regression. Please correct me if I'm wrong.
> >>
> >>> #regzbot introduced: 26a125f550a3bf
> >>> https://bugzilla.kernel.org/show_bug.cgi?id=217828 #regzbot title:
> >>> correcting SUPPORTS_DYNAMIC_PS calculation for rtw88 increases CPU
> >>> utilization #regzbot link:
> >>> https://bugs.launchpad.net/ubuntu/+source/linux-hwe-6.2/+bug/2025040
> >>>
> >>> Thanks.
> >>>
> >>> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217828
> >>
> >> #regzbot resolved: invalid: seems to only be a problem with a patched kernel
> >> #regzbot ignore-activity
> >>
> >> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> >> --
> >> Everything you wanna know about Linux kernel regression tracking:
> >> https://linux-regtracking.leemhuis.info/about/#tldr
> >> If I did something stupid, please tell me, as explained on that page.
> >>
> >>
> >
> >

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-09-22 20:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-27  2:37 Fwd: 5c8a79e8e12b ("wifi: rtw88: correct PS calculation for SUPPORTS_DYNAMIC_PS", 2023-05-27) increases CPU usage usage for irq Bagas Sanjaya
2023-09-11 13:29 ` Linux regression tracking (Thorsten Leemhuis)
2023-09-15 23:04   ` brett hassall
2023-09-20 14:09     ` Thorsten Leemhuis
2023-09-22 20:52       ` brett hassall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).