From: Chao Yu <yuchao0@huawei.com>
To: Yunlong Song <yunlong.song@huawei.com>, <jaegeuk@kernel.org>,
<chao@kernel.org>, <yunlong.song@icloud.com>
Cc: <miaoxie@huawei.com>, <bintian.wang@huawei.com>,
<shengyong1@huawei.com>, <heyunlei@huawei.com>,
<linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] f2fs: only flush the single temp bio cache which owns the target page
Date: Wed, 24 Oct 2018 17:55:08 +0800 [thread overview]
Message-ID: <5a92fd67-5a36-b14e-0c4d-820bcaa86568@huawei.com> (raw)
In-Reply-To: <1540368651-14353-1-git-send-email-yunlong.song@huawei.com>
Hi Yunlong,
On 2018/10/24 16:10, Yunlong Song wrote:
> Previously, when f2fs finds which temp bio cache owns the target page,
> it will flush all the three temp bio caches, but we only need to flush
> one single bio cache indeed, which can help to keep bio merged.
>
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
> fs/f2fs/data.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 106f116..04ebbad 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -374,7 +374,7 @@ static bool __has_merged_page(struct f2fs_bio_info *io, struct inode *inode,
>
> static bool has_merged_page(struct f2fs_sb_info *sbi, struct inode *inode,
> struct page *page, nid_t ino,
> - enum page_type type)
> + enum page_type type, enum temp_type *owner)
> {
> enum page_type btype = PAGE_TYPE_OF_BIO(type);
> enum temp_type temp;
> @@ -392,6 +392,10 @@ static bool has_merged_page(struct f2fs_sb_info *sbi, struct inode *inode,
> if (ret || btype == META)
> break;
> }
> + if (!ret || (!inode && !page && !ino))
> + *owner = NR_TEMP_TYPE;
> + else
> + *owner = temp;
> return ret;
> }
>
> @@ -421,9 +425,14 @@ static void __submit_merged_write_cond(struct f2fs_sb_info *sbi,
> {
> enum temp_type temp;
>
> - if (!force && !has_merged_page(sbi, inode, page, ino, type))
> + if (!force && !has_merged_page(sbi, inode, page, ino, type, &temp))
> return;
>
> + if (!force && temp != NR_TEMP_TYPE) {
> + __f2fs_submit_merged_write(sbi, type, temp);
I think we need to add has_merged_page into __f2fs_submit_merged_write to
check whether we should submit bio from different log, otherwise we will
missed to submit bio in below condition:
- f2fs_write_cache_pages
- add page into bio cache of cold log
- add page into bio cache of warm log
- f2fs_submit_merged_write_cond(inode)
- __f2fs_submit_merged_write(warm) -- missed to submit bio of cold log
Thanks,
> + return;
> + }
> +
> for (temp = HOT; temp < NR_TEMP_TYPE; temp++) {
>
> __f2fs_submit_merged_write(sbi, type, temp);
>
next prev parent reply other threads:[~2018-10-24 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 8:10 [PATCH] f2fs: only flush the single temp bio cache which owns the target page Yunlong Song
2018-10-24 9:55 ` Chao Yu [this message]
2018-10-24 11:35 ` [PATCH v2] " Yunlong Song
2018-10-25 1:35 ` Chao Yu
2018-11-13 0:15 ` Jaegeuk Kim
2018-11-13 3:57 ` [PATCH v3] " Yunlong Song
2018-11-14 10:49 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a92fd67-5a36-b14e-0c4d-820bcaa86568@huawei.com \
--to=yuchao0@huawei.com \
--cc=bintian.wang@huawei.com \
--cc=chao@kernel.org \
--cc=heyunlei@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=shengyong1@huawei.com \
--cc=yunlong.song@huawei.com \
--cc=yunlong.song@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).