From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4094FECE564 for ; Tue, 18 Sep 2018 20:05:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFEE02150F for ; Tue, 18 Sep 2018 20:05:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFEE02150F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730063AbeISBji (ORCPT ); Tue, 18 Sep 2018 21:39:38 -0400 Received: from mga18.intel.com ([134.134.136.126]:65038 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729695AbeISBjh (ORCPT ); Tue, 18 Sep 2018 21:39:37 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2018 13:05:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,391,1531810800"; d="scan'208";a="258349847" Received: from wdawidox-mobl.ger.corp.intel.com (HELO [10.249.146.61]) ([10.249.146.61]) by orsmga005.jf.intel.com with ESMTP; 18 Sep 2018 13:05:25 -0700 Subject: Re: [RFC/PATCH 0/5] Support children for legacy device properties To: Dmitry Torokhov Cc: Linus Walleij , linux-input@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko References: <20180917181603.125492-1-dmitry.torokhov@gmail.com> From: "Rafael J. Wysocki" Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego 173, 80-298 Gdansk Message-ID: <5ab2968e-8ba5-adea-7862-3e9114623d63@intel.com> Date: Tue, 18 Sep 2018 22:05:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180917181603.125492-1-dmitry.torokhov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/17/2018 8:15 PM, Dmitry Torokhov wrote: > The generic device properties APIs are very helpful as they allow abstracting > away details of the platform (whether it is ACPI, device tree, or legacy board > file), so that individual driver does not need separate code paths to support > all variants. However there are drivers that currently can not use generic > device properties API as they need notion of children properties, for example > gpio_keys driver, that expects every button to be described as a sub-node of > main device. > > This patch series introduces notion of sub-nodes for static properties and ties > it up with GPIO lookup tables so that they are usable with sub-nodes as well. I don't have any objections against this series. Thanks, Rafael