linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Greg KH <gregkh@linuxfoundation.org>, Nirmoy Das <nirmoy.das@amd.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] debugfs: use IS_ERR to check for error
Date: Thu, 2 Sep 2021 14:03:12 +0200	[thread overview]
Message-ID: <5ab7739d-15a4-2e84-0320-fee8d5df1e83@amd.com> (raw)
In-Reply-To: <YTCpuo00wM7jGSIc@kroah.com>



Am 02.09.21 um 12:38 schrieb Greg KH:
> On Thu, Sep 02, 2021 at 12:29:17PM +0200, Nirmoy Das wrote:
>> debugfs_create_file() returns encoded error so
>> use IS_ERR for checking return value.
>>
>> References: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fdrm%2Famd%2F-%2Fissues%2F1686&amp;data=04%7C01%7CChristian.Koenig%40amd.com%7C82691bea64d3491fe86008d96dfddc60%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637661759378883940%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Xs4xnihnMzNvl%2BSEEpCcWkdvMaDw1Ofvekn%2Fnvz1mM8%3D&amp;reserved=0
>> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
>> ---
>>   fs/debugfs/inode.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
>> index 8129a430d789..2f117c57160d 100644
>> --- a/fs/debugfs/inode.c
>> +++ b/fs/debugfs/inode.c
>> @@ -528,7 +528,7 @@ void debugfs_create_file_size(const char *name, umode_t mode,
>>   {
>>   	struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
>>   
>> -	if (de)
>> +	if (!IS_ERR(de))
>>   		d_inode(de)->i_size = file_size;
>>   }
>>   EXPORT_SYMBOL_GPL(debugfs_create_file_size);
>> -- 
>> 2.32.0
>>
> Ah, good catch, I'll queue this up after 5.15-rc1 is out, thanks!

Thinking more about this if I'm not completely mistaken 
debugfs_create_file() returns -ENODEV when debugfs is disabled and NULL 
on any other error.

So this needs to be IS_ERR_OR_NULL().

Regards,
Christian.

>
> greg k-h


  reply	other threads:[~2021-09-02 12:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 10:29 [PATCH 1/1] debugfs: use IS_ERR to check for error Nirmoy Das
2021-09-02 10:31 ` Christian König
2021-09-02 10:38 ` Greg KH
2021-09-02 12:03   ` Christian König [this message]
2021-09-02 12:20     ` Greg KH
2021-09-02 15:10       ` Christian König
2021-09-02 16:34         ` Greg KH
2021-09-02 16:44           ` Das, Nirmoy
2021-09-02 16:48           ` Das, Nirmoy
2021-09-02 17:01           ` Das, Nirmoy
2021-09-03  6:27             ` Christian König
2021-09-21  7:03               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ab7739d-15a4-2e84-0320-fee8d5df1e83@amd.com \
    --to=christian.koenig@amd.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nirmoy.das@amd.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).