From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Mathieu Malaterre <malat@debian.org>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>,
linux-doc@vger.kernel.org, linux-watchdog@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
od@zcrc.me, linux-mips@linux-mips.org,
Paul Burton <paul.burton@mips.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH v7 05/24] clocksource: Add a new timer-ingenic driver
Date: Wed, 26 Sep 2018 10:05:13 +0200 [thread overview]
Message-ID: <5af26854-0752-312b-6148-3ffa9abb2570@linaro.org> (raw)
In-Reply-To: <5bab3024.1c69fb81.b6a71.9c38SMTPIN_ADDED_MISSING@mx.google.com>
On 26/09/2018 08:01, Paul Cercueil wrote:
>
> Le 25 sept. 2018 10:12 PM, Daniel Lezcano <daniel.lezcano@linaro.org> a écrit :
>>
>> On 25/09/2018 15:38, Paul Cercueil wrote:
>>>
>>> Le 24 sept. 2018 9:14 AM, Daniel Lezcano <daniel.lezcano@linaro.org> a écrit :
>>>>
>>>> On 24/09/2018 08:53, Paul Cercueil wrote:
>>>>>
>>>>> Le 24 sept. 2018 07:58, Daniel Lezcano <daniel.lezcano@linaro.org> a écrit :
>>>>>>
>>>>>> On 24/09/2018 07:49, Paul Cercueil wrote:
>>>>>>>
>>>>>>> Le 24 sept. 2018 07:35, Daniel Lezcano <daniel.lezcano@linaro.org> a
>>>>>>> écrit :
>>>>>>>>
>>>>>>>> On 24/09/2018 07:24, Paul Cercueil wrote:
>>>>>>>>> Hi Daniel,
>>>>>>>>>
>>>>>>>>> Le 24 sept. 2018 05:12, Daniel Lezcano
>>>>>>>>> <daniel.lezcano@linaro.org> a écrit :
>>>>>>>>>>
>>>>>>>>>> On 21/08/2018 19:16, Paul Cercueil wrote:
>>>>>>>>>>> This driver handles the TCU (Timer Counter Unit) present on
>>>>>>>>>>> the Ingenic JZ47xx SoCs, and provides the kernel with a
>>>>>>>>>>> system timer, and optionally with a clocksource and a
>>>>>>>>>>> sched_clock.
>>>>>>>>>>>
>>>>>>>>>>> It also provides clocks and interrupt handling to client
>>>>>>>>>>> drivers.
>>>>>>>>>>
>>>>>>>>>> Can you provide a much more complete description of the timer
>>>>>>>>>> in order to make my life easier for the review of this patch?
>>>>>>>>>
>>>>>>>>> See patch [03/24], it adds a doc file that describes the
>>>>>>>>> hardware.
>>>>>>>>
>>>>>>>> Thanks, I went through but it is incomplete to understand what the
>>>>>>>> timer do. I will reverse-engineer the code but it would help if you
>>>>>>>> can give the gross approach. Why multiple channels ? mutexes and
>>>>>>>> completion ?
>>>>>>>
>>>>>>> Much of the complexity is because of the multi-purpose nature of the
>>>>>>> TCU channels. Each one can be used as timer/clocksource, or PWM.
>>>>>>>
>>>>>>> The driver starts by using channels 0 and 1 as system timer and
>>>>>>> clocksource, respectively, the other ones being unused for now. Then,
>>>>>>> *if* the PWM driver requests one of the channels in use by the
>>>>>>> timer/clocksource driver, say channel 0, the timer/clocksource driver
>>>>>>> will dynamically reassign the system timer to a free channel, from
>>>>>>> channel 0 to e.g. channel 2. Only in that case the completion/mutex
>>>>>>> are actually used.
>>>>>>
>>>>>> Why do you need to do this? Can't be the channels dedicated and reserved
>>>>>> for clocksource and clockevent?
>>>>>
>>>>> That's what I had in place (ingenic,timer-channel and ingenic,clocksource-channel DT properties), but Rob didn't want any linux-specific properties in the devicetree binding :(
>>>>
>>>> Isn't possible to specify the channel to use in the DT? like renesas16 ?
>>>
>>> That's what I did in V6 (and before), but Rob did not want me to add properties for Linux-specific concepts such as clocksource.
>>
>> Hmm, I remember something like that, yes but I did a delete of the
>> previous version when you posted the v7. Can you give a pointer to its
>> answer ?
>
> Yes, this was his answer:
> https://lkml.org/lkml/2018/7/25/508
>
> Then mine:
> https://lkml.org/lkml/2018/7/30/883
Thanks !
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next parent reply other threads:[~2018-09-26 8:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5bab3024.1c69fb81.b6a71.9c38SMTPIN_ADDED_MISSING@mx.google.com>
2018-09-26 8:05 ` Daniel Lezcano [this message]
[not found] <5baa3fa9.1c69fb81.4c7b7.19fdSMTPIN_ADDED_MISSING@mx.google.com>
2018-09-25 20:12 ` [PATCH v7 05/24] clocksource: Add a new timer-ingenic driver Daniel Lezcano
[not found] <5ba88a1a.1c69fb81.2ba56.ccdaSMTPIN_ADDED_MISSING@mx.google.com>
2018-09-24 7:14 ` Daniel Lezcano
[not found] <5ba87b02.1c69fb81.1da88.1457SMTPIN_ADDED_MISSING@mx.google.com>
2018-09-24 5:58 ` Daniel Lezcano
[not found] <5ba8750a.1c69fb81.501e8.d0f0SMTPIN_ADDED_MISSING@mx.google.com>
2018-09-24 5:35 ` Daniel Lezcano
2018-08-21 17:16 [PATCH v7 00/24] TCU patchset v7 Paul Cercueil
2018-08-21 17:16 ` [PATCH v7 05/24] clocksource: Add a new timer-ingenic driver Paul Cercueil
2018-08-28 17:23 ` Paul Burton
2018-08-29 9:10 ` Daniel Lezcano
2018-08-29 17:43 ` Paul Burton
2018-09-24 3:12 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5af26854-0752-312b-6148-3ffa9abb2570@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=malat@debian.org \
--cc=mark.rutland@arm.com \
--cc=od@zcrc.me \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).