From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932188AbdDQPb1 (ORCPT ); Mon, 17 Apr 2017 11:31:27 -0400 Received: from mout.web.de ([212.227.17.11]:57107 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754636AbdDQPbZ (ORCPT ); Mon, 17 Apr 2017 11:31:25 -0400 Subject: [PATCH 21/25] net: pxa168_eth: Use kcalloc() in two functions From: SF Markus Elfring To: netdev@vger.kernel.org, "David S. Miller" , Florian Fainelli , Jarod Wilson , Jisheng Zhang , Mirko Lindner , Philippe Reynes , Russell King , Sergei Shtylyov , Stephen Hemminger , Thomas Petazzoni Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <5afe517a-ac25-dae2-55b9-71bef428a389@users.sourceforge.net> Date: Mon, 17 Apr 2017 17:31:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:wVfGUyVC5Krc1+Kh2fDnxLpSKsp6G5J09gVB6aFHRJwWsriBhAg Lm/xZeHCyemUUzr9XKj/oI17VknAEjbvO+kkVH/ummcMdm2dfmS5tmMrsymOp5s0hLD7pKb noTnsKL2V8gd76koAPrkkg6mnP1T2ys/UbhkVEl799eHOG2YThf5WS+IQXtw+yKmmZKcXNj WlGvRl7Atv9jSxN5cG72A== X-UI-Out-Filterresults: notjunk:1;V01:K0:yjuB/XnW358=:0DdoZQnVl/GwBme+hdsOpb NqkGjnWl1vutlwf3r6xcSD/cS/WtCqkBrX19Bn9aySJbpb94cMS5sJabq4Z/6cPqXMTzKu4Kj qVXfNnAx7XzJxMkmXOxVEpGpPAtrrRl10VNWQbm333EEqGGZPXF1rccfbloX/R5ciMTsNZaLg i7CNMqt5kb3J8WEDPa9fkdE7hBz+tv6Jef2xNfeLYi5umGnfjyIJ2D+HHqu2ltaqL2bVmRtco rNwGHyr9gzgoG+mUeXSPsqjmxvC35+zQMPU9uN0poFk29uEm/El0teZqj5z25HJ//gVzqzHIm lj/MacpkUl6eIg3PhWgkchM+HZ1J41NQ2d7CKXy1Pc2e+2wraQ957Oc954Ki7mzju8ZyTB0Ee HbpheGqEh86hngYKInBmxhvB4lLnWJjHUYq+lcXcg51+d8GcO1lqMC82Y1gUGMuVYczC/t1JB uzDlYIczbUonywWv4qU5s1NZzpfI43AW76t+cfs/WIoGVMabx+6Vbkino3+oJB6baFdR4kBYG vJCrM5k0BP05Mi03DgYlNoRvcdXhG/7B6ICmwkwC2vp2E9xy5qAmbV2/1VSe8DEQkguJ1YTwr LPJ25In23jF7wew8cTEe61FkMk1t0wFAq96WDkmLdOhXrmSpIxcxXq0GIBGDMc11Z/pzwT3Xk 1vd5BjV+Ql3vZLkMaoenlnYfej9Tb2k1SnFFf3nCZCdVv5uVH7iTA4lfp0gl3WUAjdsL5zgfm iJYb6/VEX6x+43LL+I2fxZd7FDTWt05dBz4g6R/Ek2PDZMysjY8V0Q2rJt9z+TXUNGywn9l6U QOTjPBB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 17 Apr 2017 14:32:14 +0200 Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/pxa168_eth.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index 28cb36d9e50a..2404eac51c63 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c @@ -1036,8 +1036,7 @@ static int rxq_init(struct net_device *dev) int rx_desc_num = pep->rx_ring_size; /* Allocate RX skb rings */ - pep->rx_skb = kzalloc(sizeof(*pep->rx_skb) * pep->rx_ring_size, - GFP_KERNEL); + pep->rx_skb = kcalloc(rx_desc_num, sizeof(*pep->rx_skb), GFP_KERNEL); if (!pep->rx_skb) return -ENOMEM; @@ -1096,8 +1095,7 @@ static int txq_init(struct net_device *dev) int size = 0, i = 0; int tx_desc_num = pep->tx_ring_size; - pep->tx_skb = kzalloc(sizeof(*pep->tx_skb) * pep->tx_ring_size, - GFP_KERNEL); + pep->tx_skb = kcalloc(tx_desc_num, sizeof(*pep->tx_skb), GFP_KERNEL); if (!pep->tx_skb) return -ENOMEM; -- 2.12.2