From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen McCamant <smccaman@umn.edu>, Qiushi Wu <wu000273@umn.edu>,
Alexandre Torgue <alexandre.torgue@st.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: stmfts: fix ref count leak in stmfts_input_open
Date: Sun, 14 Jun 2020 11:33:34 +0200 [thread overview]
Message-ID: <5b0147ab-f0bc-7380-6300-90e555534cb4@web.de> (raw)
> in stmfts_input_open, …
* Can the term “reference count” become relevant also for this commit message
besides other possible adjustments?
* Would you like to add the tag “Fixes”?
…
> +++ b/drivers/input/touchscreen/stmfts.c
…
> @@ -367,6 +367,9 @@ static int stmfts_input_open(struct input_dev *dev)
> }
>
> return 0;
> +out:
> + pm_runtime_put(&sdata->client->dev);
> + return err;
> }
…
Perhaps use the label “put_runtime” instead?
Regards,
Markus
next reply other threads:[~2020-06-14 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 9:33 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-14 6:18 [PATCH] Input: stmfts: fix ref count leak in stmfts_input_open Navid Emamdoost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b0147ab-f0bc-7380-6300-90e555534cb4@web.de \
--to=markus.elfring@web.de \
--cc=alexandre.torgue@st.com \
--cc=dmitry.torokhov@gmail.com \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=navid.emamdoost@gmail.com \
--cc=smccaman@umn.edu \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).